STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
10826 commits 87 branches 0 tags 160 MiB
Commit graph

5503 commits

Author SHA1 Message Date
Meredith Lancaster
6dbb3fe541
Merge pull request #10750 from malancas/refactor-sigstore-verifier-logic 
Refactor Sigstore verifier logic
 2025-04-15 09:05:47 -06:00
Andy Feller
f928cb1e19 Fix remaining search logic totals 2025-04-15 08:36:45 -04:00
Andy Feller
15ff7ba465 Restore result.Total logic, fix formatting 
This change restores the original logic of passing the search total count logic as is to the result.

Additionally, this undoes some of the contributor's formatting changes that increase the changed lines to review.
 2025-04-15 08:00:47 -04:00
Kynan Ware
f283d6d11c feat(iostreams): textual progress indicator does not clear screen 
This bypasses the `spinner` package for the textual progress indicator for users
with the spinner disabled out of concerns for accessibility, specifically
with screen readers:

- The `spinner` package will continuously re-draw the screen. I wasn't
able to have this cause problems with my Mac screen reader, but it's
nonetheless a concern that other screen readers may not handle this
screen re-drawing well.
- The `spinner` package clears any progress indicator messages from the screen
when stopping the progress indicator or changing its label.
This is a problem because it interrupts screen readers and leaves no way
to recover what the loading message was by scrolling up in the terminal.

NOTE: this new implementation still interrupts the screen reader when
the a new label is printed, but it does not clear the screen. This makes
the loading messages recoverable, at least.
 2025-04-14 19:30:05 -06:00
Kynan Ware
3eba461afb fix(iostreams): spinner env var is now in factory 
- Move env var evaluation to the factory defaults.
- Use only the label for the spinner instead of adding
"working..." every time. "working..." remains the default
when no label is provided.
 2025-04-14 15:07:11 -06:00
Kynan Ware
3aadd51096 feat(iostreams): Option to opt out of spinners 2025-04-11 16:18:50 -06:00
William Martin
408e21ebdd
Merge pull request #10769 from cli/babakks/fix-job-log-resolution 
Fix job log resolution to skip legacy logs in favour of normal/new ones
 2025-04-11 16:16:39 +02:00
Babak K. Shandiz
f337ce90a0
Explain job log resolution reason 
Signed-off-by: Babak K. Shandiz <babakks@github.com>
 2025-04-11 14:51:39 +01:00
William Martin
2a2678116f
Merge pull request #10609 from iamazeem/10228-gh-ext 
[gh ext] Fix `GitKind` extension directory path
 2025-04-11 15:51:16 +02:00
William Martin
48274f3118 Document UNKNOWN STEP in run view 2025-04-11 15:23:18 +02:00
Babak K. Shandiz
b65286125b
Add $ anchor to log file regexps 
Signed-off-by: Babak K. Shandiz <babakks@github.com>

This is to make sure we do not pick up the wrong file if there is a
`.txt` sequence in the middle of a job name.
 2025-04-11 12:41:31 +01:00
Babak K. Shandiz
2d21b4624c
Test normal job run log is preferred over legacy one 
Signed-off-by: Babak K. Shandiz <babakks@github.com>
 2025-04-11 12:40:26 +01:00
Babak K. Shandiz
940bd10a1d
Prefer normal job run log file over legacy one 
Signed-off-by: Babak K. Shandiz <babakks@github.com>
 2025-04-11 12:39:09 +01:00
William Martin
83bd23b080
Merge pull request #10740 from cli/babakks/fallback-to-job-run-logs 
Fallback to job run logs when step logs are missing
 2025-04-11 11:39:07 +02:00
Babak K. Shandiz
5adf3285ec
Explain when a negative number prefix appears 
Signed-off-by: Babak K. Shandiz <babakks@github.com>
 2025-04-11 10:26:14 +01:00
Babak K. Shandiz
d35236948c
Improve explanation for missing step logs 
Signed-off-by: Babak K. Shandiz <babakks@github.com>
 2025-04-11 10:17:52 +01:00
Babak K. Shandiz
1bf1153c54
Explain the UNKNWON STEP placeholder 
Signed-off-by: Babak K. Shandiz <babakks@github.com>
 2025-04-11 10:08:36 +01:00
Babak K. Shandiz
f673b409f7
Replace UNKNOWN with UNKNOWN STEP in job run log 
Signed-off-by: Babak K. Shandiz <babakks@github.com>
 2025-04-11 09:57:13 +01:00
Babak K. Shandiz
0251a8dd6d
Explain why step logs are preferred 
Signed-off-by: Babak K. Shandiz <babakks@github.com>
 2025-04-11 09:56:17 +01:00
Kynan Ware
dec71dd9e1
Merge pull request #10710 from cli/kw/first-pass-accessible-prompter 
Introduce accessible prompter for screen readers (preview)
 2025-04-10 17:28:26 -06:00
Babak K. Shandiz
791e1af828
Add missing gc.AssertExpectations calls 
Signed-off-by: Babak K. Shandiz <babakks@github.com>
 2025-04-10 14:09:49 +01:00
Babak K. Shandiz
f0d4acd501
Add tests for IsPinned method 
Signed-off-by: Babak K. Shandiz <babakks@github.com>
 2025-04-10 14:00:24 +01:00
leudz
072534c388 Fix multi pages search for gh search 2025-04-10 07:57:43 +02:00
Kynan Ware
19633d3855
Merge pull request #10516 from iamazeem/8430-show-hostname-in-repo-creation-prompts 
[gh repo create] Show host name in repo creation prompts
 2025-04-09 14:30:56 -06:00
Kynan Ware
a34c9ea799 doc(prompter env): accessible prompter includes braille reader 
Co-authored-by: Andy Feller <andyfeller@github.com>
 2025-04-09 08:20:07 -06:00
Kynan Ware
861563269a Merge branch 'trunk' into kw/first-pass-accessible-prompter 2025-04-09 08:07:56 -06:00
Meredith Lancaster
139e82c68c Revert "temporarily skip non-failing tests" 
This reverts commit de8778797f.
 2025-04-09 07:23:17 -06:00
Meredith Lancaster
7b20ee5549
Merge pull request #10749 from malancas/update-to-sigstore-go-v0.7.1 
Update github.com/sigstore/sigstore-go to 0.7.1 and fix breaking function change
 2025-04-09 11:58:20 +02:00
Meredith Lancaster
de8778797f temporarily skip non-failing tests 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-04-08 19:09:52 -06:00
Meredith Lancaster
29080dc70a reorganize func 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-04-08 16:40:52 -06:00
Meredith Lancaster
d63e2830e0 clean up unneeded sigstore verifier fields 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-04-08 16:35:17 -06:00
Meredith Lancaster
a535cfdbfc flip verifier choice logic 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-04-08 16:28:56 -06:00
Meredith Lancaster
2559a83945 Merge branch 'refactor-sigstore-verifier-logic' of github.com:malancas/cli into refactor-sigstore-verifier-logic 2025-04-08 16:23:46 -06:00
Meredith Lancaster
366485155e initiate custom verifiers when the sgistore verifier is created 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-04-08 16:23:37 -06:00
Meredith Lancaster
a3bfb158e4
Merge branch 'trunk' into refactor-sigstore-verifier-logic 2025-04-08 16:00:40 -06:00
Meredith Lancaster
323ea74733 add public good and github verifiers as fields for repeated use instead of creating a new one for every attestation 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-04-08 15:40:55 -06:00
Meredith Lancaster
35ec7f251c replace sigstore-go test bundle func 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-04-08 15:20:51 -06:00
Kynan Ware
abd573ac66 feat(preview): add preview prompter command 2025-04-08 15:14:28 -06:00
Andy Feller
47225bcf56
Merge pull request #10737 from cli/andyfeller/muted-text-part2-github-cli-833 
Ensure muted text is thematic and customizable
 2025-04-08 16:59:36 -04:00
Meredith Lancaster
261cea2075 update error message 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-04-08 14:41:18 -06:00
Andy Feller
93e51c583b
Update pkg/cmd/run/shared/presentation.go 2025-04-08 16:40:39 -04:00
Andy Feller
644dbe6275
Apply suggestions from code review 
Co-authored-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
 2025-04-08 15:56:23 -04:00
Andy Feller
5c12f5633e Test for explicit config disable of label colors 2025-04-08 15:27:36 -04:00
Andy Feller
c5206109ca Use truthy value for GH_COLOR_LABELS 2025-04-08 15:24:18 -04:00
Kynan Ware
fa03157beb doc(help): label GH_ACCESSIBLE_PROMPTER as preview 2025-04-08 13:04:04 -06:00
Kynan Ware
19387b8418 fix(prompter): rename GH_ACCESSIBLE_PROMPTER 2025-04-08 12:52:39 -06:00
Barak Amar
747f015f48 test pr number 0 2025-04-07 22:38:28 +03:00
Kynan Ware
5996f882fc doc(envs): speech synthesis prompter 2025-04-07 10:40:29 -06:00
Babak K. Shandiz
021537418e
Verify fallback to job run logs when step logs are missing 
Signed-off-by: Babak K. Shandiz <babakks@github.com>
 2025-04-07 13:54:30 +01:00
Babak K. Shandiz
02e8419124
Verify job run logs attached in attachRunLog test 
Signed-off-by: Babak K. Shandiz <babakks@github.com>
 2025-04-07 13:54:29 +01:00