Commit graph

1402 commits

Author SHA1 Message Date
Gowtham Munukutla
137053399e tweak tests and add extra validations 2021-06-17 10:17:26 +05:30
jlsestak
93118c65df
Merge pull request #52 from bchadwic/trunk
Update browse.go removed trailing newlines on errors
2021-06-16 20:53:06 -07:00
jlsestak
876b61af7b
Update browse.go 2021-06-16 20:50:08 -07:00
jlsestak
203d41c37b
Merge branch 'cli:trunk' into first-browse-pull 2021-06-16 20:37:34 -07:00
Gowtham Munukutla
3c8e163e8b resolve PR comments. Tests WIP 2021-06-16 12:50:05 +05:30
Gowtham Munukutla
7c8b6867f4 Merge branch 'trunk' of https://github.com/cli/cli into feature/repo-with-gitignore-license 2021-06-16 09:27:53 +05:30
jlsestak
0a801c1ed5
Merge pull request #51 from bchadwic/trunk
Fixed parseFileArgs, reformatted tests
2021-06-15 20:14:44 -07:00
Jessica Sestak
b64488fe5c Changed parsefileArg to return a string, reformatted testing, polished up browse.go 2021-06-15 20:10:48 -07:00
Sam
d299b74a37
Merge pull request #3841 from cli/factory-cleanup
Factory cleanup
2021-06-15 12:10:36 -04:00
Mislav Marohnić
543a17df7f
Merge pull request #3787 from cli/editor-tests
Allow explicitly empty body in issue/pr create
2021-06-15 16:16:59 +02:00
Sam Coe
edfac42384
Set up iostreams in factory default 2021-06-15 09:20:00 -04:00
Sam Coe
53fac59ef9
Cleanup factory/default and add tests 2021-06-15 09:19:16 -04:00
Sam
e380d68ed2
Merge pull request #3789 from cristiand391/increase-gh-pager-precedence
Increase `GH_PAGER` precedence
2021-06-15 09:18:57 -04:00
Benjamin Chadwick
3d97aaf7f4
Merge pull request #49 from bchadwic/trunk
Fixed pr issues
2021-06-14 22:37:21 -07:00
bchadwic
679d396c8d reformatted spacing and final touches 2021-06-14 22:31:29 -07:00
ravocean
21691c8d2e Reorganized tests 2021-06-14 22:16:58 -07:00
ravocean
79da79fb68 We added new tests to bring the coverage to 90%+ 2021-06-14 21:40:52 -07:00
Cristian Dominguez
d68a2038b6 add test case 2021-06-14 22:01:35 -03:00
jlsestak
707897ffb6
Deleted extra space 2021-06-14 08:29:22 -07:00
Sam Coe
8423de7f50
Add tests 2021-06-14 10:54:28 -04:00
Sam Coe
096f30a319
Add counterfeiter 2021-06-14 10:51:51 -04:00
Sam Coe
2729af50df
Cleanup SyncOptions 2021-06-14 10:51:51 -04:00
Sam Coe
8d61b96bde
Fix up error message 2021-06-14 10:51:51 -04:00
Sam Coe
8b5abc77ea
Extract git interactions into interface 2021-06-14 10:51:51 -04:00
Sam Coe
c6f89d3c17
Start tests 2021-06-14 10:51:50 -04:00
Sam Coe
86e16cc7c4
Add repo sync command 2021-06-14 10:51:50 -04:00
Mislav Marohnić
5984cf2a82
Merge pull request #3832 from cli/env-set-fix
Fix setting environment secrets
2021-06-14 16:17:24 +02:00
Cristian Dominguez
d8ce615252 Remove unused method from httpmock package 2021-06-14 09:39:14 -03:00
Mislav Marohnić
3a7ce3a440 Fix setting environment secrets
This uses the correct public key when setting environment secrets.
https://docs.github.com/en/rest/reference/actions#get-an-environment-public-key
2021-06-14 11:51:20 +02:00
Mislav Marohnić
1f4bd80c56 Fix test flaky due to race in showing/hiding cursor
https://github.com/cli/cli/pull/3787/checks?check_run_id=2793254411
2021-06-14 10:58:53 +02:00
bchadwic
9c7a788193 created more tests, and removed repoFlag 2021-06-13 21:05:50 -07:00
Jessica Sestak
7ea9d9164a Fixed TestNewCmdBrowse and added more tests 2021-06-13 20:16:19 -07:00
Jessica Sestak
edef757c6c Made more runBrowse tests 2021-06-12 22:36:03 -07:00
bchadwic
2b42ab92c3 refactored browse.go 2021-06-12 21:58:29 -07:00
camille folch
568f4e4ee0
Minor refactoring for readability in NewCmdFork's runE 2021-06-11 23:28:41 -03:00
camille folch
54b86c7093
repo fork: check that --org is not the empty string
As it is already being done for --remote-name, except in this case
the default is the empty string.
2021-06-11 23:28:41 -03:00
Mislav Marohnić
7999a457ad Separate out NewCmdBrowse tests from runBrowse tests
Co-authored-by: Benjamin Chadwick <benchadwick87@gmail.com>
Co-authored-by: Jessica Sestak <jlsestak@gmail.com>
2021-06-11 18:53:34 +02:00
Nate Smith
aecfc01e69
Merge pull request #3809 from cli/fork-test-cleanup
fork tests cleanup
2021-06-11 11:31:33 -05:00
Mislav Marohnić
4debbb17cd Further separate out test cases 2021-06-11 14:32:08 +02:00
bchadwic
88ec5ad3b2 Fixing issues in the pr 2021-06-10 21:14:10 -07:00
Nate Smith
b0998772ae more cleanup 2021-06-10 21:46:02 +00:00
Nate Smith
f31a31e2ed stop stubbing out a Since function 2021-06-10 21:46:02 +00:00
vilmibm
4a7ec7f4f6 cleaning up fork tests 2021-06-10 21:45:54 +00:00
vilmibm
14de70a011 add defaultRemoteName 2021-06-10 21:44:49 +00:00
Mislav Marohnić
e1b5f78df3 💅 grammar in comment 2021-06-10 14:09:43 +02:00
Jessica Sestak
e5b81fb6a5 Started working on testing for parseFileArgs 2021-06-08 22:09:11 -07:00
Jessica Sestak
1657cf46c1 Fixed parsefileargs to throw errors with incorrect line numbers 2021-06-08 21:23:50 -07:00
Jessica Sestak
a96612c5e9 Fixed --repo to open with Args 2021-06-08 20:54:56 -07:00
bchadwic
98a5541d15 Started to fix the flags and the restrictions using them 2021-06-08 20:35:38 -07:00
bchadwic
95afca882b Finished refactoring now 2021-06-08 16:35:53 -07:00