Commit graph

4048 commits

Author SHA1 Message Date
bchadwic
2b42ab92c3 refactored browse.go 2021-06-12 21:58:29 -07:00
Benjamin Chadwick
5f64243eb6
Merge pull request #44 from bchadwic/first-browse-pull
Restructured test file and discussed the structure of browse.go
2021-06-12 21:02:10 -07:00
camille folch
568f4e4ee0
Minor refactoring for readability in NewCmdFork's runE 2021-06-11 23:28:41 -03:00
camille folch
54b86c7093
repo fork: check that --org is not the empty string
As it is already being done for --remote-name, except in this case
the default is the empty string.
2021-06-11 23:28:41 -03:00
Mislav Marohnić
7999a457ad Separate out NewCmdBrowse tests from runBrowse tests
Co-authored-by: Benjamin Chadwick <benchadwick87@gmail.com>
Co-authored-by: Jessica Sestak <jlsestak@gmail.com>
2021-06-11 18:53:34 +02:00
Nate Smith
aecfc01e69
Merge pull request #3809 from cli/fork-test-cleanup
fork tests cleanup
2021-06-11 11:31:33 -05:00
Benjamin Chadwick
14a1f63f78
Merge pull request #43 from bchadwic/trunk
Fixing issues in the pr
2021-06-11 08:04:09 -07:00
Mislav Marohnić
af90f72493
Merge pull request #3803 from cli/http-accept-header
Update "Accept" header for github.com requests
2021-06-11 14:38:52 +02:00
Mislav Marohnić
4debbb17cd Further separate out test cases 2021-06-11 14:32:08 +02:00
Mislav Marohnić
7dbaaf2eb7
Merge pull request #3804 from cli/pr-status-checks
Fix showing Checks information in `pr status`
2021-06-11 14:18:50 +02:00
bchadwic
88ec5ad3b2 Fixing issues in the pr 2021-06-10 21:14:10 -07:00
Nate Smith
b0998772ae more cleanup 2021-06-10 21:46:02 +00:00
Nate Smith
f31a31e2ed stop stubbing out a Since function 2021-06-10 21:46:02 +00:00
vilmibm
4a7ec7f4f6 cleaning up fork tests 2021-06-10 21:45:54 +00:00
vilmibm
14de70a011 add defaultRemoteName 2021-06-10 21:44:49 +00:00
Mislav Marohnić
a4d1ce7709 Fix fetching information about the PR potentially being behind base branch 2021-06-10 15:51:27 +02:00
Mislav Marohnić
885e94786a Shorten GraphQL query for pr status --json 2021-06-10 15:37:58 +02:00
Mislav Marohnić
e1b5f78df3 💅 grammar in comment 2021-06-10 14:09:43 +02:00
Benjamin Chadwick
e1a6311083
Merge pull request #42 from bchadwic/trunk
Refactored the output, and created more test functions / test cases
2021-06-08 22:55:15 -07:00
jlsestak
170f7fa305
Merge pull request #41 from jlsestak/trunk
Made test for parse files args, fixed parse file args, fixed repo flag
2021-06-08 22:10:57 -07:00
Jessica Sestak
e5b81fb6a5 Started working on testing for parseFileArgs 2021-06-08 22:09:11 -07:00
Jessica Sestak
1657cf46c1 Fixed parsefileargs to throw errors with incorrect line numbers 2021-06-08 21:23:50 -07:00
Jessica Sestak
a96612c5e9 Fixed --repo to open with Args 2021-06-08 20:54:56 -07:00
bchadwic
98a5541d15 Started to fix the flags and the restrictions using them 2021-06-08 20:35:38 -07:00
bchadwic
95afca882b Finished refactoring now 2021-06-08 16:35:53 -07:00
Benjamin Chadwick
ab468a99e2
Merge pull request #40 from bchadwic/trunk
Refactored output, the tests, and the use of opts in runBrowse
2021-06-08 15:39:39 -07:00
bchadwic
506bd4b2de working on refactoring the output, the tests and how opts is structured 2021-06-08 15:36:11 -07:00
vilmibm
395355d075 make prompt.Confirm stubbable 2021-06-08 15:49:37 -05:00
Benjamin Chadwick
5b8a849a9c
Merge pull request #39 from bchadwic/first-browse-pull
keeping working branch up to speed
2021-06-08 13:21:27 -07:00
Benjamin Chadwick
698ca014c7
Merge pull request #38 from bchadwic/trunk
Redefined browse output, and added in more test cases
2021-06-08 13:12:48 -07:00
Benjamin Chadwick
b059054102
Update settings.json 2021-06-08 13:12:11 -07:00
Benjamin Chadwick
5efe9f8df3
Update settings.json 2021-06-08 13:10:33 -07:00
Benjamin Chadwick
9fe986a480
Update pkg/cmd/browse/browse.go
Co-authored-by: Mislav Marohnić <hi@mislav.net>
2021-06-08 12:48:17 -07:00
Benjamin Chadwick
891f4af69c
Update pkg/cmd/browse/browse.go
Co-authored-by: Mislav Marohnić <hi@mislav.net>
2021-06-08 12:47:56 -07:00
Benjamin Chadwick
94002bf0cc
Update pkg/cmd/browse/browse.go
Co-authored-by: Mislav Marohnić <hi@mislav.net>
2021-06-08 12:47:44 -07:00
Mislav Marohnić
f5cd33b4bf Fix showing Checks in pr status
This was a regression in how `statusCheckRollup` is queried and stored.
As a result, `gh pr status` did not include rendered information about
checks related to each pull request. This switches the query builder to
`PullRequestGraphQL()` to eliminate the outdated query.
2021-06-08 20:22:33 +02:00
Mislav Marohnić
3a55c26000 Update "Accept" header for github.com requests
The `antiope-preview` has graduated in github.com and no longer needs
activating. However, we still need it for GHES requests.
2021-06-08 19:25:40 +02:00
Mislav Marohnić
8a221bb766 Add tests for our default HTTP client 2021-06-08 19:21:48 +02:00
Husrav Homidov
0ebcbdd448
Merge pull request #37 from ravocean/trunk
A small change in code
2021-06-07 22:01:38 -07:00
ravocean
898d585e6a A small change in code 2021-06-07 22:00:05 -07:00
bchadwic
569d2fd58a Got tests objects to fully work! Currently working on making more test cases 2021-06-07 21:47:08 -07:00
Benjamin Chadwick
698c7d61b5
Merge pull request #36 from bchadwic/trunk
Updating pr, Fixed output comparison
2021-06-07 13:02:15 -07:00
Husrav Homidov
3dc66b9539
Merge pull request #35 from ravocean/trunk
Continued to work on the output of test file
2021-06-07 12:58:21 -07:00
ravocean
449858158d Continued to work on the output of test file 2021-06-07 12:57:36 -07:00
Benjamin Chadwick
f9a5818ddc
Merge pull request #34 from bchadwic/trunk
Added in a rough test file
2021-06-07 11:59:53 -07:00
jlsestak
a3a010b603
Merge pull request #33 from jlsestak/trunk
Worked on browse_test.go, still not getting appropriate errors
2021-06-07 11:06:24 -07:00
Jessica Sestak
f792704003 Worked on browse_test.go, still not getting errors 2021-06-07 11:04:29 -07:00
bchadwic
6ed9900084 working on the test file for the browse.go 2021-06-06 01:09:43 -07:00
Thanh D Tran
dd4ebc9b8f
Merge pull request #32 from ttran112/trunk
working on test file
2021-06-05 23:34:44 -07:00
ttran112
e425e897a6 create new test file for first browse branch 2021-06-05 23:31:19 -07:00