Corey Johnson
be927b34ae
Update command/pr_test.go
...
Co-authored-by: Billy Griffin <5091167+billygriffin@users.noreply.github.com>
2020-05-18 14:39:52 -07:00
Corey Johnson
6eab3751d0
Update command/pr.go
...
Co-authored-by: Billy Griffin <5091167+billygriffin@users.noreply.github.com>
2020-05-18 14:39:43 -07:00
Corey Johnson
9721f75b2b
Update command/pr.go
...
Co-authored-by: Billy Griffin <5091167+billygriffin@users.noreply.github.com>
2020-05-18 14:39:29 -07:00
vilmibm
b94860bae7
add command file with pr resolution
2020-05-18 15:43:27 -05:00
Corey Johnson
b42f5527fd
Remove hot dog
2020-05-18 13:27:23 -07:00
vilmibm
14e8498b90
fix path
2020-05-18 15:14:10 -05:00
Corey Johnson
78bc7260e0
Add closed test
2020-05-18 13:08:57 -07:00
vilmibm
d2bdd53dd2
depend on bin/gh
2020-05-18 15:08:31 -05:00
vilmibm
d800e3f0b6
rely on environment
2020-05-18 15:07:28 -05:00
Corey Johnson
0b0070e725
Add "already marked" test
2020-05-18 13:03:43 -07:00
Corey Johnson
922b6e06e0
Can be marked ready for review
2020-05-18 12:42:16 -07:00
Nate Smith
b904ed6556
Merge pull request #955 from vilmibm/skipfix
...
reenable skipping body prompt for pr/issue
2020-05-18 14:23:24 -05:00
vilmibm
da95cbd1bf
use gh if available when cloning site
2020-05-18 14:05:50 -05:00
vilmibm
296062b869
configure author on site commits
2020-05-18 14:01:35 -05:00
Corey Johnson
fad9f24f39
Make reopen work
2020-05-18 11:11:13 -07:00
Corey Johnson
350b4c85c0
Add failing test
2020-05-18 11:11:02 -07:00
vilmibm
01f272dead
give our pr template a name
2020-05-18 11:44:21 -05:00
vilmibm
228d01a037
reenable skipping body prompt for pr/issue
2020-05-18 10:23:20 -05:00
Mislav Marohnić
4d11732a47
Merge pull request #943 from cli/reauth-bug
...
pass apiClient to determineBaseRepo
2020-05-18 13:16:07 +02:00
Kevin Bluer
d440a95aed
Improved error message when "owner/repo" format not provided ( #919 )
...
Fixes #882
2020-05-18 11:13:48 +02:00
AliabbasMerchant
6effcd4261
Allow choosing a blank issue/pr template
2020-05-18 00:37:28 +05:30
vilmibm
780875d645
fix tests
2020-05-15 16:47:11 -05:00
vilmibm
96ba1eacef
undo initial thing
2020-05-15 16:44:51 -05:00
vilmibm
bf05975ceb
Revert "small repo fix"
...
This reverts commit 08e9cdaee1
2020-05-15 16:40:47 -05:00
vilmibm
7decae71fc
untested first pass on ensureScopes
2020-05-15 16:40:13 -05:00
vilmibm
c8c807b954
pass apiClient to determineBaseRepo
...
Our code had an unspoken assumption that only one apiClient is created
during the course of a command. Violating this assumption is fine in
almost all cases, but not when we need to do a re-auth to add a new
oauth scope to a user's token.
There is likely a more elegant solution to the problem but until then
this changes determineBaseRepo to use an existing apiClient.
2020-05-15 15:29:33 -05:00
Corey Johnson
ea164a8d48
Fix test
2020-05-15 10:52:26 -07:00
Corey Johnson
90664792b6
Fix message
2020-05-15 10:42:58 -07:00
Corey Johnson
c645fd5ae5
Better errors around branch deletion
2020-05-15 10:33:54 -07:00
Corey Johnson
848dd44443
Delete branch of PR, not the current branch
2020-05-15 08:51:37 -07:00
Corey Johnson
feca9f6eaf
Add convertRepoInterfaceToRepository
2020-05-15 08:51:10 -07:00
vilmibm
08e9cdaee1
small repo fix
2020-05-15 10:25:40 -05:00
Corey Johnson
587dd4d797
a better name
2020-05-15 08:09:27 -07:00
Corey Johnson
d41778493b
Only look for enabled flags
2020-05-15 08:09:08 -07:00
Corey Johnson
a107558583
Default is now false
2020-05-15 08:05:12 -07:00
Corey Johnson
4d539f937e
Return err
2020-05-15 08:05:05 -07:00
vilmibm
3b62d79e81
notes
2020-05-15 09:52:06 -05:00
Nate Smith
c115d32b74
Merge pull request #923 from cli/install-source
...
Change source installation docs to avoid suggesting to change PATH
2020-05-14 13:36:05 -05:00
Mislav Marohnić
e3676c3a95
Change source installation docs to avoid suggesting to change PATH
2020-05-14 18:32:57 +02:00
vilmibm
a62f2987c0
stray debug
2020-05-13 14:59:14 -05:00
vilmibm
cc1ffb0aea
pass apiClient to determineBaseRepo
...
Our code had an unspoken assumption that only one apiClient is created
during the course of a command. Violating this assumption is fine in
almost all cases, but not when we need to do a re-auth to add a new
oauth scope to a user's token.
There is likely a more elegant solution to the problem but until then
this changes determineBaseRepo to use an existing apiClient.
2020-05-13 14:55:49 -05:00
vilmibm
3a7f56456e
tweak reauth code and request a new scope
2020-05-13 14:24:29 -05:00
Mislav Marohnić
e28e6097ce
Merge pull request #891 from victorhsn/master
...
add description default private for repo create
2020-05-13 21:03:59 +02:00
vilmibm
ed1a3a60fd
Merge remote-tracking branch 'origin/master' into wingkwong/master
2020-05-13 13:43:09 -05:00
Mislav Marohnić
9acaca90e2
Merge pull request #908 from cli/issue-metadata-resolve-ids
...
Faster resolve assignees, reviewers, labels on create via flags
2020-05-13 17:28:55 +02:00
Mislav Marohnić
57e60ab8a1
Merge remote-tracking branch 'origin/master' into issue-metadata-resolve-ids
2020-05-13 17:20:37 +02:00
Mislav Marohnić
1ff37be361
Fix assigning multiple user reviewers
...
This was due to a typo. Fixes #913
2020-05-13 17:16:12 +02:00
Nate Smith
3552bca596
Merge pull request #912 from cli/pr-create-codeowners-fix
...
Preserve CODEOWNERS reviewers in `pr create`
2020-05-13 10:05:10 -05:00
Mislav Marohnić
ab4c6e2ad0
Remove obsolete hack to generate fish completions
2020-05-13 12:51:55 +02:00
Mislav Marohnić
e39894d4a0
Update to Cobra 1.0.0
2020-05-13 12:49:52 +02:00
