Commit graph

715 commits

Author SHA1 Message Date
Mislav Marohnić
1128439cd1 issue/pr create: hide "Add metadata" if viewer does not have triage permission 2020-05-08 18:37:08 +02:00
Mislav Marohnić
d7e6d21766 Order projects, teams, and labels by name 2020-05-08 18:22:14 +02:00
Mislav Marohnić
1f774b4158 Add spinner while loading metadata 2020-05-08 18:11:57 +02:00
Mislav Marohnić
34fc3457d6 Skip interactive mode in pr create if title & body were passed
This matches `issue create` behavior 4b32e3f215
2020-05-08 18:06:05 +02:00
Mislav Marohnić
cedf94f450 Name some values for readability 2020-05-08 17:58:33 +02:00
Mislav Marohnić
df144926b8 Rename data variable to something more descriptive 2020-05-08 17:56:47 +02:00
Mislav Marohnić
716036161b Rename titleBody (now a misnomer) to something more descriptive 2020-05-08 17:55:46 +02:00
Mislav Marohnić
72e99e9530 Merge branch 'issue-pr-create-metadata' into issue-pr-create-metadata-wizard 2020-05-08 17:46:47 +02:00
Mislav Marohnić
d0f168f4c3 Merge remote-tracking branch 'origin/master' into issue-pr-create-metadata 2020-05-08 17:46:17 +02:00
Mislav Marohnić
3000847bb2
Merge pull request #874 from cli/httpmock
Parallelism-safe mechanism for stubbing HTTP responses
2020-05-08 17:34:57 +02:00
vilmibm
6538cca693 switch to using body flag. small TODOs 2020-05-08 10:07:20 -05:00
vilmibm
46522a2add fix current branch tests 2020-05-07 14:51:17 -05:00
vilmibm
8a5290d2b4 clarify error msg 2020-05-07 14:51:08 -05:00
vilmibm
5dbec25f44 handle pr for branch case 2020-05-07 14:27:33 -05:00
vilmibm
d81e622700 lightest weight reviewing
this commit add very basic non-interactive PR reviewing. You can either
review the "current" or a passed PR (number or URL) as approved, changes
requested, or commented via CLI flags.
2020-05-07 13:30:34 -05:00
Mislav Marohnić
a7242f4ca3
Merge pull request #863 from cli/close-cmd-syntax
Tweak syntax in `issue/pr close` docs
2020-05-07 16:55:13 +02:00
Mislav Marohnić
5913a72532
Merge pull request #819 from rista404/interactive-when-defaults-807
Disable interactive mode for `issue create` if all flags are passed
2020-05-07 16:29:04 +02:00
Mislav Marohnić
0a4d4ee007 Replace FakeHTTP with httpmock which is now compatible 2020-05-07 15:19:14 +02:00
Mislav Marohnić
256d31950a Migrate a single test over to httpmock to demonstrate its use 2020-05-06 22:06:37 +02:00
Corey Johnson
8c9fdc768c Merge remote-tracking branch 'origin' into a-better-runcommand 2020-05-05 09:30:32 -07:00
Corey Johnson
4ef73a723d Update all calls to RunCommand 2020-05-05 09:20:01 -07:00
Nikola Ristic
1f9b7c0fe0
Disable interactive only if both flags are passed
Co-authored-by: Mislav Marohnić <mislav@github.com>
2020-05-05 16:34:31 +02:00
Mislav Marohnić
1834d8cfd5 Tweak syntax in issue/pr close docs
This makes it consistent with other subcommands under `issue/pr`.
2020-05-05 13:32:42 +02:00
Nate Smith
1a1fc64fe4
Merge pull request #842 from foad/df-805-hide-closed-default
Hide closed/merged PRs from default branch
2020-05-04 20:17:53 -05:00
Daniel Foad
e7e3a4f9b1
pr comments 2020-05-04 23:47:47 +01:00
Corey Johnson
fef11b3489 Merged prs return error 2020-05-04 10:44:20 -07:00
Corey Johnson
3b8f4794b4 Update test 2020-05-04 10:31:31 -07:00
Corey Johnson
2f075fca73 Return an error if the pr was already merged 2020-05-04 10:25:38 -07:00
Corey Johnson
5cc60c669e Take in a pointer 2020-05-04 10:19:54 -07:00
Corey Johnson
1e88226b2b Add space 2020-05-04 10:16:30 -07:00
Corey Johnson
083693bc05 Update usage string 2020-05-04 10:15:47 -07:00
Corey Johnson
f7be93b135 use less words 2020-05-04 10:11:24 -07:00
Corey Johnson
1ee31db033 Add "merged" message 2020-05-04 10:10:03 -07:00
Mislav Marohnić
0bf4f16fd5 Merge branch 'issue-pr-create-metadata' into issue-pr-create-metadata-wizard 2020-05-04 17:10:06 +02:00
Mislav Marohnić
b59407dd7d Merge remote-tracking branch 'origin/master' into issue-pr-create-metadata 2020-05-04 17:09:41 +02:00
Corey Johnson
4020084f02 Fix test 2020-05-01 14:54:38 -07:00
Corey Johnson
fad697cbaf Names 2020-05-01 14:18:01 -07:00
Corey Johnson
846425fe5e simplified boolean comparison 2020-05-01 14:16:49 -07:00
Corey Johnson
922352753a Add merged exit 2020-05-01 14:08:30 -07:00
Corey Johnson
63b20baa1b Add merged test 2020-05-01 13:58:52 -07:00
Corey Johnson
b8ff489bb5 Add already open test 2020-05-01 12:07:30 -07:00
Corey Johnson
bc623a7a23 Make it green 2020-05-01 12:07:23 -07:00
Corey Johnson
0bb1d2018a Add code to reopen 2020-05-01 12:00:13 -07:00
Corey Johnson
38f9e819c5 Add test for reopen 2020-05-01 12:00:02 -07:00
Corey Johnson
3a7bde2cce RunCommand doesn't take the command to be run 2020-05-01 10:09:30 -07:00
Corey Johnson
210c47572c Move RunCommand to testing file 2020-04-30 12:14:40 -07:00
Corey Johnson
e93b18a9af Add already open test 2020-04-30 11:41:48 -07:00
Corey Johnson
4bf778b136 require one arg 2020-04-30 11:41:39 -07:00
Corey Johnson
af6eaa8ca2 Hot dog 2020-04-30 11:41:32 -07:00
Corey Johnson
19f6c69854 Actually make it work 2020-04-30 11:27:11 -07:00