Commit graph

4761 commits

Author SHA1 Message Date
Mislav Marohnić
2819deb15b Avoid applying human-oriented PR automation to PRs from bots 2021-10-11 11:33:44 +02:00
Mislav Marohnić
dabaa5ad7d CodeQL-Dependabot compatibility
Configure the CodeQL workflow to avoid running for pushes on all pull
requests because that causes problems with Dependabot PRs.

https://github.com/cli/cli/pull/4475/checks?check_run_id=3857074760
2021-10-11 11:27:54 +02:00
Mislav Marohnić
fd16453eb6
Merge pull request #4475 from cli/dependabot/go_modules/github.com/google/go-cmp-0.5.6
Bump github.com/google/go-cmp from 0.5.5 to 0.5.6
2021-10-11 11:21:36 +02:00
dependabot[bot]
e472f46083
Bump github.com/muesli/termenv from 0.8.1 to 0.9.0
Bumps [github.com/muesli/termenv](https://github.com/muesli/termenv) from 0.8.1 to 0.9.0.
- [Release notes](https://github.com/muesli/termenv/releases)
- [Commits](https://github.com/muesli/termenv/compare/v0.8.1...v0.9.0)

---
updated-dependencies:
- dependency-name: github.com/muesli/termenv
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-10-11 08:54:27 +00:00
dependabot[bot]
b3947a7a94
Bump github.com/briandowns/spinner from 1.11.1 to 1.16.0
Bumps [github.com/briandowns/spinner](https://github.com/briandowns/spinner) from 1.11.1 to 1.16.0.
- [Release notes](https://github.com/briandowns/spinner/releases)
- [Commits](https://github.com/briandowns/spinner/compare/v1.11.1...v1.16.0)

---
updated-dependencies:
- dependency-name: github.com/briandowns/spinner
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-10-11 08:54:15 +00:00
dependabot[bot]
98fa94cc6b
Bump github.com/google/go-cmp from 0.5.5 to 0.5.6
Bumps [github.com/google/go-cmp](https://github.com/google/go-cmp) from 0.5.5 to 0.5.6.
- [Release notes](https://github.com/google/go-cmp/releases)
- [Commits](https://github.com/google/go-cmp/compare/v0.5.5...v0.5.6)

---
updated-dependencies:
- dependency-name: github.com/google/go-cmp
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-10-11 08:53:52 +00:00
Mislav Marohnić
31cca1145f
Merge pull request #4473 from neil465/neil/dependabot
Enable dependabot to get security updates and if needed version updat…
2021-10-11 10:48:22 +02:00
flying-cow
706dede7ac Enable dependabot to get security updates and if needed version updates on dependencies
https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically

Having knowledge about vulnerabilities of the dependencies helps the project owners decide on their dependencies security posture to make decisions.

If the project decides to get updates only on security updates and not on any version updates then setting these options would not open any PR 's open-pull-requests-limit: 0
2021-10-10 19:41:30 -05:00
Mislav Marohnić
0c5c2378ac
Merge pull request #4460 from m4ver1k/feat/2720
#2720 | Add patch flag to pull-request diff command
2021-10-08 13:58:56 +02:00
Mislav Marohnić
e4c8aa3b2b Add tests for pr diff --patch 2021-10-08 13:53:19 +02:00
Luciano Zago
79832c1b04
Add instructions to gh installation via spack (#4412) 2021-10-08 09:14:49 +00:00
Jose Garcia
1aefc74378 Add more time between events 2021-10-07 16:48:09 -04:00
Jose Garcia
1ff58a3de7 Update docs, remove needless condition check 2021-10-07 16:39:43 -04:00
Jose Garcia
97cbdca84a Fix additional race in tests 2021-10-07 15:45:55 -04:00
Jose Garcia
8a559ee12a Fix unrelated tests 2021-10-07 15:38:16 -04:00
Jose Garcia
2406f3f09a Fix races and remove unreachable code 2021-10-07 15:32:07 -04:00
Jose Garcia
7ba2fb4c0e Make fileLogger more versatile 2021-10-07 15:19:14 -04:00
Jose Garcia
8f5d6bb672 Tests for most of the new behavior
- Made the heartbeat interval configurable for easier testing
- Moved span to the top of connect to capture the full execution
2021-10-07 15:14:42 -04:00
Adarsh K Kumar
e0897fd8e8 #2720 | Add patch flag to pull-request diff command 2021-10-07 23:09:21 +05:30
Jose Garcia
9c8351ecd8 Merge branch 'trunk' of github.com:cli/cli into jg/liveshare-keepalive 2021-10-07 11:10:45 -04:00
Jose Garcia
cff6cf9acf
Merge pull request #4457 from cli/jg/fix-create-regression
codespace create: fix regression returning nil codespace
2021-10-07 11:09:26 -04:00
Jose Garcia
400749d560 Fix regression returning nil codespace 2021-10-07 11:01:24 -04:00
Jose Garcia
55f4fcf05c Live Share session activity detection
- Session now accepts two new options: ClientName and Logger
- Port forwarder now supports a keepAlive parameter which when true,
  instructs the PF to call the session's keepAlive method.
- Port forwarder uses a new traffic monitor to detect I/O traffic and
  notify the session when applicable.
- The SSH command introduces a new debug flag which enables the command
  to log to a new temporary file. The file path is printed to the user.
2021-10-07 10:42:06 -04:00
Sam
becc45a1df
Merge pull request #4437 from cli/fix-extension-io-bug
Set io when initializing extension manager
2021-10-06 12:54:25 -07:00
Jose Garcia
cd1eec5e38
Merge pull request #4448 from cli/jg/codeowners
Add codeowners
2021-10-06 13:55:56 -04:00
Jose Garcia
6f978dd8a4
Merge pull request #4440 from cli/jg/choose-codespace-prompt
codespace: choose codespace prompt improvements
2021-10-06 13:55:45 -04:00
Jose Garcia
b44474c32b Revert rename for ports cmd 2021-10-06 13:47:20 -04:00
Jose Garcia
bdc9ad30e7 Revert other rename changes 2021-10-06 13:46:04 -04:00
Jose Garcia
811d841fae Merge branch 'trunk' of github.com:cli/cli into jg/choose-codespace-prompt 2021-10-06 13:40:01 -04:00
Gabriel Ramírez
3d0d95ce2b
Merge pull request #4439 from geramirez/geramirez/codespaces-pagination
Adding pagination to list codespaces
2021-10-06 12:38:50 -05:00
Jose Garcia
771ac714ac Update docs 2021-10-06 11:47:18 -04:00
Jose Garcia
a509c2d884 Remove unused guid 2021-10-06 11:45:43 -04:00
Jose Garcia
3a28643630 Keep codespace struct in API for now
- Use a private codespace structure in the cmd pkg to encapsulate common
  behavior
2021-10-06 11:44:26 -04:00
Gabriel Ramírez
20ae9d305d
Fetch 100 codespaces by default 2021-10-06 14:53:55 +00:00
Jose Garcia
073200a275 Add codeowners 2021-10-06 10:19:17 -04:00
Gabriel Ramírez
e29a0ac7c4
Merge branch 'geramirez/codespaces-pagination' of https://github.com/geramirez/cli into geramirez/codespaces-pagination 2021-10-06 14:18:57 +00:00
Gabriel Ramírez
34f9c0a67c
Updating docs and interation exit condition to not check the final page 2021-10-06 14:18:44 +00:00
Gabriel Ramírez
237fdd40c8
Update internal/codespaces/api/api.go
Co-authored-by: Jose Garcia <josebalius@github.com>
2021-10-06 09:03:49 -05:00
Jose Garcia
017632d63d Merge branch 'trunk' of github.com:cli/cli into jg/choose-codespace-prompt 2021-10-06 09:57:39 -04:00
Jose Garcia
52e16dfe09
Merge pull request #4446 from cli/jg/get-codespace-api
codespace: switch `API.GetCodespace` to new API endpoint
2021-10-06 09:41:01 -04:00
Jose Garcia
b2ff4c321a Remove unused structs 2021-10-06 09:25:39 -04:00
Jose Garcia
7c497f283b Update test signature 2021-10-06 09:15:07 -04:00
Jose Garcia
8bb55359b1 Update mock API 2021-10-06 09:10:00 -04:00
Jose Garcia
8135fdbd99 Switch GetCodespace to new API endpoint
- Drop GetCodespaceToken as it is no longer necessary
- Introduces new behavior with the API to optionally include connection
  details in the GET request. Ommitting to do so results in a faster
  response
2021-10-06 08:50:42 -04:00
Gabriel Ramírez
aa49a3a557
Adding a second condition just in case 2021-10-05 21:43:28 +00:00
Gabriel Ramírez
61b0fe36b2
Adding additional tests for mid-flight deletions and additions 2021-10-05 21:31:47 +00:00
Gabriel Ramírez
02145cc4fd
Updated PR with suggestions
- created a new method  to avoid defer pileup issue
- removed extra api call at the end of the sequence
2021-10-05 21:15:24 +00:00
Gabriel Ramírez
c6dc50983d
Update internal/codespaces/api/api.go
Co-authored-by: Jose Garcia <josebalius@github.com>
2021-10-05 15:33:22 -05:00
Gabriel Ramírez
4314f734e3
Update internal/codespaces/api/api.go
Co-authored-by: Jose Garcia <josebalius@github.com>
2021-10-05 15:33:16 -05:00
Gabriel Ramírez
e793a5961d
Add strconv 2021-10-05 19:00:21 +00:00