Commit graph

4761 commits

Author SHA1 Message Date
Raffaele Di Fazio
35e0f95243 Update cmd/ghcs/delete.go
Co-authored-by: CamiloGarciaLaRotta <camilogarcialarotta@github.com>
2021-09-16 18:42:41 +02:00
Sam Coe
0305788536
Typo 2021-09-16 09:02:10 -07:00
Raffaele Di Fazio
5cd90fea88 fix linter
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
2021-09-16 16:45:07 +02:00
Raffaele Di Fazio
68f4cad1af implement delete all with thresold
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
2021-09-16 16:42:53 +02:00
Jose Garcia
8a0f8b6d1c parse ssh args and command 2021-09-16 10:32:27 -04:00
Christian Gregg
cc1b86461e Confirm deletion of codespaces with unpushed/uncommited changes (#129)
Adds a confirmation dialog on `ghcs delete` if the codespace in question
has unpushed or uncommited changes.

This confirmation can be skipped using the `--force` or `-f` flag.

Closes: #84
Closes: #10
2021-09-16 13:47:15 +01:00
Mislav Marohnić
f9e49f4aec Do not swallow prompt error during repo create 2021-09-16 12:25:44 +02:00
Mislav Marohnić
5617db6614 Merge pull request #151 from github/ruleguard
Wrap errors using "%w" instead of "%v"
2021-09-16 12:21:36 +02:00
Mislav Marohnić
dbb4e0c177 Merge remote-tracking branch 'origin' into ruleguard 2021-09-16 11:46:50 +02:00
vilmibm
eeca998640 binary extension support in gh extension install 2021-09-15 18:46:17 -05:00
Jose Garcia
514448dde8 Merge branch 'main' of github.com:github/ghcs into jg/ssh-cmd-flags 2021-09-15 15:45:53 -04:00
Jose Garcia
10ad85486f Merge pull request #154 from github/jg/fix-ctx-error
ghcs create/ssh: fix ctx cancellation errors & fix todo for X11 forwarding
2021-09-15 15:45:35 -04:00
Jose Garcia
45a9715e9f Merge pull request #158 from github/jg/go-liveshare-0.16.0
upgrade to go-liveshare 0.16.0
2021-09-15 15:40:58 -04:00
Jose Garcia
b2234969e4 update logs 2021-09-15 15:40:07 -04:00
Alan Donovan
eafadd3757 Merge pull request #156 from github/api-internal
move api to internal/api
2021-09-15 15:38:11 -04:00
Jose Garcia
c5bd8c4127 initial spike to accept args 2021-09-15 15:37:37 -04:00
Jose Garcia
26d3199082 add back codespaces.Shell 2021-09-15 15:18:54 -04:00
Jose Garcia
ecd0c70567 upgrade to go-liveshare 0.16.0 2021-09-15 15:15:28 -04:00
Jose Garcia
0f72e3d886 defer stopPolling and docs 2021-09-15 14:29:16 -04:00
Alan Donovan
06719866c9 move api to internal/ 2021-09-15 13:13:10 -04:00
Jose Garcia
547c629220 fix ctx cancellation errors & fix todo for X11 forwarding 2021-09-15 10:38:19 -04:00
Jose Garcia
22433a57db Merge pull request #18 from github/jg/ssh-server-docs
ssh server: docs
2021-09-15 09:52:31 -04:00
Jose Garcia
20e618fd02 pr feedback 2021-09-15 13:49:03 +00:00
Jose Garcia
8abff2af97 move StartSSHServer to Session 2021-09-15 13:14:58 +00:00
Alan Donovan
2de51a8ec8 Merge pull request #17 from github/rm-terminal
Remove Terminal, no longer needed by ghcs
2021-09-15 09:06:49 -04:00
Mislav Marohnić
fb5a35568c Ensure original errors are wrapped with "%w" instead of "%v" 2021-09-15 13:58:41 +02:00
Jose Garcia
497b45e4e2 ssh server docs 2021-09-14 23:57:40 +00:00
Andrew Hsu
e13398f6b4
fix browse of markdown files with line ranges (#4310)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2021-09-14 16:08:19 +02:00
Jose Garcia
3abde5f0c5 Merge pull request #148 from github/jg/remove-deprecation-msg
remove all deprecation messages and deprecated functionality
2021-09-13 14:44:40 -04:00
Mislav Marohnić
d7f7a98d81
Merge pull request #4320 from cli/site-ssh-key
Publish docs site using a deploy key instead of PAT
2021-09-13 19:43:39 +02:00
Mislav Marohnić
6f3b1eb080
Merge pull request #3967 from despreston/des/3839-warn-limit
show warning when limit exceeds search api max
2021-09-13 19:30:16 +02:00
Sam Coe
a8492bb0ea
Allow user input for git fetch in repo sync 2021-09-13 10:14:20 -07:00
Jose Garcia
f5adc9e3a7 remove all deprecation messages and deprecated functionality 2021-09-13 10:58:00 -04:00
Mislav Marohnić
2f45173370 Publish docs site using a deploy key instead of PAT
I'd like to decommission SITE_GITHUB_TOKEN as it's a PAT that has write
access to all my `github/*` repositories. Instead, I've created a deploy
key that only has access to `github/cli.github.com`.

    ssh-keygen -t ed25519 -C "gh docs push" -N "" -f ~/.ssh/gh-docs-publish
    gh repo -R github/cli.github.com deploy-key add ~/.ssh/gh-docs-publish.pub

    # testing:
    GIT_SSH_COMMAND='ssh -i $HOME/.ssh/gh-docs-publish' git push ...
2021-09-13 16:30:40 +02:00
Alan Donovan
a5b985523c Merge pull request #147 from github/tty-windows
Don't assume stdin/stdout fds are 0/1 on windows
2021-09-13 09:30:39 -04:00
Alan Donovan
c4be0a0e28 this time without compile errors 2021-09-13 09:29:46 -04:00
Issy Long
74a4afcd77 Merge pull request #139 from github/fix-version-string
goreleaser: Fix version string replacement
2021-09-13 10:32:19 +01:00
Siarhei Fedartsou
1926971a76 Remove non-relevant test 2021-09-12 21:04:03 +03:00
Siarhei Fedartsou
f3053c3628 fix tests 2021-09-12 20:58:13 +03:00
Siarhei Fedartsou
373d1efb58 format code 2021-09-12 20:50:21 +03:00
Siarhei Fedartsou
11466fda12 Add --draft and --non-draft filters to gh pr list 2021-09-12 20:48:23 +03:00
Alan Donovan
1526ab5bff fix URL 2021-09-10 18:08:48 -04:00
Alan Donovan
af301bfff1 stdin/stdout fds are not 0/1 on windows 2021-09-10 17:36:20 -04:00
Jose Garcia
3ca3dd05a1 Merge pull request #143 from github/jg/ssh-flags
ghcs ssh: make flag description consistent
2021-09-10 16:04:09 -04:00
Jose Garcia
ad600d22ed merge upstream 2021-09-10 16:03:09 -04:00
Alan Donovan
8b06ffe2bd Merge pull request #145 from github/remove-script
Remove go-ghcs-crypto vendor script
2021-09-10 15:48:40 -04:00
Alan Donovan
5b23d87d47 Remove Terminal, no longer needed by ghcs 2021-09-10 15:15:05 -04:00
Jose Garcia
6c907869ff Merge pull request #144 from github/jg/remove-terminal
ghcs ssh: remove terminal, bash_profile setup
2021-09-10 15:06:18 -04:00
Jose Garcia
798075045e remove terminal, bash_profile setup 2021-09-10 14:58:47 -04:00
Jose Garcia
31e1d974aa Merge pull request #142 from github/jg/delete-flags
ghcs delete: deprecate argument/subcommands & introduce flags
2021-09-10 14:17:44 -04:00