Commit graph

1089 commits

Author SHA1 Message Date
vilmibm
168bd33bc9 pr command scriptability improvements
This commit improves behavior and error handling for pr commands when
run unattached to a tty.

- error if pr create and no -t/-f
- error if pr create and -w
- machine readable pr list
- machine readable pr view
- various cleanup of informational messages
2020-07-20 13:04:17 -05:00
vilmibm
2dd42eb9aa minor alias scriptability changes 2020-07-20 11:10:34 -05:00
vilmibm
b7765591b7 remove package level terminal check state 2020-07-17 15:02:05 -05:00
Mislav Marohnić
9e4af479da Add command line docs for supported environment variables 2020-07-16 17:46:09 +02:00
Mislav Marohnić
89adc83194
Merge pull request #1363 from shihanng/feature/issue-1361__help
Dedent help texts based on shortest indent
2020-07-16 16:44:52 +02:00
Mislav Marohnić
e6083605c5 Fix spacing around gh help sections 2020-07-16 16:41:40 +02:00
Mislav Marohnić
065496781e Add indent helper function 2020-07-16 16:24:25 +02:00
Mislav Marohnić
4e15982046 Fix crash in dedent when blank lines are passed 2020-07-16 16:10:39 +02:00
Mislav Marohnić
0528145159 Allow filter values with spaces in issue/pr list --web 2020-07-16 15:21:50 +02:00
Shi Han NG
3db8bc654a
dedent flags in rootUsageFunc 2020-07-16 22:04:40 +09:00
Shi Han NG
3fb90b43ba
dedent based on shortest indent 2020-07-16 22:04:10 +09:00
Mislav Marohnić
8626befd3f Merge remote-tracking branch 'origin' into webInList 2020-07-16 14:51:34 +02:00
Mislav Marohnić
b0fede93c9
Merge pull request #1365 from cli/pr-checkout-fixes
pr checkout fixes for branch names
2020-07-16 14:31:04 +02:00
Shi Han NG
7120b95731
add TestStripIndent 2020-07-16 08:33:00 +09:00
Nate Smith
619ef43f76
Merge pull request #1191 from cli/shell-alias
shell aliases
2020-07-15 12:24:36 -05:00
vilmibm
86912b31b2 stub sh lookup 2020-07-15 12:17:36 -05:00
vilmibm
cf3af450eb minor docs 2020-07-15 11:40:35 -05:00
vilmibm
cfb8eebf30 quietly return exit code of external command 2020-07-15 11:39:48 -05:00
vilmibm
acaaa28fd7 helper function for finding sh 2020-07-15 11:30:20 -05:00
Mislav Marohnić
dfb774cd38 Verify HTTP stubs in pr checkout tests 2020-07-15 16:18:36 +02:00
Mislav Marohnić
c232c8872c Abort pr checkout when PR has an invalid head branch name 2020-07-15 16:16:38 +02:00
Mislav Marohnić
305cd290ee Fix pr checkout <owner>:<branch> when it matches the default branch
First, consolidate the functionality between `pr merge` and `pr
checkout` that resolves the default branch name of the base repo. With
an added bonus, the new approach avoids an API request when one isn't
necessary.

Then, ensure that checking out 3rd-party PRs will result in local branch
name such as `<owner>/<branch>` when the head branch of the repository
matches the default branch of the base repository. We already have had
code in place to take care of this, but it only took effect in the `pr
checkout <number>`-style invocation.
2020-07-15 15:35:42 +02:00
Mislav Marohnić
6825944cad Reference named queries in pr checkout HTTP stubs 2020-07-15 14:54:30 +02:00
Shi Han NG
c7df292288
strip extra spaces from help texts 2020-07-15 21:38:49 +09:00
Mislav Marohnić
c8cf54c10c
Merge pull request #1258 from cli/ghe-remotes
Parse and respect non-github.com git remotes
2020-07-15 13:07:30 +02:00
vilmibm
a9d93f8c57 correct docs 2020-07-14 19:42:05 -05:00
nate smith
4bd0435c38 successfully use sh for windows aliases 2020-07-14 16:19:01 -05:00
vilmibm
f99b54a731 WIP: experimental bash support for windows 2020-07-14 16:13:00 -05:00
vilmibm
bbd756a99f split shell alias execution into new function 2020-07-14 16:13:00 -05:00
nate smith
c3a5384895 add experimental powershell support for shell aliases 2020-07-14 16:12:51 -05:00
vilmibm
3a9167cfe4 Implement shell aliases
This command adds --shell to `gh alias set`, allowing specified aliases
to be run through a shell interpreter.
2020-07-14 16:12:07 -05:00
vilmibm
754dcb744c catch up to trunk 2020-07-14 12:36:54 -05:00
vilmibm
97107661fe review feedback 2020-07-14 12:30:53 -05:00
vilmibm
36ade42ba3 scriptability improvements: issue commands
This commit is part of work to make gh more scriptable. It includes both
some general purpose helpers towards this goal as well as improvements
to the issue commands. Other commands will follow.

- Adds `utils/terminal.go` for finding out about gh's execution environment
- introduces `stubTerminal` for either faking being attached to a tty or not during tests
- updates issue commands to behave better when not attached to a tty:
  - issue list doesn't print fuzzy dates
  - issue list doesn't print header
  - issue list prints state explicitly
  - issue create no longer hangs
  - issue create fails with clear error unless both -t and -b are specified
  - issue view prints raw issue body
  - issue view prints metadata in a consistent, linewise format
2020-07-14 12:30:53 -05:00
AliabbasMerchant
4304b9e3eb filterOptions struct for pr & issue list 2020-07-14 10:26:32 +05:30
AliabbasMerchant
73552ae75c Merge 'trunk' in webInList 2020-07-14 08:53:39 +05:30
Mislav Marohnić
87a9dc8d4b Merge remote-tracking branch 'origin' into ghe-remotes 2020-07-13 13:39:14 +02:00
Mislav Marohnić
7a289861d2 Name more queries in test stubs 2020-07-10 20:20:33 +02:00
Mislav Marohnić
13b9c98b2b Match named queries in test stubs 2020-07-10 20:04:54 +02:00
Sibi
2491e98c41 Title of the PR will be shown while closing, merging and re-opening & test cases updated 2020-07-08 12:22:38 +05:30
Sibi
125547fb7b Show title while closing/reopening issue and meriging PR 2020-07-08 01:25:19 +05:30
Mislav Marohnić
e319aaa6ab Tweak pr merge docs 2020-07-07 13:41:57 +02:00
Ravikanth C
6cbcdf2a74 Clarify how the branch can be retained after pr merge 2020-07-07 13:41:39 +02:00
Mislav Marohnić
a6ffea8cf5
Merge pull request #1310 from cli/linter-fix
Fix linter warning about sprintf within println
2020-07-07 10:37:54 +02:00
ShubhankarKG
37d6be58b8 Fixed gh issue close and gh issue reopen when issue number invalid 2020-07-06 17:57:34 +05:30
Mislav Marohnić
a8c37a1f5c Fix hostname being respected in web browse commands 2020-07-02 20:54:07 +02:00
Mislav Marohnić
a68cefadd9 Merge remote-tracking branch 'origin' into ghe-remotes 2020-07-02 20:37:33 +02:00
Mislav Marohnić
446a4111f7 Respect hostnames when resolving git remotes and URL args to repos 2020-07-02 20:36:10 +02:00
Mislav Marohnić
ac7b56fc61 Fix linter warning about sprintf within println 2020-07-02 17:01:37 +02:00
Mislav Marohnić
6cc03d30ed
Merge pull request #1253 from cli/remove-global-repo-flag-for-real-this-time
Remove the global repo flag
2020-07-02 15:45:39 +02:00