Commit graph

8064 commits

Author SHA1 Message Date
benebsiny
e18c002283 Deduplicate the initialization of editor mode 2024-08-08 18:07:52 +08:00
Tyler McGoffin
40ccd2ef92
Merge pull request #9435 from cli/add-AC-to-triage-reqs
Add Acceptance Criteria requirement to triage.md for accepted issues
2024-08-07 14:55:19 -07:00
Tyler McGoffin
fa06623f9b
Update docs/triage.md
Co-authored-by: Andy Feller <andyfeller@github.com>
2024-08-07 11:46:22 -07:00
Tyler McGoffin
c5ea30da47 Add Acceptance Criteria requirement to triage.md for accepted issues
To better facilitate community collaboration and to help reduce the amount
of information any collaborator needs to peruse in a given issue,
clear Acceptance Criteria on accepted issues should be included. This will
reduce the amount of back and forth on PRs submitted by ensuring
expectations for a given issue are clear
2024-08-07 11:01:09 -07:00
Eugene
cc0fe091c4
Merge branch 'trunk' into eugene/attestation/fetch-oci-bundle 2024-08-07 10:21:34 -07:00
ejahnGithub
832a43072c minor fixed 2024-08-07 10:19:47 -07:00
ejahnGithub
d1cd69c81c minor fixed 2024-08-07 10:16:30 -07:00
ejahnGithub
57aea664e5 added test 2024-08-07 10:10:59 -07:00
benebsiny
e2275d7ef6 Add pr create --editor 2024-08-07 23:14:15 +08:00
dependabot[bot]
8356df0188
build(deps): bump github.com/google/go-containerregistry
Bumps [github.com/google/go-containerregistry](https://github.com/google/go-containerregistry) from 0.20.1 to 0.20.2.
- [Release notes](https://github.com/google/go-containerregistry/releases)
- [Changelog](https://github.com/google/go-containerregistry/blob/main/.goreleaser.yml)
- [Commits](https://github.com/google/go-containerregistry/compare/v0.20.1...v0.20.2)

---
updated-dependencies:
- dependency-name: github.com/google/go-containerregistry
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-08-07 14:25:20 +00:00
Andy Feller
86964d8809
Merge pull request #9407 from muzimuzhi/tab-indents
Unify use of tab indent in non-test source files
2024-08-06 13:18:24 -04:00
Andy Feller
000b2f95e0
Merge branch 'trunk' into tab-indents 2024-08-06 13:08:48 -04:00
Andy Feller
983e13c623
Merge pull request #9400 from cli/dependabot/github_actions/actions/attest-build-provenance-1.4.0
build(deps): bump actions/attest-build-provenance from 1.3.3 to 1.4.0
2024-08-06 13:07:36 -04:00
Andy Feller
626bbf010a
Merge pull request #9411 from cli/andyfeller/cli-9274-gh-variable-get-ghes
Update `gh variable get` to use repo host
2024-08-06 10:03:00 -04:00
ejahnGithub
bad127c342 clean naming 2024-08-05 12:56:35 -07:00
ejahnGithub
8ae4f1cfb9 add contain check 2024-08-05 12:53:43 -07:00
ejahnGithub
8d17896080 refactor the logic and logging 2024-08-05 12:25:52 -07:00
ejahnGithub
20d3931427 tmp 2024-08-05 09:11:25 -07:00
Andy Feller
c088951944 Fix host handling in variable and secret delete
This change updates `gh variable delete` and `gh secret delete` to use the host associated with the repository rather than the default host.  Along with these changes is minor refactoring of the tests to ensure appropriate Dotcom vs GHES targeting works as expected.

Minor edit to `gh variable get` testing to simplify some conditional logic in test setup.
2024-08-02 15:11:22 -04:00
Yukai Chou
d7b8ecf33d Unify use of tab indent in non-test source files
Found with
    rg '(^ | \t|\t )' -g '*.go' -g '!*_test.go'

Mixed indent exceptions:
- wrapped long list items with extra 2-space indent
- code snippets using space indent
- commented code lines having "\t*// \t+" prefix
2024-08-03 00:35:30 +08:00
Andy Feller
22a5a4c899 Update gh variable get to use repo host
Closes #9274

This change addresses a bug where repository and repository environment variables are not being retrieved from the appropriate host, causing GHES users to fail without specifying `GH_HOST` to force `gh variable set` to do the right thing.

In addition, the tests for this command have been updated to check both github.com and GHES variations to ensure this works.
2024-08-02 10:36:32 -04:00
Eugene
89cbcfe7eb
Merge pull request #9392 from cli/eugene/gh-attestation-case-insensitivity
handle attest case insensitivity
2024-07-31 15:19:49 -07:00
dependabot[bot]
ad96ad3580
build(deps): bump actions/attest-build-provenance from 1.3.3 to 1.4.0
Bumps [actions/attest-build-provenance](https://github.com/actions/attest-build-provenance) from 1.3.3 to 1.4.0.
- [Release notes](https://github.com/actions/attest-build-provenance/releases)
- [Changelog](https://github.com/actions/attest-build-provenance/blob/main/RELEASE.md)
- [Commits](5e9cb68e95...210c191353)

---
updated-dependencies:
- dependency-name: actions/attest-build-provenance
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-07-31 14:55:39 +00:00
ejahnGithub
87ff22d37d Merge branch 'tmp-07-31' into eugene/gh-attestation-case-insensitivity 2024-07-31 07:31:58 -07:00
ejahnGithub
1eaf712dd1 update test and remove logic to check SourceRepositoryOwnerURI is empty string 2024-07-31 07:29:43 -07:00
Bryan Honof
a7d04fc2ec Add Flox as an installation option 2024-07-31 00:17:59 +02:00
Eugene
12715fdcc6
Merge branch 'trunk' into eugene/gh-attestation-case-insensitivity 2024-07-30 14:07:09 -07:00
ejahnGithub
596ee8bd71 update test 2024-07-30 13:22:49 -07:00
ejahnGithub
580ddf6997 minor fix 2024-07-30 13:14:16 -07:00
ejahnGithub
e21e5ef5c5 update test 2024-07-30 13:09:28 -07:00
ejahnGithub
c1adb1a6cf added 2024-07-30 12:24:27 -07:00
ejahnGithub
dc4e9cb532 handle attest case insensitivity 2024-07-30 12:11:25 -07:00
Babak K. Shandiz
8ea1b8973a
Update tests with changes to gitTagInfo function
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-30 00:21:19 +01:00
Babak K. Shandiz
46814b3759
Add example for --notes-from-tag
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-29 23:26:19 +01:00
Babak K. Shandiz
df3b0627fd
Add test for gitTagInfo
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-29 23:26:03 +01:00
Babak K. Shandiz
b9963809c2
Use signature-stripped tag annotation content
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-29 23:25:34 +01:00
Andy Feller
b05bddc210
Merge pull request #9344 from babakks/9292-add-remove-milestone-option
Add `--remove-milestone` option to `issue edit` and `pr edit`
2024-07-29 17:31:20 -04:00
Babak K. Shandiz
58e6196777
Fix missing variable
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-29 21:41:43 +01:00
Babak K. Shandiz
a73ae65ca8
Use closure-scoped variable to catch --remove-milestone option
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-29 21:40:24 +01:00
Babak K. Shandiz
842562d3db
Use closure-scoped variable to catch --remove-milestone option
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-29 21:40:23 +01:00
Babak K. Shandiz
457274bde5
Merge branch 'trunk' into 9292-add-remove-milestone-option 2024-07-29 21:22:07 +01:00
Andy Feller
0d87ddaca6
Merge pull request #9373 from cli/dependabot/go_modules/github.com/google/go-containerregistry-0.20.1
build(deps): bump github.com/google/go-containerregistry from 0.20.0 to 0.20.1
2024-07-29 16:09:32 -04:00
dependabot[bot]
fbae0e223e
build(deps): bump github.com/google/go-containerregistry
Bumps [github.com/google/go-containerregistry](https://github.com/google/go-containerregistry) from 0.20.0 to 0.20.1.
- [Release notes](https://github.com/google/go-containerregistry/releases)
- [Changelog](https://github.com/google/go-containerregistry/blob/main/.goreleaser.yml)
- [Commits](https://github.com/google/go-containerregistry/compare/v0.20.0...v0.20.1)

---
updated-dependencies:
- dependency-name: github.com/google/go-containerregistry
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-07-29 19:59:50 +00:00
Andy Feller
d527775d58
Merge pull request #9372 from cli/dependabot/go_modules/github.com/gabriel-vasile/mimetype-1.4.5
build(deps): bump github.com/gabriel-vasile/mimetype from 1.4.4 to 1.4.5
2024-07-29 15:58:48 -04:00
Babak K. Shandiz
c9fb4ed099
Verify --milestone and --remove-milestone are not assignable at the same time
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-28 15:44:05 +01:00
Babak K. Shandiz
605b4b19e1
Assert correct parsing of --remove-milestone option
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-28 15:43:38 +01:00
Babak K. Shandiz
6dc8cc41d0
Verify --body and --body-file are not assignable at the same time 2024-07-28 15:41:54 +01:00
Babak K. Shandiz
1520292726
Add --remove-milestone option
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-28 15:40:38 +01:00
Babak K. Shandiz
4c8ec84e26
Improve --remove-milestone option description
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-28 15:23:19 +01:00
Babak K. Shandiz
6e34e81b76
Point to Editable.MilestoneId method
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-28 15:22:54 +01:00