nate smith
18975e61d1
fix imports
2021-10-15 14:31:29 -05:00
nate smith
b81eda0c46
newline
2021-10-15 14:28:28 -05:00
nate smith
f329ebd7ca
add interactive prompt for in progress runs
2021-10-15 14:19:16 -05:00
nate smith
4a01e6b702
Merge remote-tracking branch 'origin/trunk' into gh-run-cancel
2021-10-15 14:12:53 -05:00
Marwan Sulaiman
6f34e4a605
Rename privacy sub-command to visibility ( #4533 )
...
* Rename privacy sub-command to visibility
* PR fixes
2021-10-15 09:51:46 -04:00
Jose Garcia
4504e49e96
Update running method
2021-10-14 20:02:02 -04:00
Jose Garcia
1aec892326
Merge pull request #4520 from cli/jg/new-api-shape
...
codespace: implement new API payload
2021-10-14 19:59:59 -04:00
Mislav Marohnić
f6b33572fd
Merge pull request #4279 from SiarheiFedartsou/sf-pr-list-head-filter
...
Add `--head` filter to `gh pr list`
2021-10-14 20:54:56 +02:00
Nate Smith
cb89b8ca7a
Merge pull request #4442 from cli/cleanup-upgrade
...
Cleanup extension upgrade command
2021-10-14 13:39:14 -05:00
Mislav Marohnić
b0360612d2
Merge pull request #4521 from cli/jg/bind-locally
...
codespace: switches port binding to 127.0.0.1 where possible
2021-10-14 20:29:21 +02:00
Mislav Marohnić
78443964d4
Merge pull request #4513 from cli/missing-oauth-scopes
...
Warn about missing OAuth scopes when reporting HTTP 4xx errors
2021-10-14 20:21:13 +02:00
Mislav Marohnić
89ad870190
auth refresh: preserve existing scopes when requesting new ones
...
When there was a previously valid token that was granted some scopes,
ensure all those scopes will be re-requested when doing the
authentication flow for the new token.
2021-10-14 19:52:59 +02:00
Mislav Marohnić
64a19ee71f
Remove OAuth scopes checking logic from ssh-key commands
...
Scopes checking is now handled on the HTTP client level for all commands.
2021-10-14 18:36:55 +02:00
Nate Smith
78ac77180e
Merge pull request #3950 from bchadwic/browse-commit
...
Add feature open latest commit in gh browse
2021-10-14 11:31:15 -05:00
nate smith
5bdaab882b
fix
2021-10-14 11:25:33 -05:00
Jose Garcia
b0905a415f
Merge pull request #4508 from cli/jg/codespace-stop
...
codespace stop: new command to stop a running codespace
2021-10-14 11:22:25 -04:00
Jose Garcia
0748e658cc
Switches port binding to 127.0.0.1 where possible
2021-10-14 11:07:25 -04:00
Jose Garcia
5e56b4a7ce
Fix tests
2021-10-14 09:21:03 -04:00
Jose Garcia
3544275c2f
Implement new API payload for a Codespace
2021-10-14 09:10:15 -04:00
nate smith
d72d0f47f6
Merge remote-tracking branch 'origin/trunk' into browse-commit
2021-10-13 16:53:50 -05:00
Mislav Marohnić
2ca18e0600
Warn about missing OAuth scopes when reporting HTTP 4xx errors
...
If a 4xx server response lists scopes in the X-Accepted-Oauth-Scopes
header that are not present in the X-Oauth-Scopes header, the final
error messaging on stderr will now include a hint for the user that they
might need to request the additional scope:
$ gh codespace list
error getting codespaces: HTTP 403: Must have admin rights to Repository. (https://api.github.com/user/codespaces?per_page=30 )
This API operation needs the "codespace" scope. To request it, run: gh auth refresh -h github.com -s codespace
2021-10-13 23:24:14 +02:00
Jose Garcia
d5c9630fae
Merge pull request #4511 from cli/jg/keepalive-fix
...
codespace ssh: fix for nil logger on non-debugging scenarios
2021-10-13 14:44:10 -04:00
Jose Garcia
3dbec86556
PR Feedback
2021-10-13 14:30:33 -04:00
Jose Garcia
d6b5157eff
Fix for nil logger on non-debugging scenarios
2021-10-13 14:15:26 -04:00
Marwan Sulaiman
b9bdef2b00
Add org scoped port forwarding + fix test formatting ( #4497 )
...
* Add org scoped port forwarding + fix test formatting
* Redesign port visibility
* Update pkg/cmd/codespace/ports.go
Co-authored-by: Jose Garcia <josebalius@github.com>
* Change sub command to privacy
* Example pr comment
* Fix test mock
* Fix test mock
Co-authored-by: Jose Garcia <josebalius@github.com>
2021-10-13 13:56:03 -04:00
Jose Garcia
07fa60b69a
PR Feedback
2021-10-13 11:46:57 -04:00
Jose Garcia
be10950058
Update mocks
2021-10-13 11:04:15 -04:00
Jose Garcia
4fb4a21efd
Rename + docs
2021-10-13 10:57:50 -04:00
Jose Garcia
97b52b30fc
Merge branch 'trunk' of github.com:cli/cli into jg/liveshare-keepalive
2021-10-13 10:45:40 -04:00
Jose Garcia
ea0d0a543f
Initial StopCodespace implementation
...
- API
- Command
2021-10-13 07:45:54 -04:00
Sam Coe
defbf0f306
Make extension upgrade output more friendly
2021-10-12 16:47:19 -07:00
Jose Garcia
5170a2931f
Switch to standard lib log.Logger & support dfile
...
- --debug-file flag can now be used in conjuction with --debug to
specify the debug file path
- Push out logger concerns to callers of liveshare
2021-10-12 15:45:05 -04:00
Sam Coe
ed3427974c
Use concurrency to check for extension updates
2021-10-12 09:44:41 -07:00
Parth
ec554822b8
Add repo archive command ( #4410 )
...
Co-authored-by: meiji163 <mysatellite99@gmail.com>
2021-10-12 12:48:40 +02:00
Mateusz Urbanek
cedbbe3c2a
Add limit flag to codespace list ( #4453 )
...
Co-authored-by: Mislav Marohnić <mislav@github.com>
2021-10-11 18:32:40 +00:00
Mislav Marohnić
e4c8aa3b2b
Add tests for pr diff --patch
2021-10-08 13:53:19 +02:00
Jose Garcia
8a559ee12a
Fix unrelated tests
2021-10-07 15:38:16 -04:00
Jose Garcia
7ba2fb4c0e
Make fileLogger more versatile
2021-10-07 15:19:14 -04:00
Adarsh K Kumar
e0897fd8e8
#2720 | Add patch flag to pull-request diff command
2021-10-07 23:09:21 +05:30
Jose Garcia
9c8351ecd8
Merge branch 'trunk' of github.com:cli/cli into jg/liveshare-keepalive
2021-10-07 11:10:45 -04:00
Jose Garcia
55f4fcf05c
Live Share session activity detection
...
- Session now accepts two new options: ClientName and Logger
- Port forwarder now supports a keepAlive parameter which when true,
instructs the PF to call the session's keepAlive method.
- Port forwarder uses a new traffic monitor to detect I/O traffic and
notify the session when applicable.
- The SSH command introduces a new debug flag which enables the command
to log to a new temporary file. The file path is printed to the user.
2021-10-07 10:42:06 -04:00
Sam
becc45a1df
Merge pull request #4437 from cli/fix-extension-io-bug
...
Set io when initializing extension manager
2021-10-06 12:54:25 -07:00
Jose Garcia
b44474c32b
Revert rename for ports cmd
2021-10-06 13:47:20 -04:00
Jose Garcia
bdc9ad30e7
Revert other rename changes
2021-10-06 13:46:04 -04:00
Jose Garcia
771ac714ac
Update docs
2021-10-06 11:47:18 -04:00
Jose Garcia
3a28643630
Keep codespace struct in API for now
...
- Use a private codespace structure in the cmd pkg to encapsulate common
behavior
2021-10-06 11:44:26 -04:00
Jose Garcia
017632d63d
Merge branch 'trunk' of github.com:cli/cli into jg/choose-codespace-prompt
2021-10-06 09:57:39 -04:00
Jose Garcia
7c497f283b
Update test signature
2021-10-06 09:15:07 -04:00
Jose Garcia
8bb55359b1
Update mock API
2021-10-06 09:10:00 -04:00
Jose Garcia
8135fdbd99
Switch GetCodespace to new API endpoint
...
- Drop GetCodespaceToken as it is no longer necessary
- Introduces new behavior with the API to optionally include connection
details in the GET request. Ommitting to do so results in a faster
response
2021-10-06 08:50:42 -04:00