bagtoad
deb34d6456
Refactor error handling for missing "workflow" scope in createRelease
2024-11-23 16:59:49 -07:00
Kynan Ware
a4f96d29e3
Refactor workflow scope checking
...
Refactor the logic for checking `workflow` scope checking in releases to be in the positive - check if the scope is there, not check if it isn't there. Then, when the function is called we invert it.
Also update comments to be more imperative.
This refactor also incorporates @andyfeller's suggestion to use `slices`.
Co-Authored-By: Andy Feller <andyfeller@github.com>
2024-11-23 13:17:09 -07:00
bagtoad
68f3ef79ca
Handle missing "workflow" scope in createRelease
2024-11-16 19:32:37 -07:00
Zongle Wang
192f57ef42
Improve the help message for -F ( #9525 )
...
Changing to `release-notes.md` from `changelog.md` may help users better contextually understand usage.
Co-authored-by: Tyler McGoffin <jtmcg@github.com>
2024-08-28 11:00:46 -07:00
Babak K. Shandiz
6dc729792d
Merge branch 'trunk' into 9299-improve-annotated-releases
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-08-10 21:55:41 +01:00
Babak K. Shandiz
668dbcefc6
Add test cases for PGP, SSH and X.509 signatures
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-08-10 21:50:31 +01:00
Babak K. Shandiz
b36b39df60
Explain why not looking for signature begin marker
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-08-10 21:29:22 +01:00
Yukai Chou
d7b8ecf33d
Unify use of tab indent in non-test source files
...
Found with
rg '(^ | \t|\t )' -g '*.go' -g '!*_test.go'
Mixed indent exceptions:
- wrapped long list items with extra 2-space indent
- code snippets using space indent
- commented code lines having "\t*// \t+" prefix
2024-08-03 00:35:30 +08:00
Babak K. Shandiz
8ea1b8973a
Update tests with changes to gitTagInfo function
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-30 00:21:19 +01:00
Babak K. Shandiz
46814b3759
Add example for --notes-from-tag
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-29 23:26:19 +01:00
Babak K. Shandiz
df3b0627fd
Add test for gitTagInfo
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-29 23:26:03 +01:00
Babak K. Shandiz
b9963809c2
Use signature-stripped tag annotation content
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-29 23:25:34 +01:00
William Martin
c13d161271
Export databaseId for releases
2024-07-23 13:41:56 +02:00
William Martin
99ff84bdd9
Alphabetise release json fields
2024-07-23 13:41:56 +02:00
William Martin
13dea3e35d
Add test for release view json export fields
2024-07-23 13:41:56 +02:00
Corey Christous
9b40e0ca15
Update create.go
2024-07-07 13:57:05 -04:00
Andy Feller
af0288910c
Merge pull request #8987 from kuzdogan/patch-1
...
Add --latest=false to `gh release create` docs
2024-05-10 13:03:01 -04:00
William Martin
1d38230675
Move config interfaces into gh package ( #9060 )
2024-05-10 10:39:36 +02:00
Kaan UzdoÄŸan
7b2bd95c9a
Add --latest=false example to release create command
2024-05-02 11:08:37 +02:00
Kaan UzdoÄŸan
18d8079d6f
Update create.go
2024-04-22 17:59:03 +02:00
Kaan UzdoÄŸan
4090f0488f
Add --latest=false to gh release create docs
2024-04-22 17:52:27 +02:00
Roman Podoliaka
0d84970bbb
Fix the description of gh release upload
...
The formatting verb is used incorrectly and produces a misleading
help text for this command:
```
To define a display label for an asset, append text starting with %#% after the file name.
```
instead of the expected:
```
To define a display label for an asset, append text starting with `#` after the file name.
```
2024-03-18 11:19:20 +00:00
Zack Sloane
f70bcba779
switch to [] characters for default info in usage strings
2024-02-01 21:35:31 +00:00
Zack Sloane
15166f485a
Merge branch 'cli:trunk' into trunk
2024-02-01 16:27:12 -05:00
victor
3db1bee20d
fixed linting
2024-01-26 16:12:55 -05:00
victor
5cea8aa74d
fixed linting
2024-01-26 16:10:48 -05:00
victor
795213319e
added Order flag for release list command
2024-01-26 15:47:08 -05:00
Zack Sloane
3339e62666
Merge branch 'cli:trunk' into trunk
2024-01-24 12:42:25 -05:00
William Martin
89b5dbc2b7
Merge pull request #8589 from fpistm/typo_fix
...
Fix some typos raised by codespell
2024-01-18 12:42:05 +01:00
Victor Martinez
b62e977c91
Add --json export flags to release list command ( #8474 )
2024-01-17 10:51:01 -08:00
Frederic Pillon
55d251ac51
Fix some typos raised by codespell
...
With .codespellignore containing:
aline
commitish
messag
noes
nwo
parth
prfiles
runn
timere
ue
welp
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
2024-01-17 15:34:49 +01:00
Zack Sloane
1b58b7d7f1
Merge branch 'trunk' into trunk
2024-01-11 09:51:22 -05:00
Sam Coe
785a340f78
Prevent downloading releases with assets that match windows reserved filenames ( #8517 )
...
* Prevent downloading releases with assets that match windows reserved filenames
* Add comment noting potential use of build constraints in the future
2024-01-09 09:53:57 -08:00
Zack Sloane
b6dadfa7fb
test update, more consistent default value display
2024-01-08 23:23:24 -05:00
Andy Feller
b77de0d458
Additional formatting changes
...
- gh help actions
- highlight 3 commands to run for more information
- gh extension
- wrapping url for online linking
- fix install subcommand missing backtick formatting
- gh release create
- fixing mixed indenting causing usage misalignment
- root help
- backtick wrap help command for more info for consistency
- gh help environment
- backtick wrap missed OWNER/REPO
- gh variable
- brought consistency to output when deleting or setting variable
2023-12-01 09:08:51 -05:00
Yukai Chou
afbdb945bc
Small docs tweaks
2023-11-23 07:14:38 +08:00
Yukai Chou
21bf1babdf
Proof-reading
2023-11-17 02:04:35 +08:00
Yukai Chou
17d336e005
Wrap cli flags in backticks uniformly
2023-11-16 22:54:27 +08:00
Yukai Chou
ccf45cc7c6
Improve gh release download doc ( #8294 )
...
* Improve `gh release download` doc
When downloading latest release assets,
`gh release download --archive=(zip|tar.gz)` works too.
Sync doc with no-arguments warning.
* Apply suggestion from code review
Co-authored-by: Sam Coe <samcoe@users.noreply.github.com>
---------
Co-authored-by: Sam Coe <samcoe@users.noreply.github.com>
2023-11-06 07:59:03 +00:00
Arun Sathiya
5eff7a529a
fix(release create): Handle latest flag value when updating the release after assets are uploaded ( #8207 )
...
Signed-off-by: Arun <arun@arun.blog>
Co-authored-by: William Martin <williammartin@github.com>
2023-11-01 15:17:05 +01:00
Heath Stewart
7738b6187c
Add headers to all tables ( #8157 )
2023-10-20 11:20:02 +02:00
Sam Coe
94fbbdf9b5
Cleanup release create around new --notes-from-tag flag ( #8016 )
2023-09-19 08:26:52 +00:00
Keith Bailey
be41a9bd20
moved remoteTagExists under if NotesFromTag exists and added three tests
2023-09-11 14:17:49 -04:00
Keith Bailey
9f68a49304
Merge branch 'cli:trunk' into git-tag-release-notes
2023-09-07 17:31:20 -04:00
Keming
ba60f89f42
Delete local tag when running gh release delete --cleanup-tag ( #7884 )
2023-09-07 12:04:15 +00:00
Keith Bailey
f43861201d
Merge branch 'trunk' into git-tag-release-notes
2023-08-18 00:18:28 -04:00
Keith Bailey
5ccfbe9d7e
Add gh release create [<tag>] --notes-from-tag
...
Generates release notes from an annotated git tag noninteractively.
Fixes #6718
2023-08-17 23:17:29 -04:00
Sam Coe
e0d2fc8eaa
Use filepath.Base to sanitize path for archive downloads ( #7805 )
2023-08-07 07:35:47 -07:00
Harvey Sanders
f777bec798
release create: Trim spaces on interactive tag name input (#7759 )
2023-07-27 09:18:51 -07:00
Sam Coe
7f3196fcd4
Use filepath.Clean to sanitize path for archive downloads ( #7720 )
2023-07-18 12:49:55 -07:00