Mislav Marohnić
f39d57862d
Clarify -R format
2019-12-19 18:55:31 +01:00
Amanda Pinsker
de814595f5
Clarify repo flag language
2019-12-17 11:22:41 -05:00
Mislav Marohnić
4ad89829c5
Merge remote-tracking branch 'origin/master' into stderr-tests
2019-12-17 12:42:01 +01:00
Nate Smith
00da5c2788
Merge pull request #158 from github/issue-create-web
...
Add "Opening URL in your browser" notice to `issue create --web`
2019-12-16 10:53:31 -06:00
Nate Smith
82fbbb28e8
Merge pull request #162 from github/gh-help-lines
...
Avoid long first line of gh help
2019-12-16 10:53:00 -06:00
Mislav Marohnić
030c997301
Avoid long first line of gh help
...
This splits help text over paragraphs and lines to make the output of
`gh` easier to read. It takes care not to go over 80 characters in width
and wraps the URL in `<...>` which will help the URL get auto-linked
when these docs are converted to man and HTML formats.
2019-12-16 15:55:21 +01:00
Mislav Marohnić
48aeff1ca7
Assert stdout separarely from stderr in command tests
...
This stubs stderr separately from stdout in command tests (before those
streams were combined) and improves test assertions around output.
Additionally, no longer use the `cmd.Print*()` family of Cobra functions
because their name sounds like the text will go to stdout, but they
write to stderr instead. Use the more explicit `cmd.ErrOrStderr()` as
output destination instead.
2019-12-16 15:46:42 +01:00
Mislav Marohnić
57c7266328
Fix displaying "There are no issues assigned to you" notice
2019-12-16 14:08:55 +01:00
Mislav Marohnić
5d6b095f1a
Add "Opening URL in your browser" notice to issue create --web
2019-12-16 13:39:22 +01:00
Mislav Marohnić
e93ab66107
Merge pull request #147 from github/pr-to-pull-request
...
Consistently use "pull request" instead of "PR" in user-facing copy
2019-12-13 17:14:17 +01:00
Corey Johnson
0bfd8213e2
Merge pull request #144 from github/better-better-better
...
Better error messages when you don't supply an arg
2019-12-12 11:31:26 -08:00
Corey Johnson
9b5f7a8148
Use new error.As method
2019-12-12 11:09:50 -08:00
Nate Smith
995093591b
s/-B/-T
2019-12-11 15:03:23 -06:00
Corey Johnson
92642f4d53
Create NotFoundError
2019-12-11 10:58:59 -08:00
Corey Johnson
2218e60264
Label as pull request
2019-12-11 10:24:58 -08:00
Corey Johnson
573dda22a1
Simplify flag setting
2019-12-11 10:19:18 -08:00
Mislav Marohnić
cc7b2f0ea8
Consistently use "pull request" instead of "PR" in user-facing copy
2019-12-11 09:31:57 +01:00
Corey Johnson
53ed20f32a
Fix test
2019-12-10 16:15:37 -08:00
Corey Johnson
748b213c9a
Add error details for gh issue view
2019-12-10 16:04:04 -08:00
Corey Johnson
9b40efcad5
Add better gh pr view message
2019-12-10 16:03:10 -08:00
Corey Johnson
5296f72189
Better messaging for gh pr checkout
2019-12-10 16:03:05 -08:00
Corey Johnson
5949ca4b56
Merge pull request #142 from github/empty-pr-list
...
Add empty state for `gh pr list`
2019-12-10 12:04:41 -08:00
Corey Johnson
4de0a76234
Merge pull request #141 from github/add-url-branch-to-usage
...
Add better usage docs for `gh pr view` `gh pr checkout` `gh issue view`
2019-12-06 14:39:43 -08:00
Corey Johnson
eb414bf2a1
Add a little test
2019-12-06 14:33:04 -08:00
Corey Johnson
f70473c234
Replace excessive whitespace
2019-12-06 14:32:55 -08:00
Corey Johnson
00b38bb11c
Add better message to empty gh issue list
2019-12-06 14:10:01 -08:00
Corey Johnson
9aa3f35f8a
Better language in the "no pr" state
2019-12-06 13:33:57 -08:00
Corey Johnson
387b9d9544
better name?
2019-12-06 13:33:23 -08:00
Corey Johnson
f1eb29b791
Add colorableErr
2019-12-06 13:32:36 -08:00
Mislav Marohnić
5f90cdc801
Elaborate on what is accepted as issue/PR arguments
2019-12-06 18:01:36 +01:00
Mislav Marohnić
4b8921f011
Consistently use {} to denote mutually exclusive options
2019-12-06 18:01:14 +01:00
Mislav Marohnić
8222e7d74f
Consistently use <> to denote placeholders
2019-12-06 17:59:36 +01:00
Corey Johnson
bbb91d6a2a
Replace newlines
2019-12-05 14:12:12 -08:00
Corey Johnson
fee303699a
Show message when there are no PRs
2019-12-05 12:01:05 -08:00
Corey Johnson
cce2fd4a22
Add better usage docs
2019-12-05 11:40:36 -08:00
Mislav Marohnić
5c4a94e13a
Merge pull request #132 from github/pr-create--web
...
Add `gh pr create --web` to open a PR using web flow
2019-12-04 22:31:57 +01:00
Mislav Marohnić
551f365bfc
Merge pull request #129 from github/pr-arg-selector
...
Support issue/PR URLs & PR branch names passed as arguments
2019-12-04 22:03:07 +01:00
Corey Johnson
418da8713b
Merge pull request #128 from github/add-feedback
...
Add google form link to root help description
2019-12-04 10:48:33 -08:00
Corey Johnson
b6adf7f4b1
Merge branch 'master' into upgrade-gh-reminder
2019-12-04 09:55:23 -08:00
Mislav Marohnić
fb8a7e26e6
Reset bool flags so they don't leak between tests
2019-12-04 16:47:11 +01:00
Mislav Marohnić
5ac4b1e6d6
Implement pr create --web
2019-12-04 16:26:40 +01:00
Mislav Marohnić
5d644d2468
Silence stderr in git push during pr create but show it on failures
2019-12-04 16:16:10 +01:00
Mislav Marohnić
87a1490d1e
Improvements to update notifier authentication
...
- Check for updates even if `~/.config/gh` does not exist. In this case,
the API call is unauthenticated.
- Avoid having the update notifier ever triggering the OAuth flow.
2019-12-04 15:41:08 +01:00
Mislav Marohnić
4e859fa7ca
Validate PR passed as pr view <url> before opening it
2019-12-03 21:45:28 +01:00
Mislav Marohnić
b223176b37
Accept issue URL in issue view <issue>
...
Also validates that the issue passed either by number or by URL exists.
2019-12-03 21:41:22 +01:00
Mislav Marohnić
29de133ccf
Accept PR URL or branch argument in pr checkout <pr>
2019-12-03 21:19:09 +01:00
Mislav Marohnić
519e731038
Allow specifying PR URL or branch name for pr view <pr>
2019-12-03 20:52:36 +01:00
Mislav Marohnić
f87680e804
Explain multiple code paths
2019-12-03 19:52:45 +01:00
Mislav Marohnić
db7874add5
go fmt
2019-12-03 17:26:34 +01:00
Mislav Marohnić
2621bccc44
Use RunCommand in tests to ensure flags reset between runs
2019-12-03 17:26:28 +01:00
