Eljo George
53bddb0fd5
Update codespaces ssh doc
2022-08-03 19:50:55 +00:00
Eljo George
ace223d782
updated message
2022-08-01 23:49:49 +00:00
Eljo George
02902e29b4
CS ssh helptext to indicate how to install ssh
2022-08-01 23:08:14 +00:00
Caleb Brose
b5348f661e
Handle case of partial name match
2022-06-29 11:36:27 -05:00
Caleb Brose
1bae759d3e
Don't use strings.Replace
2022-06-29 11:10:50 -05:00
Caleb Brose
77ecd0a147
Rename public key first for edge cases
2022-06-29 10:56:31 -05:00
Caleb Brose
2ac379f689
Comment
2022-06-29 10:54:07 -05:00
Caleb Brose
19b5400811
Handle back compat
2022-06-29 10:46:44 -05:00
Caleb Brose
0687f66208
Use codespaces.auto instead for the automatic ssh keys
2022-06-28 16:26:18 -05:00
Mark Phelps
38ea62afba
Codespaces list by repo ( #5854 )
...
* WIP
* Allow to list codespaces by repo
* Tests
* Cleanup
* respond to PR feedback
* Address review comments
2022-06-28 13:34:04 +00:00
Greggory Rothmeier
4b36dc031f
Add flag to list codespaces under an organization ( #5807 )
...
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-06-21 13:57:40 +00:00
Caleb Brose
83153fe9e5
Cleanups from PR comments
2022-06-14 14:33:41 +00:00
Caleb Brose
9f6e1c774b
Check for key already exists
2022-06-13 19:31:44 +00:00
Caleb Brose
919dcebc45
Rename Context
2022-06-13 19:16:16 +00:00
Caleb Brose
b5580f9503
Refactor inferfaces from PR comments
2022-06-13 19:04:29 +00:00
cmbrose
ec58990715
Typo
2022-06-10 12:38:10 -05:00
cmbrose
eebef06c67
Merge main and use func options again
2022-06-07 12:27:29 -05:00
cmbrose
60032db5eb
Use function options pattern
2022-06-07 11:04:08 -05:00
cmbrose
8e8632ddab
Prepend flag for scp support
2022-06-03 14:24:15 -05:00
cmbrose
f67ca53c07
Refactor ssh_keys to a more common location
2022-06-03 13:39:52 -05:00
JP Ungaretti
a1629c70c0
Generate codespaces key
2022-05-31 17:19:16 -07:00
cmbrose
ac630880c6
Refactor to WithOptions
2022-05-31 15:52:16 -05:00
JP Ungaretti
76090a2ea7
Add key to RPC call
2022-05-26 21:45:20 +00:00
Caleb Brose
55bce59ab7
Add command to open codespaces in JupyterLab
...
Add command to open codespaces in JupyterLab
2022-04-28 16:11:14 -05:00
JP Ungaretti
ceba2c896b
Use safeClose instead of Close
2022-04-28 18:38:46 +00:00
Håvard Anda Estensen
58cb773e09
Replace ioutil with io and os ( #5498 )
2022-04-26 13:07:44 +02:00
JP Ungaretti
3216d1bb3a
Remove function return
2022-04-21 14:29:30 -07:00
JP Ungaretti
4452f37819
Clarify session helper
2022-04-14 17:10:11 -05:00
JP Ungaretti
eaf8f84baf
Merge branch 'trunk' into add-cs-jupyter
2022-04-14 15:27:40 -05:00
Mislav Marohnić
3f5311ea1c
Merge pull request #5345 from znull/znull/ssh-config-example
...
ssh.go: use setup example that should work with any ssh config
2022-03-29 16:15:56 +02:00
Jason Lunz
17cb6346a5
ssh.go: use setup example that should work with any ssh config
...
The `gh cs ssh` command suggests an example recipe for setting up
openssh integration. The last step appends an `Include` statement to the
user's `~/.ssh/config`.
Unfortunately, this won't always work as intended. If the existing
configuration ends with a `Host` block, the added `Include` statement
will be conditional on whether that block matches.
By preceding the `Include` statement with `Match all`, we can ensure
that it is always evaluated.
2022-03-23 17:00:36 -06:00
Caleb Brose
623e67f6b1
Update comments/usage and remove --
2022-03-23 16:09:07 +00:00
Caleb Brose
f22320a478
Parse scp args
2022-03-22 01:57:37 +00:00
Steve Gray
b48a93cddf
Remove unwanted trailing quote
...
Removes a stray quote from the codespace ssh example.
2022-03-18 14:06:27 -06:00
Charlie Andrews
64eecef176
Remove unhelpful error wrapper
2022-03-16 09:36:14 -04:00
Charlie Andrews
8bf0cb8f13
Refactor the getOrChooseCodespace to always check for pending ops
2022-03-16 08:56:17 -04:00
Charlie Andrews
afa71c4b2f
Disallow ssh'ing to codespace with a pending operation
...
Since the API already disallows this, this makes the error cleaner and
more explicit when a user is trying to start/ssh into a codespace that
has a pending operation.
Example of the old error message:
```
$ gh cs ssh -c cwndrws-redacted
Starting codespace ⣽error connecting to codespace: error starting codespace: HTTP 422: your codespace has an operation pending: updating to a sku with a different amount of storage; please wait until this operation is complete (https://api.github.com/user/codespaces/cwndrws-redacted/start )
exit status 1
```
Example of the new error message:
```
$ gh cs ssh -c cwndrws-redacted
codespace is disabled while it has a pending operation: Changing machine types...
exit status 1
```
2022-03-15 17:21:28 -04:00
GitHub Action
21a1059f7c
Add --profile option to gh cs cp
2022-03-10 19:01:55 -06:00
JP Ungaretti
fba5fb4eec
Refactor liveshare setup to a new function
2022-03-04 00:54:15 +00:00
Jason Lunz
61e5fbb007
Revert "move gh cs ssh --config into a separate gh cs ssh config command"
...
This reverts commit c9d0085e57
2022-01-06 10:03:54 -07:00
Mislav Marohnić
3b7e5fc246
Store Executable() information on codespaces App
...
This is to avoid having to explicitly pass it to each subcommand that
needs it. Each codespaces command runs in the context of App, so that's
a point of shared context that we can store state in.
2021-12-21 14:03:10 +01:00
Jason Lunz
38eb894d73
prevent leaking any blocked goroutines on error
2021-12-20 13:57:53 -07:00
Jason Lunz
932c9da473
clean up inadvertently truncated help message
2021-12-20 13:57:53 -07:00
Jason Lunz
7bd6fe9af8
maximize the time checkAuthorizedKeys has to run concurrently
...
Also, other than that, restore the original ordering of this function
2021-12-20 13:57:53 -07:00
Jason Lunz
a864985f0a
use WaitGroup for a more idiomatic concurrency pattern
2021-12-20 13:57:53 -07:00
Jason Lunz
81b34d272c
inline openSSHSession
2021-12-20 13:57:53 -07:00
Jason Lunz
28dd73ffdf
always pass a non-nil logger to openSSHSession
2021-12-20 13:57:53 -07:00
Jason Lunz
37f8039f76
merge ensureAuthorizedKeys into checkAuthorizedKeys
2021-12-20 13:57:52 -07:00
Jason Lunz
ae3aacb964
fix errcheck linter warning
2021-12-20 13:57:52 -07:00
Jason Lunz
6b34fa2a27
oh look, struct definitions can be scoped!
2021-12-20 13:57:52 -07:00
