Andy Feller
47225bcf56
Merge pull request #10737 from cli/andyfeller/muted-text-part2-github-cli-833
...
Ensure muted text is thematic and customizable
2025-04-08 16:59:36 -04:00
Andy Feller
918cafc222
Deprecate ColorScheme.Gray for ColorScheme.Muted
...
This commit converts all of the places using ColorScheme.Gray and ColorScheme.Grayf to Muted and Mutedf.
There is a little extra tidying up with local variable names or converting code to use Mutedf format.
2025-04-06 10:18:48 -04:00
Andy Feller
3eca268a7f
Introduce color_labels support, update commands
...
This commit implements the actual changes around configuration setting / environment variable logic for displaying labels using their RGB hex color code in terminals with truecolor support.
One of the subtler changes in this commit is renaming generic ColorScheme.HexToRGB logic to render truecolor to ColorScheme.Label as this feature was being used exclusively for labels. This is due to confusion about introducing the new `color_labels` config on top of generic coloring logic.
2025-04-02 18:24:20 -04:00
Andy Feller
bec527d49e
Clean up pr/issue comment test names
2025-03-18 16:14:14 -04:00
Andy Feller
a47651df43
Bring issue/PR comment tests up to par, correct
...
This commit brings the `gh issue comment` and `gh pr comment` tests in line with one another while also addressing some corner cases that weren't previously tested.
2025-03-18 15:56:25 -04:00
Andy Feller
018b6d6d07
Initial pass fixing gh issue and gh pr comment
...
There is still a bit of work to get the gh pr comment tests in order, however this goes a way towards fixing the issue along with acceptance tests.
Also, it turns out some of the issue acceptance tests were really running `pr` tests.
2025-03-17 23:18:36 -04:00
Azeem Sajid
69fff52026
Inconsistent format of description of flags (starting with lowercase letter) ( #10507 )
2025-02-27 11:40:21 +01:00
latzskim
e516e5ed5d
[gh issue/pr comment] Create a comment if no comment already
2025-02-12 21:04:22 +01:00
Azeem Sajid
978d3fce87
[gh issue/pr list] Improve help text
2025-01-30 13:05:18 +05:00
Andy Feller
954d4d5dbc
Correct help documentation around template use in gh issue create
...
Relates #10202
While we figure out how to handle consistent experience using templates for creating issues and PRs, let's correct the help usage for issue template flag use as this is the issue template name, not filename.
2025-01-09 11:08:18 -05:00
Heath Stewart
5da86e07e7
Merge changes from #10004
...
Merges changes from @williammartin including acceptance tests and word changes.
Co-authored-by: William Martin <williammartin@github.com>
2024-12-08 20:34:21 -08:00
Heath Stewart
88b96f411c
Set gh-merge-base from issue develop
2024-12-08 17:40:03 -08:00
William Martin
6b7f1ff060
Allow client fetch to use insecure credentials pattern
2024-11-26 22:30:03 +01:00
William Martin
75712de712
Allow client pull to use insecure credential pattern
2024-11-26 22:29:51 +01:00
William Martin
46922694dc
Support secure credential pattern
2024-11-26 22:29:38 +01:00
Tyler McGoffin
da945314fd
Fix failing test for pr and issue create
2024-10-08 16:11:05 -07:00
Tyler McGoffin
be3b6cbd8d
Make the X in the error message red and print with io writer
2024-10-08 16:03:14 -07:00
crystalstall
5562c1489f
chore: fix some function names
...
Signed-off-by: crystalstall <crystalruby@qq.com>
2024-09-02 15:18:42 +08:00
Andy Feller
779a1203b6
Merge pull request #9471 from heaths/issue9470
...
Always print URL scheme to stdout
2024-08-21 14:46:52 -04:00
EBIBO
08aafc5484
Update pkg/cmd/issue/develop/develop.go
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2024-08-18 09:25:39 +08:00
benebsiny
e269d43c5a
add testing
2024-08-17 13:47:02 +08:00
benebsiny
216c283e03
Merge branch 'trunk' into cli-9496
2024-08-17 12:05:17 +08:00
benebsiny
56e1cdae9e
fix behavior for issue develop -b non-exist-branch
2024-08-17 12:04:09 +08:00
Heath Stewart
81f3526740
Fix tests
2024-08-16 10:11:52 -07:00
Andy Feller
a863dfdb30
Merge pull request #9433 from benebsiny/cli-9310
...
Add `pr create --editor`
2024-08-12 10:10:18 -04:00
Andy Feller
369a105c45
Minor grammatical fix
2024-08-12 10:00:37 -04:00
Tyler McGoffin
18d58b8d84
Replace --project.* flags' name with title in docs ( #9443 )
...
With the upcoming migration from v1 project to v2 projects, we'd like the
language in our documentation to align with v2 project language. In v2,
projects are referred to by `title` and not `name`, though they are
functionally equivalent under the hood for the CLI
2024-08-09 13:55:14 -07:00
benebsiny
e18c002283
Deduplicate the initialization of editor mode
2024-08-08 18:07:52 +08:00
Babak K. Shandiz
a73ae65ca8
Use closure-scoped variable to catch --remove-milestone option
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-29 21:40:24 +01:00
Babak K. Shandiz
4c8ec84e26
Improve --remove-milestone option description
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-28 15:23:19 +01:00
Babak K. Shandiz
6e34e81b76
Point to Editable.MilestoneId method
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-28 15:22:54 +01:00
Babak K. Shandiz
93621436e8
Merge branch 'trunk' into 9292-add-remove-milestone-option
2024-07-28 13:27:24 +01:00
William Martin
32e499e090
Add examples for template usage in PR and issue creation
2024-07-23 13:14:27 +02:00
Babak K. Shandiz
42da8baf70
Verify --milestone and --remove-milestone are not assignable at the same time
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-21 12:56:14 +01:00
Babak K. Shandiz
168a8832f0
Assert correct parsing of --remove-milestone option
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-21 12:55:47 +01:00
Babak K. Shandiz
683576d6bf
Add --remove-milestone option
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-21 12:54:23 +01:00
Babak K. Shandiz
9dabc3b8dd
Remove unused expected output from test case (with wantsErr: true)
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-21 12:53:15 +01:00
Babak K. Shandiz
17257df064
Verify --body and --body-file are not assignable at the same time
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-21 12:45:28 +01:00
Andy Feller
ae5a71bbe4
Merge branch 'trunk' into add-issue-create-editor
2024-07-15 15:21:03 -04:00
notomo
28cc56cd45
Raise error if editor is used in non-tty mode
2024-07-13 11:01:48 +09:00
William Martin
940b54c708
Add tests for JSON field support on issue and pr view commands
2024-07-12 17:35:54 +02:00
notomo
0b32e66bba
Enable to use --web even though editor is enabled by config
2024-07-09 21:01:51 +09:00
notomo
0d37174076
Add editor hint message
2024-07-09 21:01:50 +09:00
notomo
50d0cb7279
Use prefer_editor_prompt config by issue create
2024-07-09 21:01:50 +09:00
notomo
8f77b4a23f
Add issue create --editor
2024-07-09 21:01:50 +09:00
William Martin
1d38230675
Move config interfaces into gh package ( #9060 )
2024-05-10 10:39:36 +02:00
William Martin
5007c18f5f
Fix unused params across project
2024-05-07 17:50:43 +02:00
t4kamura
a6cccdf671
Add pr url pattern
2024-03-18 22:49:23 +09:00
t4kamura
2ea5f03b43
Test pr url lock
2024-03-18 22:49:07 +09:00
Andy Feller
bcdc917f08
Enhance 2nd round of issue and PR number output
2024-03-01 15:42:43 -05:00