Barak Amar
232c024987
Merge branch 'trunk' into trunk
2025-05-01 22:16:55 +03:00
Sinan Sonmez (Chaush)
0a1e7a1fdc
Add --delete-last option to pr comment and issue comment ( #10596 )
...
* deletion for issues with confirmation flag
* add handling for interaction case
* finish implementation for issues
* finish the implementation for issues
* finalize the implementation for PR
* fix missing --yes flag for PR
* address PR comments related to feedbacks
* improve CommentablePreRun for pre checks
* improve confirmation prompt and truncate long comment body
* address PR comments on tests
* Truncate comment for confirmation prompt
Signed-off-by: Babak K. Shandiz <babakks@github.com>
* Improve test case descriptions
Signed-off-by: Babak K. Shandiz <babakks@github.com>
* Fix mock comment body
Signed-off-by: Babak K. Shandiz <babakks@github.com>
* Remove irrelevant prompt stub
Signed-off-by: Babak K. Shandiz <babakks@github.com>
* Use `opts.Interactive` as TTY indicator
Signed-off-by: Babak K. Shandiz <babakks@github.com>
* Fix expected `Interactive` value
Signed-off-by: Babak K. Shandiz <babakks@github.com>
* Polish `TestNewCmdComment`
Signed-off-by: Babak K. Shandiz <babakks@github.com>
---------
Signed-off-by: Babak K. Shandiz <babakks@github.com>
Co-authored-by: Babak K. Shandiz <babakks@github.com>
2025-05-01 14:12:55 +01:00
Andy Feller
c20a4a2ae9
Merge pull request #10890 from cli/andyfeller/gh-accessibility-help-topic
...
Introduce `gh accessibility` help topic highlighting GitHub CLI accessibility experiences
2025-04-30 15:40:27 -04:00
Andy Feller
830335d920
PR feedback
2025-04-30 15:05:07 -04:00
Andy Feller
c20138d844
Update pkg/cmd/accessibility/accessibility.go
2025-04-30 14:35:35 -04:00
Andy Feller
2fd1a45a81
Update pkg/cmd/accessibility/accessibility.go
2025-04-30 14:21:02 -04:00
Andy Feller
096106a3d7
Apply suggestions from code review
...
Co-authored-by: Melissa Xie <mxie@users.noreply.github.com>
2025-04-30 14:20:16 -04:00
Barak Amar
a491578751
Merge branch 'trunk' into trunk
2025-04-29 14:33:21 +03:00
Barak Amar
692bdaf578
Apply code review changes
2025-04-29 14:32:51 +03:00
Azeem Sajid
9ed733fa5e
Add closingIssuesReferences JSON field to pr view ( #10544 )
...
* [gh pr view] Support `closingIssuesReferences` JSON field
* Support pagination
* Support pagination
* Fix typo
* Add more fields
2025-04-29 11:48:20 +01:00
Andy Feller
d7e2468286
Update a11y text based on draft feedback
2025-04-28 15:01:15 -04:00
Barak Amar
afba7b9e8b
Merge branch 'trunk' into trunk
2025-04-28 18:17:36 +03:00
William Martin
fb97b3efaa
Fix pr create when push.default tracking and no merge ref ( #10863 )
...
* Fix pr create when push.default tracking and no merge ref
* Update pkg/cmd/pr/shared/find_refs_resolution.go
---------
Co-authored-by: Tyler McGoffin <jtmcg@github.com>
2025-04-24 16:41:14 +00:00
Andy Feller
274a09bbc9
Initial gh accessibility command draft
...
This commit captures the initial command along with functionality and description.
There is an internal discussion about the appropriate place for some of this content.
2025-04-23 10:11:51 -04:00
Kynan Ware
5316f052d8
Merge branch 'trunk' into kw/accessible-prompter-and-disable-spinners-config
2025-04-23 07:30:54 -06:00
Kynan Ware
41f94502e3
Merge pull request #10817 from cli/kw/project-query-uses-iostreams-progress-indicator
...
Fix: `project` commands use shared progress indicator
2025-04-23 07:15:54 -06:00
William Martin
bdc0886492
Merge pull request #10819 from cli/wm/projectsv1-deprecation-issue-edit
...
Feature detect v1 projects on issue edit
2025-04-23 14:18:31 +02:00
William Martin
1a15212e4a
Merge pull request #10818 from cli/wm/projectsv1-deprecation-issue-create-web
...
Feature detect v1 projects on web mode issue create
2025-04-23 14:14:43 +02:00
William Martin
2f06fafd1b
Merge pull request #10815 from cli/wm-kw/projectsv1-deprecation-issue-create
...
Feature detect v1 projects on non web-mode `issue create`
2025-04-23 13:31:24 +02:00
Kynan Ware
138bccd437
feat(config): add accessible prompter and spinner
2025-04-22 16:50:58 -06:00
William Martin
636453059c
Merge pull request #10813 from cli/wm-kw/projectsv1-deprecation-issue-view
...
Feature detect v1 projects on `issue view`
2025-04-22 17:15:13 +02:00
Barak Amar
66527cf75c
Merge branch 'trunk' into trunk
2025-04-22 09:05:38 -04:00
William Martin
3fc362b279
Merge pull request #10811 from cli/wm/issue-pr-base-repo-resolution
...
Issue commands should parse args early
2025-04-22 15:02:14 +02:00
Barak Amar
36f0bf6b8b
Merge branch 'trunk' into trunk
2025-04-22 03:32:00 -04:00
Andy Feller
f61961907e
Update configuration support for accessible colors
...
- added support for `accessible_colors` configuration setting in `gh config` commandset
- updated default configuration file to contain `accessible_colors: disabled`
- add `GH_ACCESSIBLE_COLORS` env var to `gh environment`
- generated mocks via `go generate ./...` including previously missed prompter changes
2025-04-17 15:57:49 -04:00
William Martin
0aa49b7741
Feature detect v1 projects on issue edit
2025-04-17 21:19:41 +02:00
William Martin
c208b1f075
Feature detect v1 projects on web mode issue create
2025-04-17 21:04:08 +02:00
Kynan Ware
c08425aef1
fix(projects): use iostreams progress indicator
2025-04-17 11:06:27 -06:00
William Martin
c8dd61d837
Feature detect v1 projects on non-interactive issue create
2025-04-17 17:51:38 +02:00
Barak Amar
a1f5d42283
Update the test code to align with latest changes
2025-04-17 17:13:28 +03:00
Barak Amar
265139f268
Merge branch 'trunk' into trunk
2025-04-17 09:56:12 -04:00
William Martin
5ec2160bc6
Avoid requesting projectCards for issue view
2025-04-17 15:37:48 +02:00
William Martin
fff0e70259
Provide better HTTP Exclude failure messages
2025-04-17 15:37:42 +02:00
William Martin
55d3b1eaa4
Document TestArgParsing
2025-04-17 15:33:44 +02:00
William Martin
cfa90a2c80
Remove old issue lookup funcs
2025-04-17 15:27:40 +02:00
William Martin
81ecbd8e1d
Issue view early arg parsing
2025-04-17 15:27:40 +02:00
William Martin
e474acc2dd
Issue comment early arg parsing
2025-04-17 15:27:40 +02:00
William Martin
455c77add8
Issue unpin early arg parsing
2025-04-17 15:27:39 +02:00
William Martin
f55138c896
Issue transfer early arg parsing
2025-04-17 15:27:39 +02:00
William Martin
5c67c1944b
Issue reopen early arg parsing
2025-04-17 15:27:39 +02:00
William Martin
96699329fc
Issue pin early arg parsing
2025-04-17 15:27:39 +02:00
William Martin
60f248458c
Issue lock early arg parsing
2025-04-17 15:27:39 +02:00
William Martin
7744e0564f
Issue develop early arg parsing
2025-04-17 15:27:39 +02:00
William Martin
6129b26f9f
Issue delete early arg parsing
2025-04-17 15:27:39 +02:00
William Martin
8b615ec2e6
Issue close early arg parsing
2025-04-17 15:27:39 +02:00
William Martin
aaddcb019d
Issue edit early arg parsing
2025-04-17 15:27:39 +02:00
Andy Feller
0ef0c42665
Merge pull request #10767 from leudz/fix-9749
...
Fix multi pages search for gh search
2025-04-16 16:57:12 -04:00
Kynan Ware
bff4db1309
Merge pull request #10773 from cli/kw/opt-into-no-spinners
...
Introduce option to opt-out of spinners
2025-04-16 14:44:45 -06:00
leudz
4a885899d6
Add comments for Total
2025-04-16 20:46:29 +02:00
Andy Feller
ba390db71f
PR feedback
...
- update local variables to communicate what they are
- added docblock explaining search results populated
2025-04-16 14:22:29 -04:00
