Replace scattered standalone test functions with a single table-driven
TestNewCmdView covering all arg/flag parsing: number, hash, URL, web,
comments, replies, limit, after, order, mutual exclusivity, and invalid
inputs. Uses shlex.Split for arg parsing and asserts opts fields
individually per case.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add --replies <COMMENT-ID> flag to view paginated replies on a specific
discussion comment. Mutually exclusive with --comments and --web. Works
with --limit, --after, and --order for pagination control. Supports TTY,
raw, and JSON output modes.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fix two issues in the discussion view command:
1. GraphQL injection via cursor interpolation: The --after cursor value
was interpolated directly into the raw GraphQL query string using
fmt.Sprintf, which is unsafe since cursor values come from user input.
Now uses GraphQL variables ($cursor: String) instead, matching the
pattern used by issue list, pr list, and other commands.
2. Incomplete --json comments output: Running `gh discussion view N
--json comments` silently returned only totalCount with no comment
nodes, because the data fetch was gated solely on the --comments flag.
Now checks if the JSON exporter requests the comments field and
fetches full comment data accordingly, matching how issue view and
pr view drive data loading from exporter fields.
Also fixes example text that said "newest" but showed --order oldest.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add --limit and --after flags for paginating through discussion comments.
Cursor output is shown in TTY (hint message), raw (next: field), and JSON.
Change GetWithComments to accept 'after' cursor and 'newest' bool instead
of order string. Implement forward/backward cursor-based pagination in
GraphQL queries depending on comment order.
Change Replies from []DiscussionComment to DiscussionCommentList with
Direction field. Display direction-aware messages (newer/older) for both
comments and replies.
Move DiscussionFields and reactionGroupList from shared to view package.
Delete shared/display.go.
Add 7 new pagination tests and update existing test fixtures.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Implement the --comments flag for discussion view, showing threaded
comments with replies.
Features:
- --comments flag fetches and displays discussion comments
- --order flag (oldest/newest) controls comment ordering
- Answer badge (✓ Answer) on marked answer comments
- Threaded replies with indentation
- Truncation messages when more replies exist than fetched
- TTY: markdown-rendered comments with author/timestamp/reactions
- Non-TTY: stable tab-delimited format for scripting
- JSON: populated comment nodes via ExportData
Implementation:
- GetWithComments uses raw GraphQL to dynamically switch between
first/last based on ordering. Fetches 30 comments with 4 replies
each. Explicitly reverses for newest-first ordering.
- --order without --comments returns a flag error
- Reuses existing shared.ReactionGroupList for reaction display
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Rewrite GetByNumber to use strongly-typed GraphQL query instead of
removed raw string interpolation (discussionFields/discussionNode)
- Fix State string references to use Closed bool throughout view.go
- Fix DiscussionAuthor → DiscussionActor type rename in tests
- Add ReactionGroups field to Discussion domain type and ExportData
- Add computed "state" field to ExportData for JSON output
- Add shared.DiscussionFields for view command's --json flag
- Regenerate client mock
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Implement `gh discussion view` for viewing a single discussion with:
- Number or URL argument via shared.ParseDiscussionArg
- TTY output: title, metadata (state, category, author, age, comment
count), labels, markdown-rendered body, reactions
- Context-aware author attribution: "Asked by" for answerable
categories (Q&A), "Started by" for others
- Non-TTY output: key-value pairs matching `gh issue view` format
- JSON output via Exporter (Discussion.ExportData)
- --web flag to open in browser
- Pager support for TTY output
Also adds:
- GetByNumber client method with not-found detection
- shared.ParseDiscussionArg for number/URL/#number parsing
- shared.ReactionGroupList for emoji reaction display
Comment threading (--comments) is deferred to the next PR.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
