Commit graph

21 commits

Author SHA1 Message Date
vilmibm
245c3c7425 move survey helper and test helpers to prompt pkg 2020-07-27 17:00:09 -05:00
vilmibm
1137e40a1f use colorableErr 2020-07-21 11:46:51 -05:00
vilmibm
168bd33bc9 pr command scriptability improvements
This commit improves behavior and error handling for pr commands when
run unattached to a tty.

- error if pr create and no -t/-f
- error if pr create and -w
- machine readable pr list
- machine readable pr view
- various cleanup of informational messages
2020-07-20 13:04:17 -05:00
Mislav Marohnić
0dfc0f733f Fix indentation of Example blocks
In HTML, `Example` blocks seem to be already injected in fenced Markdown
blocks `` ``` ``, so they don't need to be especially intented.
2020-06-11 20:31:37 +02:00
Mislav Marohnić
e6a0c3dc28 Fix EXAMPLES sections of various commands
- Code should be intented per Markdown syntax for a code block. This
  matters when this documentation is rendered to HTML

- Fix some innaccurate usage examples

- Tweak wording, formatting in a few places
2020-06-11 18:47:57 +02:00
gedenata
cfaedd4c71 redundant type slice-string 2020-06-11 07:32:09 +08:00
Corey Johnson
ee2b38df68
Merge pull request #1020 from cli/pr-lookup-v2
Consistent PR lookup interface
2020-06-04 10:42:55 -07:00
Corey Johnson
4c75c8bccc Reset base branch when URL is used 2020-06-03 14:34:13 -07:00
Oscar Dominguez
dfdb5ee75d 📚 docs(typo): fix typo in gh pr review command 2020-05-31 12:10:47 +02:00
Corey Johnson
15770881bb Use an array 2020-05-27 10:08:29 -07:00
Corey Johnson
e341d7b49f Fix test 2020-05-27 08:38:30 -07:00
Corey Johnson
8d1f2745a4 wip 2020-05-26 16:35:35 -07:00
vilmibm
c8c807b954 pass apiClient to determineBaseRepo
Our code had an unspoken assumption that only one apiClient is created
during the course of a command. Violating this assumption is fine in
almost all cases, but not when we need to do a re-auth to add a new
oauth scope to a user's token.

There is likely a more elegant solution to the problem but until then
this changes determineBaseRepo to use an existing apiClient.
2020-05-15 15:29:33 -05:00
vilmibm
79ad1ed5d3 tyop fix + stricter switch 2020-05-11 17:39:52 -05:00
vilmibm
7009321314 review feedback 2020-05-11 17:06:18 -05:00
vilmibm
c8e9768bf5 slopwip on interactive review 2020-05-11 15:28:12 -05:00
vilmibm
9f0a19911a de-register review until it's ready to ship 2020-05-11 12:04:05 -05:00
vilmibm
6538cca693 switch to using body flag. small TODOs 2020-05-08 10:07:20 -05:00
vilmibm
8a5290d2b4 clarify error msg 2020-05-07 14:51:08 -05:00
vilmibm
5dbec25f44 handle pr for branch case 2020-05-07 14:27:33 -05:00
vilmibm
d81e622700 lightest weight reviewing
this commit add very basic non-interactive PR reviewing. You can either
review the "current" or a passed PR (number or URL) as approved, changes
requested, or commented via CLI flags.
2020-05-07 13:30:34 -05:00