Commit graph

2061 commits

Author SHA1 Message Date
Corey Johnson
96e3d79f5e add "try again" text 2020-05-19 13:39:31 -07:00
Mark Furland
dffb55889c install manpages for homebrew 2020-05-19 15:58:27 -04:00
Nate Smith
45dec1b3e0
Merge pull request #962 from cli/pr-diff
pr diff
2020-05-19 14:11:36 -05:00
vilmibm
983a1d9c3c better names 2020-05-19 14:08:20 -05:00
Corey Johnson
e0dbf37b5a
Merge pull request #960 from cli/prêt-à-réviser
Add `gh pr ready`
2020-05-19 11:29:33 -07:00
Corey Johnson
6666adbdce Deal with merge conflicts 2020-05-19 11:29:00 -07:00
Corey Johnson
d209c0be01 Allow pr urls 2020-05-19 11:04:43 -07:00
vilmibm
c98b0924dc properly handle REST errors 2020-05-19 11:58:49 -05:00
Mark Furland
e13fc2465f use consistent var declaration format 2020-05-19 12:21:20 -04:00
Nate Smith
06e43ac881
Merge pull request #964 from dulltz/cosmetic-short
Cosmetic about short descriptions
2020-05-19 00:10:24 -05:00
dulltz
821324c2fb cosmetic
- Align the first letter to uppercase.
- Align with no period at the end.
2020-05-19 12:03:56 +09:00
Nate Smith
d1bdb31558
Merge pull request #958 from cli/ci-git-id
fix and tweak for site build
2020-05-18 17:47:35 -05:00
vilmibm
ccda5ced51 lint 2020-05-18 17:45:47 -05:00
vilmibm
51b4212070 add basic tests 2020-05-18 17:39:54 -05:00
vilmibm
8e6b8d3901 cleanup 2020-05-18 17:23:36 -05:00
vilmibm
c159d41fc2 manually colorize 2020-05-18 17:15:48 -05:00
vilmibm
aaebdfc46f working with gross colorize hack + no pager 2020-05-18 16:49:51 -05:00
Corey Johnson
fde5409a70
Update command/pr_test.go
Co-authored-by: Billy Griffin <5091167+billygriffin@users.noreply.github.com>
2020-05-18 14:40:04 -07:00
Corey Johnson
be927b34ae
Update command/pr_test.go
Co-authored-by: Billy Griffin <5091167+billygriffin@users.noreply.github.com>
2020-05-18 14:39:52 -07:00
Corey Johnson
6eab3751d0
Update command/pr.go
Co-authored-by: Billy Griffin <5091167+billygriffin@users.noreply.github.com>
2020-05-18 14:39:43 -07:00
Corey Johnson
9721f75b2b
Update command/pr.go
Co-authored-by: Billy Griffin <5091167+billygriffin@users.noreply.github.com>
2020-05-18 14:39:29 -07:00
vilmibm
b94860bae7 add command file with pr resolution 2020-05-18 15:43:27 -05:00
Corey Johnson
b42f5527fd Remove hot dog 2020-05-18 13:27:23 -07:00
vilmibm
14e8498b90 fix path 2020-05-18 15:14:10 -05:00
Corey Johnson
78bc7260e0 Add closed test 2020-05-18 13:08:57 -07:00
vilmibm
d2bdd53dd2 depend on bin/gh 2020-05-18 15:08:31 -05:00
vilmibm
d800e3f0b6 rely on environment 2020-05-18 15:07:28 -05:00
Corey Johnson
0b0070e725 Add "already marked" test 2020-05-18 13:03:43 -07:00
Corey Johnson
922b6e06e0 Can be marked ready for review 2020-05-18 12:42:16 -07:00
Nate Smith
b904ed6556
Merge pull request #955 from vilmibm/skipfix
reenable skipping body prompt for pr/issue
2020-05-18 14:23:24 -05:00
vilmibm
da95cbd1bf use gh if available when cloning site 2020-05-18 14:05:50 -05:00
vilmibm
296062b869 configure author on site commits 2020-05-18 14:01:35 -05:00
Corey Johnson
fad9f24f39 Make reopen work 2020-05-18 11:11:13 -07:00
Corey Johnson
350b4c85c0 Add failing test 2020-05-18 11:11:02 -07:00
vilmibm
01f272dead give our pr template a name 2020-05-18 11:44:21 -05:00
vilmibm
228d01a037 reenable skipping body prompt for pr/issue 2020-05-18 10:23:20 -05:00
Mislav Marohnić
4d11732a47
Merge pull request #943 from cli/reauth-bug
pass apiClient to determineBaseRepo
2020-05-18 13:16:07 +02:00
Kevin Bluer
d440a95aed
Improved error message when "owner/repo" format not provided (#919)
Fixes #882
2020-05-18 11:13:48 +02:00
AliabbasMerchant
6effcd4261 Allow choosing a blank issue/pr template 2020-05-18 00:37:28 +05:30
vilmibm
780875d645 fix tests 2020-05-15 16:47:11 -05:00
vilmibm
96ba1eacef undo initial thing 2020-05-15 16:44:51 -05:00
vilmibm
bf05975ceb Revert "small repo fix"
This reverts commit 08e9cdaee1.
2020-05-15 16:40:47 -05:00
vilmibm
7decae71fc untested first pass on ensureScopes 2020-05-15 16:40:13 -05:00
vilmibm
c8c807b954 pass apiClient to determineBaseRepo
Our code had an unspoken assumption that only one apiClient is created
during the course of a command. Violating this assumption is fine in
almost all cases, but not when we need to do a re-auth to add a new
oauth scope to a user's token.

There is likely a more elegant solution to the problem but until then
this changes determineBaseRepo to use an existing apiClient.
2020-05-15 15:29:33 -05:00
Corey Johnson
ea164a8d48 Fix test 2020-05-15 10:52:26 -07:00
Corey Johnson
90664792b6 Fix message 2020-05-15 10:42:58 -07:00
Corey Johnson
c645fd5ae5 Better errors around branch deletion 2020-05-15 10:33:54 -07:00
Corey Johnson
848dd44443 Delete branch of PR, not the current branch 2020-05-15 08:51:37 -07:00
Corey Johnson
feca9f6eaf Add convertRepoInterfaceToRepository 2020-05-15 08:51:10 -07:00
vilmibm
08e9cdaee1 small repo fix 2020-05-15 10:25:40 -05:00