Mislav Marohnić
0a4d4ee007
Replace FakeHTTP with httpmock which is now compatible
2020-05-07 15:19:14 +02:00
Mislav Marohnić
256d31950a
Migrate a single test over to httpmock to demonstrate its use
2020-05-06 22:06:37 +02:00
Mislav Marohnić
1d4065e4c4
Add a HTTP mocking interface that matches incoming requests
...
This adds a thread-safe RoundTripper that can be used for mocking HTTP
requests in tests. Incoming requests are matched based on their
contents, not the order the stubs were registered in.
2020-05-06 22:03:32 +02:00
Corey Johnson
3d21a33bac
update test
2020-05-06 11:47:43 -07:00
Corey Johnson
1de57db74d
Fix lint error
2020-05-06 11:27:41 -07:00
Corey Johnson
5a04679535
Remove debug output
2020-05-06 11:21:05 -07:00
Corey Johnson
8c85e14bac
Make it work without a PR number
2020-05-06 11:19:00 -07:00
Mislav Marohnić
4ef468c19a
Merge branch 'codeql'
2020-05-06 10:21:55 +02:00
Mislav Marohnić
c62c00761e
Tweak CodeQL workflow
2020-05-06 10:16:08 +02:00
Corey Johnson
062c8353eb
Add 'already merged' test
2020-05-05 15:11:06 -07:00
Corey Johnson
8681e7a7b6
Make squash and rebase work
2020-05-05 15:09:02 -07:00
Justin Hutchings
e0071329f5
Remove strategy, remove autobuild
2020-05-05 13:45:06 -07:00
Corey Johnson
c0831d4c4f
Add merge api call
2020-05-05 11:56:45 -07:00
Corey Johnson
0aca0eff1f
Add merge code
2020-05-05 11:35:27 -07:00
Corey Johnson
16ad382f4d
Add simple merge test
2020-05-05 11:35:19 -07:00
Corey Johnson
cb8d9963e3
Add note for variable naming
2020-05-05 09:55:27 -07:00
Corey Johnson
4e548880d5
don't use camel case
2020-05-05 09:52:50 -07:00
Corey Johnson
7d1910d945
Use "a value"
2020-05-05 09:52:36 -07:00
Corey Johnson
39e6f412cb
Merge pull request #856 from cli/a-better-runcommand
...
RFC: Make `RunCommand` less brittle
2020-05-05 09:40:51 -07:00
Corey Johnson
8c9fdc768c
Merge remote-tracking branch 'origin' into a-better-runcommand
2020-05-05 09:30:32 -07:00
Corey Johnson
4ef73a723d
Update all calls to RunCommand
2020-05-05 09:20:01 -07:00
Nikola Ristic
1f9b7c0fe0
Disable interactive only if both flags are passed
...
Co-authored-by: Mislav Marohnić <mislav@github.com>
2020-05-05 16:34:31 +02:00
Mislav Marohnić
1834d8cfd5
Tweak syntax in issue/pr close docs
...
This makes it consistent with other subcommands under `issue/pr`.
2020-05-05 13:32:42 +02:00
Nate Smith
1a1fc64fe4
Merge pull request #842 from foad/df-805-hide-closed-default
...
Hide closed/merged PRs from default branch
2020-05-04 20:17:53 -05:00
Justin Hutchings
0a86be0ba7
Rename .github/workflows/workflows/codeql.yml to .github/workflows/codeql.yml
2020-05-04 17:49:39 -07:00
Daniel Foad
e7e3a4f9b1
pr comments
2020-05-04 23:47:47 +01:00
vilmibm
f427d252d0
whitespace
2020-05-04 15:48:00 -05:00
vilmibm
1aab2084f1
cute command to show a thank you to contributors
...
this commit is the result of April's hack day. it animates a thank you
for a project's contributors.
it only really works on linux/mac; animation woes led me to just make it
static and plain on windows.
2020-05-04 15:42:41 -05:00
Corey Johnson
1694ea29b4
Update text
2020-05-04 11:57:05 -07:00
Corey Johnson
2f8d3a0247
Add doc
2020-05-04 11:52:09 -07:00
Corey Johnson
e172f31c80
Merge pull request #854 from cli/close-a-pull-request
...
Add `gh pr close <numberOrURL>`
2020-05-04 10:55:53 -07:00
Corey Johnson
fef11b3489
Merged prs return error
2020-05-04 10:44:20 -07:00
Corey Johnson
3b8f4794b4
Update test
2020-05-04 10:31:31 -07:00
Corey Johnson
2f075fca73
Return an error if the pr was already merged
2020-05-04 10:25:38 -07:00
Corey Johnson
5cc60c669e
Take in a pointer
2020-05-04 10:19:54 -07:00
Corey Johnson
1e88226b2b
Add space
2020-05-04 10:16:30 -07:00
Corey Johnson
083693bc05
Update usage string
2020-05-04 10:15:47 -07:00
Corey Johnson
f7be93b135
use less words
2020-05-04 10:11:24 -07:00
Corey Johnson
1ee31db033
Add "merged" message
2020-05-04 10:10:03 -07:00
Mislav Marohnić
0bf4f16fd5
Merge branch 'issue-pr-create-metadata' into issue-pr-create-metadata-wizard
2020-05-04 17:10:06 +02:00
Mislav Marohnić
b59407dd7d
Merge remote-tracking branch 'origin/master' into issue-pr-create-metadata
2020-05-04 17:09:41 +02:00
Mislav Marohnić
2089b15e6a
Fix pagination when fetching metadata
2020-05-04 17:09:11 +02:00
Corey Johnson
4020084f02
Fix test
2020-05-01 14:54:38 -07:00
Corey Johnson
fad697cbaf
Names
2020-05-01 14:18:01 -07:00
Corey Johnson
846425fe5e
simplified boolean comparison
2020-05-01 14:16:49 -07:00
Corey Johnson
922352753a
Add merged exit
2020-05-01 14:08:30 -07:00
Corey Johnson
63b20baa1b
Add merged test
2020-05-01 13:58:52 -07:00
Corey Johnson
b8ff489bb5
Add already open test
2020-05-01 12:07:30 -07:00
Corey Johnson
bc623a7a23
Make it green
2020-05-01 12:07:23 -07:00
Corey Johnson
0bb1d2018a
Add code to reopen
2020-05-01 12:00:13 -07:00