Commit graph

3986 commits

Author SHA1 Message Date
chemotaxis
558ff2dff0 Skip authentication message if asking for help
Currently, this still checks authentication, but we skip the
authentication message and exit normally.
2021-06-16 14:25:08 -04:00
Gowtham Munukutla
3c8e163e8b resolve PR comments. Tests WIP 2021-06-16 12:50:05 +05:30
chemotaxis
c903f1ecd0 Ask for and print help even if logged out
You have to explicitly ask for help using the help flags.  Otherwise,
`gh` will just print the authentication message.
2021-06-16 01:18:52 -04:00
Gowtham Munukutla
7c8b6867f4 Merge branch 'trunk' of https://github.com/cli/cli into feature/repo-with-gitignore-license 2021-06-16 09:27:53 +05:30
jlsestak
0a801c1ed5
Merge pull request #51 from bchadwic/trunk
Fixed parseFileArgs, reformatted tests
2021-06-15 20:14:44 -07:00
jlsestak
c8152ed9b1
Merge pull request #50 from jlsestak/trunk
Changed parsefileArg to return a string, reformatted testing, polishe…
2021-06-15 20:12:23 -07:00
Jessica Sestak
b64488fe5c Changed parsefileArg to return a string, reformatted testing, polished up browse.go 2021-06-15 20:10:48 -07:00
Mislav Marohnić
dd3aac7f52
Merge pull request #3846 from cli/build-windows-fix
Improvements to build script on Windows
2021-06-15 18:52:03 +02:00
Sam
741f768a28
Merge pull request #3792 from chemotaxis/docs-install-via-conda
Document installing via Conda package manager
2021-06-15 12:19:24 -04:00
Sam
d299b74a37
Merge pull request #3841 from cli/factory-cleanup
Factory cleanup
2021-06-15 12:10:36 -04:00
Mislav Marohnić
bd01566251 Allow script\build as shorthand for go run script\build.go on Windows 2021-06-15 17:33:33 +02:00
Mislav Marohnić
32f9a462a8 Speed up build script by avoiding recursing into 3rd-party directories 2021-06-15 17:32:43 +02:00
Mislav Marohnić
cda406f495 Better error handling in build script on Windows
`script/build.go` could encounter an "Access is denied" error when the
project contains a symlink that could not be followed. This ignores such
errors with a warning and allows the build to resume.
2021-06-15 17:31:01 +02:00
Mislav Marohnić
543a17df7f
Merge pull request #3787 from cli/editor-tests
Allow explicitly empty body in issue/pr create
2021-06-15 16:16:59 +02:00
Sam Coe
edfac42384
Set up iostreams in factory default 2021-06-15 09:20:00 -04:00
Sam Coe
53fac59ef9
Cleanup factory/default and add tests 2021-06-15 09:19:16 -04:00
Sam
e380d68ed2
Merge pull request #3789 from cristiand391/increase-gh-pager-precedence
Increase `GH_PAGER` precedence
2021-06-15 09:18:57 -04:00
Benjamin Chadwick
3d97aaf7f4
Merge pull request #49 from bchadwic/trunk
Fixed pr issues
2021-06-14 22:37:21 -07:00
bchadwic
679d396c8d reformatted spacing and final touches 2021-06-14 22:31:29 -07:00
Husrav Homidov
cac372d017
Merge pull request #48 from ravocean/trunk
Refactored browse.go
2021-06-14 22:19:01 -07:00
ravocean
21691c8d2e Reorganized tests 2021-06-14 22:16:58 -07:00
ravocean
79da79fb68 We added new tests to bring the coverage to 90%+ 2021-06-14 21:40:52 -07:00
Cristian Dominguez
d68a2038b6 add test case 2021-06-14 22:01:35 -03:00
jlsestak
707897ffb6
Deleted extra space 2021-06-14 08:29:22 -07:00
Mislav Marohnić
5984cf2a82
Merge pull request #3832 from cli/env-set-fix
Fix setting environment secrets
2021-06-14 16:17:24 +02:00
Mislav Marohnić
f7a786407d
Merge pull request #3834 from cristiand391/remove-unused-method
Remove unused method from `httpmock` package
2021-06-14 15:40:20 +02:00
Cristian Dominguez
d8ce615252 Remove unused method from httpmock package 2021-06-14 09:39:14 -03:00
Mislav Marohnić
3a7ce3a440 Fix setting environment secrets
This uses the correct public key when setting environment secrets.
https://docs.github.com/en/rest/reference/actions#get-an-environment-public-key
2021-06-14 11:51:20 +02:00
Mislav Marohnić
1f4bd80c56 Fix test flaky due to race in showing/hiding cursor
https://github.com/cli/cli/pull/3787/checks?check_run_id=2793254411
2021-06-14 10:58:53 +02:00
Benjamin Chadwick
6eed0ded39
Merge pull request #47 from bchadwic/trunk
Updated browse tests for Test_runBrowse and TestNewCmdBrowse
2021-06-13 21:36:03 -07:00
bchadwic
b08a6d2bd0 Merge branch 'trunk' of https://github.com/bchadwic/cli into trunk 2021-06-13 21:29:57 -07:00
bchadwic
69ac4fc1db reverted files 2021-06-13 21:29:45 -07:00
Benjamin Chadwick
d8cf76e193
Delete build.exe 2021-06-13 21:23:23 -07:00
bchadwic
9c7a788193 created more tests, and removed repoFlag 2021-06-13 21:05:50 -07:00
jlsestak
d3efc5dcbd
Merge pull request #46 from jlsestak/trunk
Fixed TestNewCmdBrowse and added more tests
2021-06-13 20:17:03 -07:00
Jessica Sestak
7ea9d9164a Fixed TestNewCmdBrowse and added more tests 2021-06-13 20:16:19 -07:00
jlsestak
05511c1ca6
Merge pull request #45 from jlsestak/trunk
Made more runBrowse tests
2021-06-12 22:38:07 -07:00
Jessica Sestak
edef757c6c Made more runBrowse tests 2021-06-12 22:36:03 -07:00
bchadwic
2b42ab92c3 refactored browse.go 2021-06-12 21:58:29 -07:00
Benjamin Chadwick
5f64243eb6
Merge pull request #44 from bchadwic/first-browse-pull
Restructured test file and discussed the structure of browse.go
2021-06-12 21:02:10 -07:00
camille folch
568f4e4ee0
Minor refactoring for readability in NewCmdFork's runE 2021-06-11 23:28:41 -03:00
camille folch
54b86c7093
repo fork: check that --org is not the empty string
As it is already being done for --remote-name, except in this case
the default is the empty string.
2021-06-11 23:28:41 -03:00
Mislav Marohnić
7999a457ad Separate out NewCmdBrowse tests from runBrowse tests
Co-authored-by: Benjamin Chadwick <benchadwick87@gmail.com>
Co-authored-by: Jessica Sestak <jlsestak@gmail.com>
2021-06-11 18:53:34 +02:00
Nate Smith
aecfc01e69
Merge pull request #3809 from cli/fork-test-cleanup
fork tests cleanup
2021-06-11 11:31:33 -05:00
Benjamin Chadwick
14a1f63f78
Merge pull request #43 from bchadwic/trunk
Fixing issues in the pr
2021-06-11 08:04:09 -07:00
Mislav Marohnić
af90f72493
Merge pull request #3803 from cli/http-accept-header
Update "Accept" header for github.com requests
2021-06-11 14:38:52 +02:00
Mislav Marohnić
4debbb17cd Further separate out test cases 2021-06-11 14:32:08 +02:00
Mislav Marohnić
7dbaaf2eb7
Merge pull request #3804 from cli/pr-status-checks
Fix showing Checks information in `pr status`
2021-06-11 14:18:50 +02:00
bchadwic
88ec5ad3b2 Fixing issues in the pr 2021-06-10 21:14:10 -07:00
Nate Smith
b0998772ae more cleanup 2021-06-10 21:46:02 +00:00