Commit graph

7424 commits

Author SHA1 Message Date
Nate Smith
67c4d5cdc0 Merge pull request #183 from github/draft-code-of-conduct
Add code-of-conduct.md
2019-12-19 14:59:23 -06:00
Lee Reilly
1b6ca046e5 Add first draft of CODE-OF-CONDUCT.md 2019-12-19 12:40:03 -08:00
Lee Reilly
6bc6ca6c8e Add first draft of SECURITY.md 2019-12-19 12:33:45 -08:00
Corey Johnson
314a82a7a8 Destructure correctly 2019-12-19 12:00:06 -08:00
Corey Johnson
dd1651af21 Send sha 2019-12-19 11:54:50 -08:00
Corey Johnson
ed1bcd2d21 Change changelog 2019-12-19 11:14:19 -08:00
Mislav Marohnić
f46380550c Merge pull request #171 from github/repo-language
Clarify repo flag language
2019-12-19 18:57:11 +01:00
Mislav Marohnić
f39d57862d Clarify -R format 2019-12-19 18:55:31 +01:00
Mislav Marohnić
3346e7b8dc Print pr status numbers in green
We use green to signify "open" state of issues & PRs in `list` commands
(as opposed to red for "closed" and purple for "merged" state), so let's
be consistent in `status` commands too, where all displayed items are
guaranteed to be open.
2019-12-19 17:50:44 +01:00
Mislav Marohnić
9ddd50ffa9 Add tests for pr status reviews and checks output 2019-12-19 17:37:57 +01:00
Mislav Marohnić
fd1da2f0f0 Add test for pr status blank slate 2019-12-19 16:54:24 +01:00
Mislav Marohnić
bd9b3b9bb5 Add tests for issue status/list/create on repos with issues disabled 2019-12-19 15:54:08 +01:00
Mislav Marohnić
aeb7f337d2 Ensure issue create fails fast if issues are disabled
Before, a person would be prompted for title & body before
unconditionally failing due to issues being disabled.
2019-12-19 15:44:20 +01:00
Mislav Marohnić
66534e504b Warn about repo issues disabled on issue create 2019-12-19 15:44:20 +01:00
Mislav Marohnić
915dd8b0ef Warn about repo issues disabled on issue status/list 2019-12-19 15:44:20 +01:00
Mislav Marohnić
d9ca764ac2 Look up the repository only once in issue status GraphQL 2019-12-19 15:44:20 +01:00
Mislav Marohnić
d5ba3de751 Add template support to issue create, pr create
If multiple templates are found, the user is prompted to select one.

The templates are searched for, in order of preference:

- issues:
  1. `.github/ISSUE_TEMPLATE/*.md`
  2. `.github/ISSUE_TEMPLATE.md`
  3. `ISSUE_TEMPLATE/*.md`
  4. `ISSUE_TEMPLATE.md`
  5. `docs/ISSUE_TEMPLATE/*.md`
  6. `docs/ISSUE_TEMPLATE.md`

- pull requests:
  1. `.github/PULL_REQUEST_TEMPLATE/*.md`
  2. `.github/PULL_REQUEST_TEMPLATE.md`
  3. `PULL_REQUEST_TEMPLATE/*.md`
  4. `PULL_REQUEST_TEMPLATE.md`
  5. `docs/PULL_REQUEST_TEMPLATE/*.md`
  6. `docs/PULL_REQUEST_TEMPLATE.md`

The filename matches are case-insensitive.
2019-12-18 22:15:20 +01:00
Corey Johnson
0918b20413 Compile 2019-12-18 11:24:57 -08:00
Corey Johnson
83bf7df765 Get content 2019-12-18 09:21:55 -08:00
Corey Johnson
5c4a5ec6db Fix space 2019-12-17 16:20:38 -08:00
Corey Johnson
4e61c3ea73 Fix syntax 2019-12-17 16:19:30 -08:00
Corey Johnson
101bcc6ecd Add checkout 2019-12-17 16:16:27 -08:00
Corey Johnson
c9d8600107 Run correct file 2019-12-17 16:12:01 -08:00
Corey Johnson
c8374ecc7f Add build 2019-12-17 16:03:06 -08:00
Corey Johnson
33bad4098a Add change log 2019-12-17 14:37:41 -08:00
Amanda Pinsker
de814595f5 Clarify repo flag language 2019-12-17 11:22:41 -05:00
Nate Smith
ea91d0d4b9 Merge pull request #170 from github/git-branch
Simplify reading current branch from git
2019-12-17 09:33:03 -06:00
Nate Smith
9454bd61ee Merge pull request #164 from github/site-docs-fix
Improve `site-docs` make task
2019-12-17 09:27:30 -06:00
Mislav Marohnić
f0801b2deb Simplify reading current branch from git 2019-12-17 14:45:24 +01:00
Mislav Marohnić
2c1fc56967 Update output expectations 2019-12-17 13:01:45 +01:00
Mislav Marohnić
7b7c985e79 Merge remote-tracking branch 'origin/master' into appropriate-context-and-feedback 2019-12-17 13:00:10 +01:00
Mislav Marohnić
2c94616969 Merge pull request #161 from github/stderr-tests
Assert stdout separarely from stderr in command tests
2019-12-17 12:43:09 +01:00
Mislav Marohnić
4ad89829c5 Merge remote-tracking branch 'origin/master' into stderr-tests 2019-12-17 12:42:01 +01:00
Corey Johnson
63f35f6834 goodbye migration 2019-12-16 15:56:45 -08:00
Corey Johnson
1b25aa7369 Merge pull request #156 from github/one-place-for-config-dir
Consolidate references to the config dir
2019-12-16 14:50:37 -08:00
Corey Johnson
91267a65fa Fix tests 2019-12-16 13:18:16 -08:00
Corey Johnson
6d0f4e7a90 Add more text 2019-12-16 11:41:56 -08:00
Corey Johnson
2b53172ebe Add line for pr create 2019-12-16 10:54:22 -08:00
Nate Smith
fcf00bd870 Merge pull request #163 from github/release-date
Simplify date format in gh version information
2019-12-16 10:54:15 -06:00
Nate Smith
00da5c2788 Merge pull request #158 from github/issue-create-web
Add "Opening URL in your browser" notice to `issue create --web`
2019-12-16 10:53:31 -06:00
Nate Smith
82fbbb28e8 Merge pull request #162 from github/gh-help-lines
Avoid long first line of gh help
2019-12-16 10:53:00 -06:00
Nate Smith
3dcadd73bd Merge pull request #159 from github/no-issues-assigned-notice
Fix displaying "There are no issues assigned to you" notice
2019-12-16 10:35:58 -06:00
Nate Smith
5434bf47ab Merge pull request #160 from github/win-test
Fix test on Windows
2019-12-16 09:51:44 -06:00
Mislav Marohnić
a7f59bfb15 Improve site-docs make task
This ensures that upstream changes to the `gh-pages` branches are pulled
before trying to upload new site docs.
2019-12-16 15:59:46 +01:00
Mislav Marohnić
1d9ad0001b Simplify date format in gh version information
Currently, goreleaser injects the date that includes time & timezone
information, but this is visually noisy. This configures it to inject
the simpler `2019-12-16` date format into the build, which also matches
what our Makefile does in development.
2019-12-16 15:56:45 +01:00
Mislav Marohnić
030c997301 Avoid long first line of gh help
This splits help text over paragraphs and lines to make the output of
`gh` easier to read. It takes care not to go over 80 characters in width
and wraps the URL in `<...>` which will help the URL get auto-linked
when these docs are converted to man and HTML formats.
2019-12-16 15:55:21 +01:00
Mislav Marohnić
48aeff1ca7 Assert stdout separarely from stderr in command tests
This stubs stderr separately from stdout in command tests (before those
streams were combined) and improves test assertions around output.

Additionally, no longer use the `cmd.Print*()` family of Cobra functions
because their name sounds like the text will go to stdout, but they
write to stderr instead. Use the more explicit `cmd.ErrOrStderr()` as
output destination instead.
2019-12-16 15:46:42 +01:00
Mislav Marohnić
d7513ef3f6 Fix test assertion when running on Windows 2019-12-16 14:56:44 +01:00
Mislav Marohnić
57c7266328 Fix displaying "There are no issues assigned to you" notice 2019-12-16 14:08:55 +01:00
Mislav Marohnić
5d6b095f1a Add "Opening URL in your browser" notice to issue create --web 2019-12-16 13:39:22 +01:00