STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
2256 commits 87 branches 0 tags 160 MiB
Commit graph

2256 commits

This branch
This branch
All branches
Author SHA1 Message Date
Mislav Marohnić
2bb5e052d8 Send GITHUB_TOKEN to github.com and GITHUB_ENTERPRISE_TOKEN to GHES 2020-09-04 17:25:37 +02:00
Mislav Marohnić
3e7a2585c5 Tighten git remote URL parsing 
We now only support git URLs that have one of the explicitly supported protocols.
 2020-09-04 16:18:26 +02:00
Mislav Marohnić
abf83c02c0
Merge pull request #1606 from cli/ghe-oauth-422-response 
Handle HTTP 422 response to OAuth Device flow detection
 2020-09-02 13:12:11 +02:00
Nate Smith
bf9d3ab12f
Merge pull request #1607 from cli/pwsh-tty 
properly check for tty when in powershell
 2020-09-01 16:16:31 -05:00
nate smith
49ab3ec5bf check for tty before creating colorables 2020-09-01 11:18:34 -05:00
Nate Smith
734959c39d
Merge pull request #1603 from cli/create-pr-metadata-failure 
Be transparent about which part of `pr create` flow failed
 2020-09-01 10:51:55 -05:00
Mislav Marohnić
48a827ee34 Tweak gh config set -h output format on auth login 2020-09-01 13:19:30 +02:00
Mislav Marohnić
0de3f678bc Only validate --hostname when flag was provided 2020-09-01 13:19:19 +02:00
Mislav Marohnić
b029397d32 Validate the --hostname flag value 2020-09-01 13:06:13 +02:00
Mislav Marohnić
1a051e9c44 Validate hostname as entered in the auth prompt 2020-09-01 12:59:58 +02:00
Mislav Marohnić
a8b06c329b Ensure correct ANSI color output during OAuth flow on Windows 
We used to write directly to `os.Stderr`, but we first need to convert
that into a colorable stream.
 2020-09-01 12:31:36 +02:00
Mislav Marohnić
cb4cc72e50 Handle HTTP 422 response to OAuth Device flow detection 
If HTTP 422 is encountered, assume that OAuth Device Flow is unavailable
and fall back to OAuth app authorization flow.
 2020-08-31 22:26:04 +02:00
Mislav Marohnić
766e4950d9 Be transparent about which part of pr create flow failed 
When applying metadata to the new PR such as assignees or reviewers, if
the operation fails, an error message would get printed:

    failed to create pull request: <API error text>

This was misleading, because the PR did get created; it's just that
updating it failed. The new error message is:

    https://github.com/OWNER/REPO/pull/123
    pull request update failed: <API error text>

The PR URL is printed on stdout and the error message is printed on
stderr. In case of any errors, the exit code is still non-zero.
 2020-08-31 16:46:22 +02:00
Nate Smith
fd31007075
Merge pull request #1590 from colinshum/colinshum/template-repo 
[Feature] Create repositories from a template repo
 2020-08-28 14:09:12 -05:00
Colin Shum
99372f0dbc [Refactor] Add variadic argument to repoCreate to support templates 2020-08-28 15:02:08 -04:00
Nate Smith
bb65ca0635
Merge pull request #1596 from cli/go-version-requirements 
Clarify our Go version requirements
 2020-08-28 13:14:12 -05:00
Mislav Marohnić
176dd29c05 Clarify our Go version requirements 
* We are trying to keep the binary building on Go 1.13 to support building the project on Ubuntu 20.04 LTS
* Go 1.14+ is required to run the test suite
* We build our releases on Go 1.15

This adds a CI check that verifies that the project compiles on 1.13
 2020-08-28 14:05:50 +02:00
Mislav Marohnić
987e95f0c8
Merge pull request #1593 from wilso199/docs/brew-installation 
Updating Brew Installation Instructions
 2020-08-28 12:24:49 +02:00
Mislav Marohnić
9e5b7aa371
Merge pull request #1594 from cli/remove-feedback-form 
Remove reference to feedback form
 2020-08-28 12:24:18 +02:00
Sam Coe
41f42d4057 Remove reference to feedback form 2020-08-28 09:06:31 +02:00
wilso199
3275690b83 Updating brew install 2020-08-27 20:48:44 -04:00
Colin Shum
2886dd913f [Refactor] toView -> toClone 2020-08-27 19:13:06 -04:00
Colin Shum
263e3a6a35 Update create_test.go 2020-08-27 17:57:55 -04:00
Nate Smith
87712242ad
Merge pull request #1584 from cli/pr-create-repo-override-crash 
Correctly surface errors when parsing `pr create --repo` override
 2020-08-27 14:00:58 -05:00
Colin Shum
32e5d05328 [Fix] Warn user when --template is passed with incompatible flags 2020-08-27 15:00:57 -04:00
Colin Shum
58f62a4a15 [Feature] Create repository from template 
Co-authored-by: Mislav Marohnić <mislav@github.com>
 2020-08-27 14:46:16 -04:00
Nate Smith
74524fc8f7
Merge pull request #1585 from cli/pr-commands-repo-override-arg 
Disallow `pr -R` flag for commands that operate on the current branch
 2020-08-27 10:52:18 -05:00
Nate Smith
2aa0f817ef
Merge pull request #1583 from cli/oauth-device-fallback-fix 
Handle "unauthorized_client" HTTP 400 error when doing Device Flow
 2020-08-27 10:49:14 -05:00
Mislav Marohnić
c21caf5b2b Disallow pr -R flag for commands that operate on the current branch 
If the `--repo` flag is specified, then the user intends to select a
repository other than the current one. In that case, it doesn't make
sense to fall back to detecting the PR belonging to the current branch,
so throw a descriptive error instead.
 2020-08-27 16:30:34 +02:00
Mislav Marohnić
b7550fbf15 Correctly surface errors when parsing pr create --repo override 
This avoids a crash when passing invalid input for the
`pr create --repo` flag.
 2020-08-27 14:26:27 +02:00
Mislav Marohnić
1c0f83ffd5 Handle "unauthorized_client" HTTP 400 error when doing Device Flow 
The "unauthorized_client" error means that OAuth Device Flow is implemented, but either isn't enabled on this GHES instance, or that it isn't enabled for this particular OAuth app. In these cases we fall back to old OAuth app authorization flow.
 2020-08-27 14:10:16 +02:00
Nate Smith
f1ea794bf1
Merge pull request #1580 from dan1elhughes/feature/number-url-scriptable-output 
Number and URL included in scriptable output
 2020-08-26 16:41:53 -05:00
Dan Hughes
7b8d052f0e
Add new output to existing test 2020-08-26 17:31:13 +01:00
Dan Hughes
a3aea11e5b
Include URL and number in non-TTY output 2020-08-26 17:28:17 +01:00
Nate Smith
727b726667
Merge pull request #1579 from cli/stderr-color-windows 
Enable color ANSI escape sequences on stderr on Windows
 2020-08-26 10:37:42 -05:00
Mislav Marohnić
ac0b49dc00 Enable color ANSI escape sequences on stderr on Windows 2020-08-26 16:47:08 +02:00
Nate Smith
27c49279b3
Merge pull request #1567 from ganboonhong/view-without-username 
View repositories without username
 2020-08-25 13:57:42 -05:00
Nate Smith
e8c4b301d3
Merge pull request #1522 from cli/oauth-device-flow 
Implement OAuth Device Authorization flow
 2020-08-25 13:54:07 -05:00
Nate Smith
fc1c800042
Merge pull request #1492 from ShubhankarKG/newConfirmations 
New confirmations
 2020-08-25 13:31:47 -05:00
Nate Smith
82c6830849
Merge pull request #1548 from cli/auth-check 
new auth flow UX
 2020-08-25 10:16:23 -05:00
vilmibm
451ece198b missed a disable auth check 2020-08-25 10:10:16 -05:00
vilmibm
2850ef0e17 forgot to run goimports 2020-08-24 13:32:20 -05:00
vilmibm
f3d1f9e56e no ascii art 2020-08-24 13:29:51 -05:00
boonhong
931fee566e shorthand of view without username 2020-08-23 23:33:50 +08:00
ShubhankarKG
7955c4f2ed doSetup wasn't getting called in cases where required. 
The problem was that opts.confirmSubmit was mutated before reaching doSetup. This commit creates a copy of the initial confirmSubmit value. So the doSetup receives the initial data passed from the command, not the mutated one.
 2020-08-20 14:20:55 +05:30
ShubhankarKG
00b2777a14 Change visibility strings to Sentence case 2020-08-20 14:10:18 +05:30
Nate Smith
b9292f582f
Merge pull request #1476 from rimazk123/prclose-delete 
Add delete branch flag to pr close
 2020-08-19 21:11:48 -05:00
vilmibm
e44eb665a1 Merge remote-tracking branch 'origin/trunk' into prclose-delete 2020-08-19 21:06:04 -05:00
Nate Smith
ddfa1714d2
Merge pull request #1479 from wilso199/pr-checkout-submodules 
PR Checkout - Recurse Submodules
 2020-08-19 16:46:21 -05:00
vilmibm
16f69e9c12 fix tests 2020-08-19 16:40:13 -05:00