Kynan Ware
bb3b64ad06
Update language for missing extension executable
...
Co-authored-by: Tyler McGoffin <jtmcg@github.com>
2024-11-18 16:25:07 -07:00
Kynan Ware
2ec27ff9fe
Update test comments about Windows behavior
...
Co-authored-by: Tyler McGoffin <jtmcg@github.com>
2024-11-18 16:21:14 -07:00
Meredith Lancaster
a55f9a6301
Merge branch 'trunk' into print-policy-info
2024-11-18 13:57:34 -07:00
Meredith Lancaster
9177b22a21
Merge pull request #9892 from malancas/refactor-fetch-attestations
...
Refactor the `getAttestations` functions
2024-11-18 13:56:46 -07:00
Meredith Lancaster
b787a8b785
wording
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-18 13:39:06 -07:00
Meredith Lancaster
a89071c30d
wording
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-18 12:25:57 -07:00
Meredith Lancaster
cfbc1c7e10
wording
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-18 12:16:12 -07:00
Meredith Lancaster
6ca5e6f18c
add newlines for additional policy info
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-18 11:42:39 -07:00
Meredith Lancaster
63f37eb369
pr feedback
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-18 08:24:25 -07:00
Meredith Lancaster
30ae1388e4
Update pkg/cmd/attestation/download/download.go
...
Co-authored-by: Phill MV <phillmv@github.com>
2024-11-18 08:19:41 -07:00
Meredith Lancaster
762e99d151
fix function param calls
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-18 08:19:07 -07:00
Meredith Lancaster
c518a3b1f5
Update pkg/cmd/attestation/verification/extensions.go
...
Co-authored-by: Phill MV <phillmv@github.com>
2024-11-18 08:18:04 -07:00
bagtoad
c5497b4d28
Document requirements for local extensions
2024-11-17 21:01:49 -07:00
bagtoad
b575fe8ebc
Warn when installing local ext with no executable
2024-11-17 21:01:49 -07:00
Andy Feller
7b91b17395
Refactor extension command testing
...
This commit allows for stubbing/mocking the function used for checking update release info. Additionally, this does a minor refactor moving from non-blocking to blocking channel.
2024-11-17 21:59:06 -05:00
Andy Feller
0d3f7cae4e
Bring extension update check in line with gh check
...
This commit is a bit of refactoring to bring the extension update checking logic up to par with what is done with `gh` including creation of state file per extension and listening to env vars for disabling version checking.
This work is not complete as it does not address necessary test changes.
2024-11-17 16:10:58 -05:00
nilvng
36eaf14857
issue #2329 : improve UI/UX
...
Improve the interactive PR selection UI by
- prefix the PR number with hashcode #
- perserve the text formatting (bold) upon an option is hovered
- add the PR head label
Technical changes:
- Replace \033[0m with \033[39m for maintaining text formatting
2024-11-17 23:47:36 +11:00
nilvng
c6c27113fe
issue #2329 : add happy path unit test
2024-11-17 16:36:10 +11:00
nilvng
1832c1a767
issue #2329 : fix the linting issue
2024-11-17 14:58:38 +11:00
nilvng
4386fcb4e5
issue #2329 : fix the unit tests issue - ensure its backward compatible
2024-11-17 14:57:48 +11:00
Nillin
49b10b745d
Merge branch 'trunk' into nil/fix-2329
2024-11-17 13:47:29 +11:00
bagtoad
68f3ef79ca
Handle missing "workflow" scope in createRelease
2024-11-16 19:32:37 -07:00
Kynan Ware
04e2a5dd63
Merge branch 'trunk' into 9904-gh-repo-create-to-work-on-bare-repos
2024-11-15 11:56:31 -07:00
Meredith Lancaster
a56ff4a0eb
wording
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-14 10:29:24 -07:00
Meredith Lancaster
91577594de
formatting
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-14 10:20:48 -07:00
Andy Feller
b8ef951de1
Shorten extension release checking from 3s to 1s
...
Addressing feedback from extension author demonstration about a noticable pause waiting for extension execution to complete due to amount of time waiting on channel.
2024-11-13 13:04:01 -05:00
William Martin
7bcb063391
Modify push prompt on repo create when bare
2024-11-11 16:17:06 +01:00
William Martin
8e63268aba
Doc push behaviour for bare repo create
2024-11-11 16:10:32 +01:00
William Martin
e3665955a5
Push --mirror on bare repo create
2024-11-11 16:09:03 +01:00
William Martin
2efb9935db
Doc isLocalRepo and git.Client IsLocalRepo differences
2024-11-11 14:18:26 +01:00
William Martin
f515e9c1e7
Use errWithExitCode interface in repo create isLocalRepo
2024-11-11 14:17:29 +01:00
William Martin
bc85e11d05
Backfill repo creation failure tests
2024-11-11 14:11:16 +01:00
William Martin
4a7f2e57b0
Support bare repo creation
2024-11-11 13:57:05 +01:00
Meredith Lancaster
43e5abbcd8
use logger println method
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-07 15:50:46 -07:00
Tyler McGoffin
9b9e654c76
Merge pull request #9866 from andyfeller/andyfeller/cli-cli-8183
...
Check extension for latest version when executed
2024-11-07 14:48:12 -08:00
Andy Feller
3ec657d087
Enhance extension upgrade tests for URL
2024-11-07 17:35:59 -05:00
Meredith Lancaster
e4cd729a7b
simplify verifyCertExtensions
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-07 14:59:21 -07:00
Meredith Lancaster
8ab5f247af
rename type
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-07 14:47:53 -07:00
Meredith Lancaster
ff9b6bb883
refactor fetch attestations funcs
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-07 14:39:11 -07:00
Meredith Lancaster
c7e4411a88
print policy information before verifying
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-07 13:16:13 -07:00
Meredith Lancaster
07e9a4a19d
add initial policy info method
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-07 11:08:58 -07:00
Meredith Lancaster
6d4c74b252
Merge pull request #9856 from malancas/verify-attestation-monotonic-tests
2024-11-07 07:45:25 -07:00
Andy Feller
ddf7287ab8
Test extension command update behaviors
...
This commit expands upon the previous work by creating tests around extension command execution and how various extension update scenarios are handled.
Along the way, the logic handling formatting update messaging has been switched to use `ColorScheme` in order to honor color behavior flags.
2024-11-06 22:49:02 -05:00
Tyler McGoffin
667f90ad51
Merge branch 'trunk' into nil/fix-7804
2024-11-06 15:25:07 -08:00
nilvng
2eaab56912
chore: tidy up
2024-11-07 10:20:23 +11:00
nilvng
874fa7ad4d
feat: add test
2024-11-07 10:20:23 +11:00
nilvng
a780b488a3
fix: ignore template flag
2024-11-07 10:20:23 +11:00
Andy Feller
e356c69a6f
Merge pull request #9881 from cli/cmbrose/cs-config-autokey
...
Create the automatic key when specified with -i
2024-11-06 16:24:43 -05:00
Caleb Brose
509a181d79
Remove unimplemented tests
2024-11-06 19:10:28 +00:00
William Martin
0f85e4e0e0
Merge pull request #9883 from cli/9882-gh-cache-list-json-should-return-when-no-caches-exist-instead-of-text-message
...
Print empty array for `gh cache list` when `--json` is provided
2024-11-06 18:18:44 +01:00
