Commit graph

2676 commits

Author SHA1 Message Date
Mislav Marohnić
8d82a96349
Fix fetching issue/PR comments
The "Author" struct was too overloaded in different types of queries that treat struct fields in incompatible ways. This change defines a simpler CommentAuthor struct for use in comments until we can figure out how to query `... on User` information for comments too.
2022-12-23 17:14:06 +01:00
Mislav Marohnić
6a5532481f
Avoid sending empty JSON body when no params to api command (#6775) 2022-12-22 21:45:17 +01:00
Mislav Marohnić
c5c2f9cc10
Supported passing nested JSON arrays/objects to api command via fields (#6614)
Examples:

	-f labels[]=bug -f labels[]=p1
        #=> { "labels": ["bug", "p1"] }

	-f branch[name]=patch-1 -F branch[protected]=true
        #=> { "branch": { "name": "patch-1", "protected": true }

	-f labels[][name]=bug-1 -f labels[][color]=red
        #=> { "labels": [{ "name": "bug-1", "color": "red" }] }
2022-12-22 20:12:00 +01:00
Mislav Marohnić
f8f206e063
Group PR, release, and repo subcommands 2022-12-21 14:47:59 +01:00
Mislav Marohnić
fcd86c00b4
Merge remote-tracking branch 'origin' into cobra-update 2022-12-21 13:23:41 +01:00
Nate Smith
1f85a92463
Merge pull request #5333 from chemotaxis/gh-issue-lock
Add `lock` and `unlock` commands for issues and pull requests
2022-12-20 18:04:34 -06:00
vilmibm
c3cceae9ea finish tests 2022-12-20 15:45:13 -08:00
vilmibm
6fce78e689 WIP all but relocking 2022-12-20 15:34:17 -08:00
vilmibm
8d9b47e555 stub out rest of tests 2022-12-20 15:20:21 -08:00
vilmibm
a1fe708048 todos 2022-12-20 13:15:14 -08:00
vilmibm
bb958490ea WIP tests 2022-12-20 13:14:41 -08:00
vilmibm
cee5e6e42a WIP on tests 2022-12-20 13:00:52 -08:00
Mislav Marohnić
607a0876b9
Split issue commands into "General" vs. "Targeted" 2022-12-20 17:56:51 +01:00
Mislav Marohnić
2ede67331d
Merge pull request #6706 from browniebroke/feat/edit-repo/allow-update-branch
Add `--allow-update-branch` to the `repo edit` command
2022-12-20 17:56:30 +01:00
Mislav Marohnić
a55dd656f3
Merge remote-tracking branch 'origin' into cobra-update 2022-12-20 17:15:25 +01:00
vilmibm
95419f9006 further WIP 2022-12-19 18:12:08 -08:00
vilmibm
4c28e32e9d WIP on adding tests, add prompt, tweak things 2022-12-19 17:57:04 -08:00
Des Preston
4ade907ae8
Allow setting codespace display name during create (#6739)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-12-19 17:10:34 +01:00
Mislav Marohnić
6d93849476
Merge pull request #6738 from cli/default-repo-error
error instead of prompt for unset base repo
2022-12-19 15:53:32 +01:00
Mislav Marohnić
7caf7da2da
Merge pull request #6667 from cli/release-galore
More resilient release commands
2022-12-19 15:33:15 +01:00
vilmibm
b52d452168 wip: tweak output, update to Prompter, start on tests 2022-12-16 13:01:09 -08:00
vilmibm
5a6b4ce934 Merge remote-tracking branch 'origin/trunk' into gh-issue-lock 2022-12-16 10:10:59 -08:00
vilmibm
f5d19b831e error instead of prompt when no base repo + fixes 2022-12-15 11:44:37 -08:00
Nate Smith
59812d429a
Merge pull request #4859 from bchadwic/base-cmd
`gh config base` a way to configure the base repo
2022-12-14 18:36:46 -06:00
vilmibm
5461d15b74 final bit of feedback 2022-12-14 16:26:01 -08:00
vilmibm
6532397963 use factory git client 2022-12-14 16:26:01 -08:00
vilmibm
db4de60307 rename command and fix tests 2022-12-14 16:26:01 -08:00
vilmibm
41bdaa426a tweak wording 2022-12-14 16:26:01 -08:00
Mislav Marohnić
8cb312a620
Fix release assets upload retry logic
Enables up to 3 retries of uploading a single asset when encountering a network error or a HTTP 5xx error.

Bonus:
- simplifies ConcurrentUpload implementation
- support Go context cancellation
2022-12-14 21:25:09 +01:00
Mislav Marohnić
cbeed671dd
release create: clean up leftover draft release on upload/publish failure 2022-12-14 21:24:39 +01:00
Mislav Marohnić
36ffbe18de
Improve looking up draft releases by tag name
This changes the FetchRelease implementation to look up draft releases directly using by its pending tag name, as opposed to resorting to the Releases list API which is backed by Elastic Search and thus suffers replication lag after the creation of a draft release.

Bonus: all release lookup functions now accept a context for cancellation.
2022-12-14 21:24:08 +01:00
Paul Forness
e86b3ea91f
Change alias list output format to YAML (#6603)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-12-13 22:49:04 +01:00
vilmibm
230d89be93 add more to usage 2022-12-13 12:06:57 -08:00
vilmibm
2090e1111f tweak UX and switch to prompter 2022-12-13 11:57:05 -08:00
Caleb Brose
6f1d149da3
Merge pull request #6725 from cli/cmbrose/rename-repo-shorthand
Codespaces: Use -R for --repo shorthand and deprecate -r
2022-12-13 13:52:48 -06:00
vilmibm
76c58930d9 tests pass 2022-12-13 10:48:03 -08:00
vilmibm
7e3e2d96a8 Merge remote-tracking branch 'origin/trunk' into base-cmd 2022-12-13 10:39:40 -08:00
Mislav Marohnić
dd8c5c9dae
Fix clobbering old files in release download (#6694)
Ensures that the old file to be clobbered is first truncated before writing.
2022-12-13 18:39:23 +00:00
Caleb Brose
56006eefa6 Flags instead of PersistentFlag 2022-12-13 01:20:49 +00:00
Caleb Brose
57c53e6268 linter 2022-12-12 21:21:23 +00:00
Caleb Brose
8e0b4ef21b Use -R for --repo shorthand and deprecate -r 2022-12-12 19:44:59 +00:00
Nate Smith
67e5baea09
Merge pull request #6711 from cli/release-prompter
port release command to prompter
2022-12-12 12:09:29 -06:00
Mislav Marohnić
e4f5545e86
Go 1.19: fix comment formatting for moq-generated mocks 2022-12-12 16:58:25 +01:00
Sam Coe
6dbe7e6342
Linter fixes (#6722)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-12-12 15:27:32 +00:00
vilmibm
6507d35f2f port release command to prompter 2022-12-09 15:06:26 -08:00
Jake Shorty
c21408fc01
Merge pull request #6705 from cli/jshorty/new-pfs-domain
Use new domain for forwarded ports
2022-12-09 13:31:39 -05:00
Matthew Gabeler-Lee
eadc8e8372
Add isDraft to search prs json options, matching pr view (#6704) 2022-12-09 07:57:27 +00:00
Nate Smith
4fd56ac7c1
Merge pull request #5049 from hirasawayuki/add-more-author-infomation
Add author information in `pr list` JSON output
2022-12-08 16:19:18 -06:00
vilmibm
c91c2d43cd export is_bot in issue/pr search 2022-12-08 12:55:03 -08:00
Bruno Alla
25209ad6b1 Add --allow-update-branch to the repo edit command 2022-12-08 20:19:14 +00:00