Commit graph

79 commits

Author SHA1 Message Date
Alan Donovan
5fea604f78
gh cs cp --help: fix typo 2021-12-02 17:09:20 -05:00
Mislav Marohnić
a573eb5d80
Fix codespace code command under WSL (#4747)
The `codespace code` command used the `skratchdot/open-golang` library
to open `vscode://` URLs, which uses `xdg-open` for Linux under the
hood, which isn't available under WSL.

This switches over to using the `cli/browser` package which has explicit
support for WSL by invoking `wslview` when found.
2021-11-24 16:18:24 +00:00
Jeff Hubbard
91dc722170 Remove the default value from idle-timeout as the API takes care of it and this can override user settings 2021-11-18 11:38:26 -08:00
Jeff Hubbard
90313fbf96
Add idle timeout to cs create parameters (#4741)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2021-11-18 11:47:48 +00:00
Amanda Lin
15c8f291e4
Add prebuild availability status to create codespaces (#4737) 2021-11-17 19:41:05 +01:00
Mislav Marohnić
dae77fd398
Merge pull request #4675 from cli/docs-web-formatting
Overhaul manual pages for the web
2021-11-09 21:00:51 +01:00
Jose Garcia
8296904c26
Rename errors from Live Share to generic codespace 2021-11-08 13:35:48 +00:00
Mislav Marohnić
2c180a6338 Clean up codespace cp docs
- Examples block now moved to its own section
- Refer to flags by their full names
- Use backticks for delimiting command-line expressions
- Use double quotes for literal values
2021-11-03 15:44:09 +01:00
Mislav Marohnić
9b7d53501f Make sure URLs in man pages render as hyperlinks on the web 2021-11-03 15:39:10 +01:00
Mislav Marohnić
31ba2ea4d5
Publish codespace commands (#4606) 2021-10-25 17:38:00 +00:00
Srivatsn Narayanan
32f1ea5ec0 Update branding of VSCode in the code command 2021-10-25 16:53:28 +00:00
Mislav Marohnić
83a08aa3ba Remove unnecessary pointers to Go maps 2021-10-25 17:20:12 +02:00
Mislav Marohnić
8d9e8e317e
Merge pull request #4591 from cli/codespaces-json-export
Add export functionality to codespace commands
2021-10-25 17:10:32 +02:00
Mislav Marohnić
905cb3b9fa Touch-up codespaces exporting functionality 2021-10-25 15:45:10 +02:00
Mislav Marohnić
436762dd54 codespace create: make the branch input optional
When blank, the branch name will default to the default branch for the
repository.
2021-10-22 15:43:26 +02:00
Mislav Marohnić
3492109e12 codespace create: avoid unnecessarily fetching user 2021-10-22 14:39:21 +02:00
Mislav Marohnić
a5fa70a07d 🔥 obsolete codespace/output package 2021-10-22 14:18:10 +02:00
Mislav Marohnić
cbeb675e56 codespace ports: support --json and --template export flags 2021-10-22 14:13:43 +02:00
Mislav Marohnić
badbf515cb codespace list: support --json and --template export flags 2021-10-22 14:13:15 +02:00
Alan Donovan
2f7f224c9e
Merge pull request #4584 from cli/FlagErrorf
Add FlagErrorf; encapsulate FlagError.error
2021-10-21 14:14:05 -04:00
Mateusz Urbanek
67595110e8
Improve table output from codespace list command (#4516)
Co-authored-by: Jose Garcia <josebalius@github.com>
Co-authored-by: Mislav Marohnić <mislav@github.com>
2021-10-21 16:42:08 +00:00
Jose Garcia
bbea5ac95e
codespace: progress indication, logging (#4555)
* Rework logging, showing progress, and printing from `codespace` commands
* Change rendering of the general progress indicator so that it's visible on both dark and light backgrounds
* The progress indicator now "spins" faster

Co-authored-by: Mislav Marohnić <mislav@github.com>
2021-10-21 18:04:04 +02:00
Alan Donovan
f4491c7a80 Add FlagErrorf; encapsulate FlagError.error 2021-10-21 11:40:20 -04:00
Alan Donovan
7215522123 use FlagError 2021-10-21 10:06:11 -04:00
Alan Donovan
8fb5e5e1d5 Report error if no filename is remote 2021-10-20 14:21:22 -04:00
Alan Donovan
fc1de3aaa0
Merge pull request #4564 from cli/e-flag
gh cs cp: disable remote shell expansion unless -e flag
2021-10-19 11:38:19 -04:00
Alan Donovan
f683d6cb4c Disable remote shell expansion unless -e 2021-10-19 10:11:31 -04:00
Alan Donovan
b96ccb4d99
Merge pull request #4553 from cli/cs-cp
gh cs cp: copy files between local/remote file systems
2021-10-18 17:32:08 -04:00
Alan Donovan
48ada6d5f2 Use correct destination string, not root@localhost 2021-10-18 13:59:41 -04:00
Alan Donovan
e31b2567b8 gh cs cp: copy files between local/remote file systems 2021-10-18 12:39:09 -04:00
Mike McDonald
e923eb8853
Merge branch 'trunk' into mm-codespaces-remove-friendly-machine-name 2021-10-18 10:35:48 -06:00
Jose Garcia
84ced52131 Update cmd docs to match other commands 2021-10-16 17:10:34 -04:00
Mike McDonald
e175d0f0a6 removing unused dependencies 2021-10-15 22:05:54 +00:00
Mike McDonald
5f98c9d2e4 Fixing formatting 2021-10-15 21:58:52 +00:00
Mike McDonald
21ff083b9b Removing "friendly" machine name from prompt
Currently the options end up as `Basic` through to `X`. No other client
provides these types of names, so we should just show machine info.
2021-10-15 21:56:17 +00:00
Marwan Sulaiman
6f34e4a605
Rename privacy sub-command to visibility (#4533)
* Rename privacy sub-command to visibility

* PR fixes
2021-10-15 09:51:46 -04:00
Jose Garcia
4504e49e96 Update running method 2021-10-14 20:02:02 -04:00
Jose Garcia
1aec892326
Merge pull request #4520 from cli/jg/new-api-shape
codespace: implement new API payload
2021-10-14 19:59:59 -04:00
Mislav Marohnić
b0360612d2
Merge pull request #4521 from cli/jg/bind-locally
codespace: switches port binding to 127.0.0.1 where possible
2021-10-14 20:29:21 +02:00
Jose Garcia
b0905a415f
Merge pull request #4508 from cli/jg/codespace-stop
codespace stop: new command to stop a running codespace
2021-10-14 11:22:25 -04:00
Jose Garcia
0748e658cc Switches port binding to 127.0.0.1 where possible 2021-10-14 11:07:25 -04:00
Jose Garcia
5e56b4a7ce Fix tests 2021-10-14 09:21:03 -04:00
Jose Garcia
3544275c2f Implement new API payload for a Codespace 2021-10-14 09:10:15 -04:00
Jose Garcia
d5c9630fae
Merge pull request #4511 from cli/jg/keepalive-fix
codespace ssh: fix for nil logger on non-debugging scenarios
2021-10-13 14:44:10 -04:00
Jose Garcia
3dbec86556 PR Feedback 2021-10-13 14:30:33 -04:00
Jose Garcia
d6b5157eff Fix for nil logger on non-debugging scenarios 2021-10-13 14:15:26 -04:00
Marwan Sulaiman
b9bdef2b00
Add org scoped port forwarding + fix test formatting (#4497)
* Add org scoped port forwarding + fix test formatting

* Redesign port visibility

* Update pkg/cmd/codespace/ports.go

Co-authored-by: Jose Garcia <josebalius@github.com>

* Change sub command to privacy

* Example pr comment

* Fix test mock

* Fix test mock

Co-authored-by: Jose Garcia <josebalius@github.com>
2021-10-13 13:56:03 -04:00
Jose Garcia
07fa60b69a PR Feedback 2021-10-13 11:46:57 -04:00
Jose Garcia
be10950058 Update mocks 2021-10-13 11:04:15 -04:00
Jose Garcia
4fb4a21efd Rename + docs 2021-10-13 10:57:50 -04:00