Commit graph

10763 commits

Author SHA1 Message Date
Kynan Ware
35828f44cd Add manual dispatch to bump-go workflow
Enable manual runs of the Bump Go workflow by adding the workflow_dispatch trigger alongside the existing scheduled cron. This allows maintainers to trigger the bump process on-demand while keeping the daily 3 AM UTC schedule intact.
2026-02-06 11:52:24 -07:00
Kynan Ware
0f04a4815f
Merge pull request #12616 from cli/dependabot/go_modules/golang.org/x/term-0.39.0
chore(deps): bump golang.org/x/term from 0.38.0 to 0.39.0
2026-02-06 11:40:15 -07:00
Kynan Ware
0a2841fb9d update third party licenses 2026-02-06 11:30:46 -07:00
dependabot[bot]
4de27314a0
chore(deps): bump golang.org/x/term from 0.38.0 to 0.39.0
Bumps [golang.org/x/term](https://github.com/golang/term) from 0.38.0 to 0.39.0.
- [Commits](https://github.com/golang/term/compare/v0.38.0...v0.39.0)

---
updated-dependencies:
- dependency-name: golang.org/x/term
  dependency-version: 0.39.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-02-06 18:28:20 +00:00
Kynan Ware
cc3fd78414
Merge pull request #12468 from cli/dependabot/go_modules/golang.org/x/text-0.33.0
chore(deps): bump golang.org/x/text from 0.32.0 to 0.33.0
2026-02-06 11:27:05 -07:00
Kynan Ware
ad305b7217 update third party licenses 2026-02-06 11:19:27 -07:00
dependabot[bot]
28ed4bdbf0
chore(deps): bump golang.org/x/text from 0.32.0 to 0.33.0
Bumps [golang.org/x/text](https://github.com/golang/text) from 0.32.0 to 0.33.0.
- [Release notes](https://github.com/golang/text/releases)
- [Commits](https://github.com/golang/text/compare/v0.32.0...v0.33.0)

---
updated-dependencies:
- dependency-name: golang.org/x/text
  dependency-version: 0.33.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-02-06 18:17:42 +00:00
Kynan Ware
fa43288852
Merge pull request #12567 from cli/kw/multi-select-with-search-and-ccr
`gh pr edit`: Add support for Copilot as reviewer with search capability, performance and accessibility improvements
2026-02-06 10:51:36 -07:00
Kynan Ware
c0febc1ac8 Add toGitHubV4Strings helper to reduce code duplication 2026-02-04 15:18:49 -07:00
Kynan Ware
ebf932a043 Address PR review comments
Address PR review comments: code consistency and DRY improvements

- Add botTypeName const for consistency with teamTypeName
- Create extractTeamSlugs helper using strings.SplitN to simplify
  team slug extraction logic
- Replace duplicate code in AddPullRequestReviews and
  RemovePullRequestReviews with extractTeamSlugs helper
- Fix ClientMutationId naming with explicit graphql tag for
  consistency with other mutations in the codebase
2026-02-04 15:15:29 -07:00
Kynan Ware
af4dad088a
Merge pull request #12469 from cli/dependabot/go_modules/github.com/gdamore/tcell/v2-2.13.7
chore(deps): bump github.com/gdamore/tcell/v2 from 2.13.4 to 2.13.7
2026-02-03 11:49:46 -07:00
Kynan Ware
bc689e358a update third party licenses 2026-02-03 11:39:31 -07:00
dependabot[bot]
915750902c
chore(deps): bump github.com/gdamore/tcell/v2 from 2.13.4 to 2.13.7
Bumps [github.com/gdamore/tcell/v2](https://github.com/gdamore/tcell) from 2.13.4 to 2.13.7.
- [Release notes](https://github.com/gdamore/tcell/releases)
- [Changelog](https://github.com/gdamore/tcell/blob/main/CHANGESv3.md)
- [Commits](https://github.com/gdamore/tcell/compare/v2.13.4...v2.13.7)

---
updated-dependencies:
- dependency-name: github.com/gdamore/tcell/v2
  dependency-version: 2.13.7
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-02-03 18:35:17 +00:00
Kynan Ware
5378856954
Merge pull request #12555 from cli/dependabot/go_modules/github.com/theupdateframework/go-tuf/v2-2.4.1
chore(deps): bump github.com/theupdateframework/go-tuf/v2 from 2.3.1 to 2.4.1
2026-02-03 11:31:45 -07:00
Kynan Ware
188dfde7aa Update third party licenses 2026-02-03 18:23:45 +00:00
dependabot[bot]
291637aabf
chore(deps): bump github.com/theupdateframework/go-tuf/v2
Bumps [github.com/theupdateframework/go-tuf/v2](https://github.com/theupdateframework/go-tuf) from 2.3.1 to 2.4.1.
- [Release notes](https://github.com/theupdateframework/go-tuf/releases)
- [Commits](https://github.com/theupdateframework/go-tuf/compare/v2.3.1...v2.4.1)

---
updated-dependencies:
- dependency-name: github.com/theupdateframework/go-tuf/v2
  dependency-version: 2.4.1
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-02-03 18:01:55 +00:00
Kynan Ware
1714ae5407
Merge pull request #12524 from cli/dependabot/go_modules/github.com/sigstore/rekor-1.5.0
chore(deps): bump github.com/sigstore/rekor from 1.4.3 to 1.5.0
2026-02-03 10:59:55 -07:00
Kynan Ware
b9a63c8923 Update third-party licenses 2026-02-03 10:50:17 -07:00
Kynan Ware
db19b778ad
Merge pull request #12558 from cli/dependabot/github_actions/actions/attest-build-provenance-3.2.0
chore(deps): bump actions/attest-build-provenance from 3.1.0 to 3.2.0
2026-02-03 10:43:42 -07:00
Kynan Ware
a9a0486c70 Clarify comment on reviewer API behavior
Update comment in FetchOptions to specify that the APIs used for both GHES and GitHub.com accept user logins and team slugs directly, clarifying why non-interactive flows with Add/Remove don't need to fetch reviewers/teams. Comment-only change; no functional modifications.
2026-01-30 11:33:22 -07:00
Kynan Ware
aac223ab71 Clarify assignee/reviewer fetching behavior
Add clarifying comment in pkg/cmd/pr/edit/edit.go to note that missing assignee/reviewer search functions trigger a downstream fallback to legacy fetching. In pkg/cmd/pr/shared/editable.go remove a redundant line and add a TODO urging migration of non-interactive assignee updates to use the new logins input with ReplaceActorsForAssignable to avoid unnecessary fetching. These are comment and doc changes to clarify intent and future improvements.
2026-01-30 11:29:11 -07:00
Kynan Ware
4569aae0e4 Clarify EditableReviewers comment
Remove a redundant struct-level comment and update the DefaultLogins field comment in pkg/cmd/pr/shared/editable.go to more accurately describe its purpose: used to disambiguate actors from display names rather than to compute add/remove sets.
2026-01-30 11:20:30 -07:00
Kynan Ware
7303c44483 Clarify Copilot assignee comment
Reword the comment for CopilotAssigneeLogin to indicate it refers to Copilot when retrieved as an assignee. This updates wording from the previous 'Actor/assignable actors' phrasing for clarity; no code behavior changed.
2026-01-30 11:17:25 -07:00
Kynan Ware
c8b1409803 Use unfiltered totalCount for reviewer 'more results' display
Query aliased fields without search filter to get stable counts.
2026-01-29 12:54:04 -07:00
Kynan Ware
484526da77 Include name in reviewer display for existing review requests
Fetch name field in reviewRequests GraphQL query and show as 'login (Name)'.
2026-01-29 12:46:26 -07:00
Kynan Ware
43f802f5cb
Merge branch 'trunk' into kw/multi-select-with-search-and-ccr 2026-01-29 12:34:35 -07:00
Kynan Ware
150834b426
Merge pull request #12580 from cli/kw/update-go-1.25.6
update Go to 1.25.6
2026-01-29 11:55:18 -07:00
Kynan Ware
12e59c421b update Go 1.25.6 2026-01-29 11:38:24 -07:00
Kynan Ware
2d191e5ba0 Implement cascading quota for reviewer suggestions
Each source (suggestions, collaborators, teams) has base quota of 5.
Unfilled slots cascade to later sources, allowing up to 15 total.
Adds unit tests with HTTP mocks.
2026-01-29 11:30:08 -07:00
Kynan Ware
d643d5386e fix(pr edit): send empty slices to clear reviewers in replace mode
Always send explicit lists for userLogins, botLogins, and teamSlugs
in RequestReviewsByLogin mutation, even when empty. Previously, empty
slices were omitted due to omitempty JSON behavior and len > 0 checks,
which prevented clearing all reviewers when using replace mode.

Empty slices are harmless no-ops in union mode, so we now send them
unconditionally for simpler logic.

Add test to verify the mutation receives empty slices when all
reviewers are removed.
2026-01-29 10:37:11 -07:00
Kynan Ware
7f8ca2ca81 Fix return proper slug only for ReviewerTeam 2026-01-29 10:23:18 -07:00
Kynan Ware
846d6619b7 Remove redundant comment 2026-01-28 10:50:54 -07:00
Babak K. Shandiz
3bffa3c077
Merge pull request #12573 from cli/babakks/upgrade-cli-oauth
chore: bump `cli/oauth` to `v1.2.2`
2026-01-28 16:20:35 +00:00
Babak K. Shandiz
8f0cfac2ca
chore: update licenses
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2026-01-28 16:10:58 +00:00
Babak K. Shandiz
05f1a98416
chore: bump cli/oauth to v1.2.2
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2026-01-28 16:09:59 +00:00
Kynan Ware
738b82ddab Add CCR and reviewer MultiSelectWithSearch
Enables Copilot to be requested as a pull request reviewer, supporting both interactive and non-interactive flows. Introduces new reviewer search functionality, updates reviewer partitioning to distinguish users, bots, and teams, and adds a GraphQL mutation for reviewer management on github.com. Updates help text, tests, and internal APIs to support Copilot reviewer login and display names, while maintaining compatibility with GitHub Enterprise Server.
2026-01-27 23:11:51 -07:00
Kynan Ware
6adf803127
Merge pull request #12526 from cli/github-cli-1070-multi-select-with-search-ccr
`gh pr edit`: new interactive prompt for assignee selection, performance and accessibility improvements
2026-01-27 09:16:26 -07:00
dependabot[bot]
fdc72751a7
chore(deps): bump actions/attest-build-provenance from 3.1.0 to 3.2.0
Bumps [actions/attest-build-provenance](https://github.com/actions/attest-build-provenance) from 3.1.0 to 3.2.0.
- [Release notes](https://github.com/actions/attest-build-provenance/releases)
- [Changelog](https://github.com/actions/attest-build-provenance/blob/main/RELEASE.md)
- [Commits](00014ed6ed...96278af6ca)

---
updated-dependencies:
- dependency-name: actions/attest-build-provenance
  dependency-version: 3.2.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-01-27 14:01:36 +00:00
Kynan Ware
23e80a9d24 Remove outdated comment in SuggestedAssignableActors
Deleted a comment about the query variable being passed as null when empty, as it is no longer relevant or necessary.
2026-01-26 15:09:58 -07:00
Kynan Ware
a33d809c88
Apply suggestions from code review
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-01-26 15:09:16 -07:00
Kynan Ware
968a912a07 Remove outdated TODO comments in survey.go
Cleaned up obsolete TODO comments related to assignee and reviewer selection logic in the MetadataSurvey function.
2026-01-26 15:05:18 -07:00
Kynan Ware
a8053d6e93 Remove redundant comment in editRun test 2026-01-26 14:56:50 -07:00
Kynan Ware
28e07666f8 Return total assignee count in SuggestedAssignableActors
Updated SuggestedAssignableActors to return the total count of available assignees in the repository. Modified assigneeSearchFunc to use this count to calculate and display the number of additional assignees beyond the current results.
2026-01-26 14:33:45 -07:00
Kynan Ware
af124cd5d2 Add test for MultiSelectWithSearch error propagation
Introduces a test case to verify that errors returned from the MultiSelectWithSearch search function are properly propagated to the caller.
2026-01-26 13:56:47 -07:00
Kynan Ware
fb031b2b43 Add test for legacy assignee flow on GHES
Introduces a test case to verify that the interactive edit flow on GitHub Enterprise Server uses the legacy assignee selection without search, ensuring correct behavior when editing pull request assignees.
2026-01-26 13:48:23 -07:00
Kynan Ware
48bea46504 Remove unused Viewer struct from SuggestedAssignableActors
Deleted the Viewer struct from the responseData type in SuggestedAssignableActors as it was not being used.
2026-01-26 13:48:22 -07:00
Kynan Ware
e3a3a01f2d Add comments to assigneeSearchFunc for clarity
Added detailed comments to the assigneeSearchFunc explaining its purpose and the importance of updating assignable actors metadata for later ID resolution when mutating assignees with the GraphQL API.
2026-01-26 13:29:22 -07:00
Kynan Ware
dc105ce7a4 Simplify variables map in SuggestedAssignableActors
Refactored the construction of the variables map by directly assigning the 'query' key, removing the conditional logic for nil assignment.
2026-01-26 13:29:22 -07:00
Kynan Ware
346bd8c002 Simplify suggested assignable actors
Simplifies SuggestedAssignableActors by no longer including the viewer in the returned actors list when the query is blank. Removes related logic and variables for viewer handling.
2026-01-26 13:29:22 -07:00
Kynan Ware
38f9d7891b Fix linter and mock prompter signature 2026-01-26 13:29:22 -07:00