STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
9798 commits 87 branches 0 tags 160 MiB
Commit graph

95 commits

Author SHA1 Message Date
Babak K. Shandiz
5db8cf7c1d
Increase beforePasswordSendTimeout to 100 us (#10977) 
Signed-off-by: Babak K. Shandiz <babakks@github.com>
 2025-05-13 12:38:45 +01:00
Andy Feller
7ceca4534d
Merge pull request #10937 from cli/kw/accessible-prompter-prints-readable-defaults-in-prompt 
Accessible prompter always displays defaults in speech synthesis readable format
 2025-05-09 08:48:10 -04:00
Babak K. Shandiz
90532e8377
Improve assertion for disabled echo mode (#10927) 
* Improve assertion for disabled echo

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Use `expect.RegExpPattern`

Signed-off-by: Babak K. Shandiz <babakks@github.com>

---------

Signed-off-by: Babak K. Shandiz <babakks@github.com>
 2025-05-08 21:26:02 +01:00
Kynan Ware
9b89a0ac0e fix(a11y prompter): remove invalid defaults 2025-05-08 07:41:36 -06:00
Kynan Ware
3594f6357b fix(a11y prompter): confirm prompt default is readable 2025-05-06 15:50:57 -06:00
Kynan Ware
04aaaea142 fix(a11y prompter): multi select defaults are readable 2025-05-06 15:43:26 -06:00
Kynan Ware
957667efe6 doc(prompter): remove TODO about default value panic 2025-05-06 15:33:51 -06:00
Kynan Ware
cab906151f fix(a11y prompter): select prompt default value is readable 2025-05-06 15:33:15 -06:00
Kynan Ware
ab4cfb84d2 refactor(a11yprompter): shared method for prompt defaults 2025-05-06 15:33:15 -06:00
Kynan Ware
2ee68411a7 fix(a11y prompter): Select prompt respects defaults 2025-05-06 15:33:15 -06:00
Kynan Ware
9bc2c388da fix(a11y prompter): input prompt default value is readable 2025-05-06 14:34:05 -06:00
William Martin
a2fcb9b2df
Merge pull request #10915 from cli/wm/projectsv1-deprecation-pr-create-rest 
Feature detect v1 projects on interactive `pr create`
 2025-05-06 15:24:04 +02:00
Kynan Ware
cc673cfaba test(prompter): add timeout before password input 2025-05-02 14:48:07 -06:00
William Martin
5a3aee056a Feature detect v1 projects on interactive pr create 2025-05-02 17:42:23 +02:00
Kynan Ware
00c930d509
doc(prompter): small typo 2025-04-30 08:04:16 -06:00
Andy Feller
8130126ce5
Merge pull request #10901 from cli/kw/fix-accessible-multi-select-prompter-respects-defaults 
Fix: Accessible multiselect prompt respects default selections
 2025-04-30 09:46:56 -04:00
Kynan Ware
d8512a9066 fix(prompter): respect default MultiSelect a11y prompter 2025-04-29 16:35:04 -06:00
Andy Feller
88d52ebf97 Fix other disabled echo mode comments 2025-04-28 11:20:17 -04:00
Andy Feller
df0aedbe3c
Update internal/prompter/prompter.go 2025-04-28 11:16:35 -04:00
Andy Feller
2d66877d6c
Update internal/prompter/accessible_prompter_test.go 2025-04-28 11:15:28 -04:00
Andy Feller
9fa00c350b Update accessible tests based on huh@0.7.0 changes 2025-04-28 10:17:23 -04:00
Andy Feller
a53b6c074c Assert password and auth token not displayed 
This commit expands existing tests (thanks to @babakks) to assert whether the echo mode is actually disabled for password and auth token prompts.
 2025-04-28 08:55:47 -04:00
Andy Feller
97a3b70599 Update to huh@0.7.0, echo mode changes 
This commit is the initial change around updating to huh@0.7.0; pre-testing changes.
 2025-04-26 12:57:10 -04:00
Kynan Ware
9463b0ee61 test(prompter): correct typo in accessible prompter name 2025-04-22 17:12:07 -06:00
Kynan Ware
138bccd437 feat(config): add accessible prompter and spinner 2025-04-22 16:50:58 -06:00
Andy Feller
f61961907e Update configuration support for accessible colors 
- added support for `accessible_colors` configuration setting in `gh config` commandset
- updated default configuration file to contain `accessible_colors: disabled`
- add `GH_ACCESSIBLE_COLORS` env var to `gh environment`
- generated mocks via `go generate ./...` including previously missed prompter changes
 2025-04-17 15:57:49 -04:00
Kynan Ware
70537de132
test(prompter): fix invalid comment 2025-04-10 17:18:56 -06:00
Kynan Ware
8cd39923fe test(prompter): fix race condition 
This test was trying to block on `expect`’ing a string at the same
time the prompt was completed.

This doesn't need to happen for this test. It should just check for
the output from the Input prompt invocation.
 2025-04-10 17:09:22 -06:00
Andy Feller
b8cd094ca8 Ensure markdown confirm prompt shows editor name 
Apparently, `gh` might not actually have an editor at the time we're prompting
the user if they want to use it for markdown editing.  In the survey package,
there is a function that will handle fallback to the default editor based on
environment variables and parse it in the case the editor contains flags and
arguments for cases like Visual Studio Code.

Additionally, there are no tests for the EditorName function and the fact it
is loaded via `init` makes this difficult to test.

Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
 2025-04-10 16:28:58 -06:00
Kynan Ware
20ff409bfc fix(prompter): remove needless default value assignment 2025-04-10 16:28:57 -06:00
Kynan Ware
9eee77a2bf test(prompter): doc how accessible prompter tests work 2025-04-10 10:55:24 -06:00
Kynan Ware
8b70870f4f test(prompter): describe why echo is editorcmd 2025-04-10 10:39:59 -06:00
Kynan Ware
47d603221d test(prompter): use *testing.T instead 2025-04-10 10:37:36 -06:00
Kynan Ware
fab0de5583 fix(prompter): pass io to huh and refactor tests 2025-04-09 15:51:02 -06:00
Kynan Ware
2f5e896535 fix(prompter): update huh and fix tests 2025-04-09 15:18:53 -06:00
Kynan Ware
8fc8486af5 refactor(prompter): rename speechSynthesizerFriendlyPrompter to accessiblePrompter 2025-04-09 08:24:54 -06:00
Kynan Ware
d230b08c43 test(prompter): re-add skipped test for accessible confirm default 2025-04-08 13:09:15 -06:00
Kynan Ware
19387b8418 fix(prompter): rename GH_ACCESSIBLE_PROMPTER 2025-04-08 12:52:39 -06:00
Kynan Ware
9cf341302e refactor(prompter): explicit return values 2025-04-08 12:03:55 -06:00
Kynan Ware
8821f77fbb doc(prompter): remove senseless comment 2025-04-08 12:00:02 -06:00
Kynan Ware
c4be95afd9 refactor(prompter): remove unused variable 2025-04-08 11:58:50 -06:00
Kynan Ware
ef58e627f9 test(prompter): timeout for tests is 1s 2025-04-08 11:44:14 -06:00
Kynan Ware
d8d3874778 fix(prompter): use os.lookupenv for accessible prompter 2025-04-08 11:38:54 -06:00
Kynan Ware
fb80b5bd86 test(prompter): remove needless NO_COLOR set 2025-04-07 14:56:33 -06:00
Kynan Ware
c5ffb3cbfe
test: use example.com in tests 2025-04-07 14:54:41 -06:00
Kynan Ware
66407402c0
doc: comment typos and formatting 
Co-authored-by: Andy Feller <andyfeller@github.com>
 2025-04-07 14:53:31 -06:00
Kynan Ware
0543aac53c test(prompter): add basic survey prompter test 2025-04-07 12:54:03 -06:00
Kynan Ware
2a851e33e8 test(prompter): fix race conditions 2025-04-07 11:59:05 -06:00
Kynan Ware
f89700160b doc(prompter): clarify comments 2025-04-04 15:08:17 -06:00
Kynan Ware
0b49522467 refactor(prompter): less magic strings 2025-04-04 15:07:21 -06:00