Commit graph

433 commits

Author SHA1 Message Date
Meredith Lancaster
1df2976e81 reduce duplication when creating policy content
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-16 17:06:36 -07:00
Meredith Lancaster
ab4912ff48 fix failing tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-16 12:40:13 -07:00
Meredith Lancaster
e4431a3f55 add mock http client
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-16 12:22:20 -07:00
Meredith Lancaster
fb020f2a79 update error messages
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-16 12:13:22 -07:00
Meredith Lancaster
8f5d7100f5 var naming
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-16 12:02:52 -07:00
Meredith Lancaster
6b95175363 add httpClient field to LiveClient struct
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-16 11:57:45 -07:00
Meredith Lancaster
e51b4efaa9 remove unused method
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-16 11:50:46 -07:00
Meredith Lancaster
5a6a7968a3 fetch bundles with sas url
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-16 11:25:43 -07:00
Meredith Lancaster
08f6e2f943
Merge branch 'trunk' into consolidate-verify-policy-options-config 2024-12-16 08:08:09 -07:00
Meredith Lancaster
64bf37e31c
Merge pull request #10051 from malancas/gh-attestation-download-windows-bug
Use Windows compatible file name for downloaded attestations when running `gh attestation download`
2024-12-16 08:01:36 -07:00
Meredith Lancaster
7160f7ef50 Merge branch 'trunk' into fetch-artifact-attestation-bundles-with-sas-url 2024-12-13 15:25:00 -07:00
Meredith Lancaster
90f5dae82b Merge branch 'trunk' into consolidate-verify-policy-options-config 2024-12-13 15:23:01 -07:00
Meredith Lancaster
9b905d9f18
Merge pull request #9891 from malancas/print-policy-info 2024-12-13 15:14:05 -07:00
Phill MV
dd95e5a863 tweak output of build policy info 2024-12-13 15:55:49 -05:00
Phill MV
c789b56da4
Merge pull request #9954 from cli/phillmv/improve-gh-at-inspect 2024-12-13 09:50:52 -05:00
Meredith Lancaster
76ffe4fb28
Merge pull request #9999 from malancas/sigstore-verifier-cleanup
Sigstore verifier logic updates
2024-12-12 15:10:52 -07:00
Phill MV
cae97c9da8 linting pointed out this var is no longer used 2024-12-12 17:00:02 -05:00
Phill MV
75cbdc0d04 Removed fun, but inaccessible ASCII header 2024-12-12 16:58:26 -05:00
Phill MV
85f9cfdccb further tweaks to the long description 2024-12-12 16:56:02 -05:00
Phill MV
94943eac10 Merge branch 'phillmv/improve-gh-at-inspect' of github.com:cli/cli into phillmv/improve-gh-at-inspect 2024-12-12 16:47:11 -05:00
Phill MV
94525f83f6 Addressed PR review feedback; expanded Long command help string, used ghrepo, clarified some abbreviations 2024-12-12 16:46:58 -05:00
Phill MV
e7f3d739ba
Update pkg/cmd/attestation/inspect/inspect.go
Co-authored-by: Andy Feller <andyfeller@github.com>
2024-12-12 16:20:56 -05:00
Phill MV
19bc3cd886 Removed now redundant file 2024-12-11 17:07:56 -05:00
Phill MV
82a849742e minor tweak to language 2024-12-11 16:58:37 -05:00
Phill MV
7bd59e091f Deleted no-longer-used code. 2024-12-11 16:51:23 -05:00
Phill MV
ac93417c29
Merge branch 'trunk' into phillmv/improve-gh-at-inspect 2024-12-11 16:50:01 -05:00
Phill MV
465b6ff889 deleted now-invalid tests, added a tiny patina of new testing. 2024-12-11 16:48:29 -05:00
Phill MV
bc236db9e5 Tightened up docs, deleted dead code, improved printing 2024-12-11 16:26:08 -05:00
Meredith Lancaster
2418eda1cb fix file name creation on windows
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-11 08:55:11 -07:00
Meredith Lancaster
d42b076a48 wording
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-11 08:13:40 -07:00
Meredith Lancaster
35b5606937 fix download test
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-11 08:04:02 -07:00
Meredith Lancaster
91edde1acb simplify var creation
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-11 07:42:18 -07:00
Meredith Lancaster
9ff3370ff7 use replaceAll
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-10 09:52:56 -07:00
Meredith Lancaster
98a81ffe0f update expected file path on windows
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-10 09:47:15 -07:00
Meredith Lancaster
fb7f2bfea2 Merge branch 'trunk' into gh-attestation-download-windows-bug 2024-12-10 08:25:31 -07:00
Meredith Lancaster
e97d01f265 use different file name for attestation files on windows
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-09 17:32:55 -07:00
Meredith Lancaster
67798b06c0 use github owned oci image
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-06 08:32:16 -07:00
Meredith Lancaster
2b7c6f6a16 add integration test for bundle-from-oci option
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-05 09:58:27 -07:00
Meredith Lancaster
2137a483de include alg with digest when fetching bundles from OCI
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-05 09:27:14 -07:00
Meredith Lancaster
b4dfc9fc72 update tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-04 14:59:10 -07:00
Meredith Lancaster
ee05325e1d update tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-04 14:48:44 -07:00
Meredith Lancaster
4810fc2a74 move content of veriy policy options function into enforcement criteria
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-04 14:30:32 -07:00
Meredith Lancaster
3b043f6350 comment
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-03 12:37:42 -07:00
Meredith Lancaster
efca3bdfd9 try switch statement
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-03 12:34:33 -07:00
Meredith Lancaster
2a6ee87ba0 remove duplicate err checking
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-03 12:29:35 -07:00
Meredith Lancaster
f0f86ecd23 get bundle issuer in another func
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-03 12:22:56 -07:00
Meredith Lancaster
d737d3b933 more logic updating to remove nesting
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-03 12:19:28 -07:00
Meredith Lancaster
1ffd22565d inverse logic for less nesting
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-03 11:52:08 -07:00
Meredith Lancaster
6a7243bb7b remove unneeded nesting
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-03 10:54:22 -07:00
Phill MV
c8e6ac2e6c wip, linting, getting tests to pass 2024-11-26 16:19:05 -05:00