STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
6316 commits 87 branches 0 tags 160 MiB
Commit graph

141 commits

Author SHA1 Message Date
Caleb Brose
2b95cbc5a6 Close port forward writer on reader 2023-01-19 20:22:24 -06:00
David Gardiner
ce6b7d8762 Start SSH server with gRPC 2023-01-10 11:59:56 -08:00
David Gardiner
814fcf8c74 Remove unused token field 2023-01-06 09:56:16 -08:00
David Gardiner
000a84d49b Address comments 2023-01-04 15:33:33 -08:00
David Gardiner
731ba682f2 Create Invoker object 2023-01-04 14:41:25 -08:00
David Gardiner
1e75a74d18 Create centralized Codespaces RPC invoker 2023-01-04 14:41:25 -08:00
Anthony Fok
f6d0f82701
Fix missing text in gh-codespace-ssh.1 man page 
Rearrange the long help text so that '--config' does not appear at the
start of a line which groff interprets as an undefined macro and skips
the content of that whole line.

To reproduce:

  $ go run cmd/gen-docs/main.go --man-page --doc-path /tmp/gh-manpages
  $ man --warnings -E UTF-8 -l -Tutf8 -Z /tmp/gh-manpages/gh-codespace-ssh.1 >/dev/null
  troff: <standard input>:26: warning: macro '--config'' not defined

Discovered by the Debian Lintian tool.
 2022-09-28 14:00:37 -06:00
Caleb Brose
bb6db4b309 PR suggestions 2022-09-20 22:00:27 +00:00
Caleb Brose
4a8047ed61 Improve error handling 2022-09-20 19:36:07 +00:00
Caleb Brose
deedd35a2c Merge branch 'cmbrose/no-ssh-api-call' of https://github.com/cli/cli into cmbrose/no-ssh-api-call 2022-09-20 18:32:01 +00:00
Caleb Brose
373634ad75 Rename to generateAutomaticSSHKeys 2022-09-20 18:32:00 +00:00
Caleb Brose
045bb54157
Apply suggestions from code review 
Co-authored-by: Jose Garcia <josebalius@github.com>
 2022-09-20 13:22:38 -05:00
Caleb Brose
3b52df6f99 Don't add private key for -i 2022-09-20 15:21:59 +00:00
Caleb Brose
dba1259d32 Update tests 2022-09-20 01:02:06 +00:00
Caleb Brose
0c00ca911e Clean up API interface 2022-09-16 22:25:11 +00:00
Caleb Brose
939c7c71cd Remove API call for ssh keys 2022-09-16 22:22:13 +00:00
Caleb Brose
6b24949649
Merge pull request #5958 from cli/cmbrose/no-auto-key-if-uploaded 
Check for already configured ssh keys before using automatic key
 2022-08-23 12:09:16 -05:00
Caleb Brose
d8b06ae8af Add check to -i short circuit for the automatic key 2022-08-16 10:15:43 -05:00
Eljo George
54e5673bd6 remove blank spaces 2022-08-12 21:04:21 +00:00
Eljo George
9f1f74c30a SSH help text to suggest the new features syntax 2022-08-12 21:00:57 +00:00
Caleb Brose
c781ea520a Better .ssh directory 2022-08-10 14:29:14 -05:00
Caleb Brose
3d45244dcc Add -i option to the proxy ssh call in config 2022-08-10 10:57:34 -05:00
Caleb Brose
d410830f7f Handle comment in local ssh key 2022-08-09 11:11:11 -05:00
Caleb Brose
cb914c1873 Cleanup extra param, array declaration 2022-08-09 10:16:24 -05:00
Caleb Brose
b25df2daf4 Merge branch 'trunk' into cmbrose/no-auto-key-if-uploaded 2022-08-09 10:06:37 -05:00
Caleb Brose
0d9b2bf4ce SHort circuit api check if auto keys exist 2022-08-05 18:24:36 +00:00
Eljo George
53bddb0fd5 Update codespaces ssh doc 2022-08-03 19:50:55 +00:00
Caleb Brose
f63d4c0a4a Linter 2022-08-03 15:50:30 +00:00
Caleb Brose
5212fc8d5b Error handling 2022-08-03 15:26:00 +00:00
Caleb Brose
d3c07706a4 Merge branch 'cmbrose/no-auto-key-if-uploaded' of https://github.com/cli/cli into cmbrose/no-auto-key-if-uploaded 2022-08-02 20:57:55 +00:00
Eljo George
ace223d782 updated message 2022-08-01 23:49:49 +00:00
Eljo George
02902e29b4 CS ssh helptext to indicate how to install ssh 2022-08-01 23:08:14 +00:00
Caleb Brose
c9ca2608e6 Invert check 2022-07-22 11:07:57 -05:00
Caleb Brose
414a74b5f5 Even better config support 2022-07-22 11:03:14 -05:00
Caleb Brose
d421664d1f reduce diff 2022-07-17 01:19:42 +00:00
Caleb Brose
6c9d1a9fd4 Switch to using -G instead 2022-07-17 01:09:05 +00:00
Caleb Brose
f313953642 Initial pass 2022-07-16 20:38:23 +00:00
Caleb Brose
b5348f661e Handle case of partial name match 2022-06-29 11:36:27 -05:00
Caleb Brose
1bae759d3e Don't use strings.Replace 2022-06-29 11:10:50 -05:00
Caleb Brose
77ecd0a147 Rename public key first for edge cases 2022-06-29 10:56:31 -05:00
Caleb Brose
2ac379f689 Comment 2022-06-29 10:54:07 -05:00
Caleb Brose
19b5400811 Handle back compat 2022-06-29 10:46:44 -05:00
Caleb Brose
0687f66208
Use codespaces.auto instead for the automatic ssh keys 2022-06-28 16:26:18 -05:00
Mark Phelps
38ea62afba
Codespaces list by repo (#5854) 
* WIP

* Allow to list codespaces by repo

* Tests

* Cleanup

* respond to PR feedback

* Address review comments
 2022-06-28 13:34:04 +00:00
Greggory Rothmeier
4b36dc031f
Add flag to list codespaces under an organization (#5807) 
Co-authored-by: Mislav Marohnić <mislav@github.com>
 2022-06-21 13:57:40 +00:00
Caleb Brose
83153fe9e5 Cleanups from PR comments 2022-06-14 14:33:41 +00:00
Caleb Brose
9f6e1c774b Check for key already exists 2022-06-13 19:31:44 +00:00
Caleb Brose
919dcebc45 Rename Context 2022-06-13 19:16:16 +00:00
Caleb Brose
b5580f9503 Refactor inferfaces from PR comments 2022-06-13 19:04:29 +00:00
cmbrose
ec58990715 Typo 2022-06-10 12:38:10 -05:00