STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
2968 commits 87 branches 0 tags 160 MiB
Commit graph

140 commits

Author SHA1 Message Date
Sam Coe
b9b1079493
Display reviews when viewing pull requests 2021-01-20 12:15:25 -08:00
Mislav Marohnić
b5366c6ebf
Merge pull request #2794 from cristiand391/use-testify-assertion 
Use Testify assertions in tests
 2021-01-19 14:08:25 +01:00
Mislav Marohnić
75ebb863e3 Use testify assertions for error matching 2021-01-19 13:59:37 +01:00
Cristian Dominguez
45f4a1f087 Equal: flip arguments position 2021-01-18 21:00:59 -03:00
Mislav Marohnić
66546e2245 When pr merge --delete-branch flag is supplied, avoid prompting for it 2021-01-18 18:10:20 +01:00
Cristian Dominguez
3afb1d0b1a Use Testify assertions in test 2021-01-16 19:19:30 -03:00
Devon Romanko
df31fae9c6 remove prompt for deleting branches on pr merge in interactive mode when -d flag is passed 2021-01-15 17:34:00 -05:00
Devon Romanko
2c35eb04ff address pr comments 2021-01-15 16:54:46 -05:00
Devon Romanko
85e0e44920 Add prompt to delete local branch when attempting to merge a PR that is already merged 2021-01-15 07:25:24 -05:00
Cristian Dominguez
ce151420f3 Migrate legacy tests 2021-01-11 21:07:19 -03:00
Camelid
8ff4cc40e6 view: Add missing newline 
Add a newline at the end of the 'View this {issue, pull request} on
GitHub' message. `gh repo view` already had a newline at the end, so
this only changes `issue view` and `pr view`.
 2020-12-27 11:37:59 -08:00
Mislav Marohnić
a77f3ddb49
Merge pull request #2575 from cli/pr-view-comments 
Add ability to view comments with `pr view`
 2020-12-15 16:31:03 +01:00
Sam Coe
dee7077fcf
Extract shared comment and reaction group code 2020-12-09 14:35:29 -05:00
Dylan Strohschein
f853a4b0e2 Allow API request to be made if the PR is in an unknown state 2020-12-09 00:25:21 +00:00
Sam Coe
9f101ff0a2
Add comments to pr view 2020-12-08 14:18:05 -05:00
Mislav Marohnić
f4152454f2
Merge pull request #2472 from cristiand391/preserve-metadata-state 
Prompt: avoid resetting PR/issue metadata
 2020-12-03 18:51:29 +01:00
Mislav Marohnić
8db2027c99 Allow interactive pr create even if we failed to look up commits 2020-12-03 18:02:24 +01:00
Mislav Marohnić
be39f4363b Make MetadataSurvey testable by accepting an interface 2020-12-03 17:47:40 +01:00
Mislav Marohnić
d6add864b8 Ensure efficient resolving of issue/pr create metadata to GraphQL IDs 
For metadata types chosen in interactive flow, we fetch all records from
the API in order to be able to display a multi-select interface.

For metadata defined via command-line flags, we resolve records that can
be looked up directly, avoiding fetching the entirety of expensive
datasets (e.g. all members of an organization) if we can.

The new approach ensures efficient fetching when interactive flow is
combined with values from flags.
 2020-12-03 15:53:13 +01:00
Mislav Marohnić
8e1f736775
Merge pull request #2519 from cli/issue-create-browser-fix 
Fix respecting chosen action in interactive `issue create`
 2020-12-02 13:02:16 +01:00
Mislav Marohnić
be759785f0 Fix "Continue in browser" for pr create coming from forks 
Ensures that the `owner:` prefix is present when referencing the head branch
 2020-12-01 21:23:39 +01:00
Max Horstmann
34d549e7b6
Document that reviewers can be teams (#2465) 
Co-authored-by: Mislav Marohnić <mislav@github.com>
 2020-11-26 17:31:15 +01:00
Zach Boyle
1135e5e3ed
set delete-branch merge flag default to false (#2466) 
Co-authored-by: Divya Ramanathan <ramanad@umich.edu>
 2020-11-26 11:54:28 +01:00
Cristian Dominguez
ab05736b98 don't reset previously added metadata 2020-11-25 13:30:54 -03:00
Cristian Dominguez
ea50666c30 Prompt: avoid resetting PR/issue metadata if no option is selected 2020-11-24 13:49:04 -03:00
vilmibm
cf37ce7463 no shorthand for --recover 2020-11-23 11:24:28 -08:00
vilmibm
d6e84a75fb switch to recover instead of resubmit 2020-11-23 11:21:34 -08:00
vilmibm
1d408eb30d linter appeasement 2020-11-23 11:21:28 -08:00
vilmibm
f68909b7a8 use TempFile though the testing is gross 2020-11-23 11:21:28 -08:00
vilmibm
fffd315a7e fix dumb test 2020-11-23 11:21:28 -08:00
vilmibm
d300526318 preserve and restore issue/pr input on failure 2020-11-23 11:21:28 -08:00
Josh Soref
861d350440 spelling: dunno 2020-11-21 21:43:51 -05:00
Josh Soref
ddd438d5e1 spelling: dismissed 2020-11-21 21:43:51 -05:00
Josh Soref
0e681ca6c4 spelling: beginning 2020-11-21 21:43:46 -05:00
Jakub Warczarek
b205faa941
Implement --web for gh pr checks (#2146) 2020-11-17 12:27:07 -06:00
vilmibm
ef52376fe0 fix survey invocation 2020-11-13 10:35:32 -08:00
vilmibm
a686455fb6 add Draft to issue state 2020-11-12 12:17:37 -08:00
vilmibm
b231e6c2cf use NewIssueState 2020-11-12 12:15:48 -08:00
vilmibm
f5277e452e get everything working 2020-11-12 12:03:32 -08:00
vilmibm
0ed7879329 stop using Defaults struct 2020-11-12 12:03:20 -08:00
vilmibm
1c280d4341 stop using string pointer 2020-11-12 12:03:20 -08:00
vilmibm
6671106448 WIP works, probably some title/body input edge cases 2020-11-12 12:03:20 -08:00
vilmibm
6fde02df1c use named output param 2020-11-12 12:02:17 -08:00
Mislav Marohnić
5b4a08dcb9 Ensure that only PATH is searched when shelling out to external commands 
Works around https://github.com/golang/go/issues/38736 for Windows.
 2020-11-11 16:33:13 +01:00
Cristian Dominguez
fa8674386b
Render links as absolute URLs in repo view (#2363) 
Co-authored-by: Cristian Dominguez <cristiand391@users.noreply.github.com>
 2020-11-11 13:13:19 +01:00
Alisson Santos
cf617e88f4 Extract repeated code to util function 2020-11-03 22:05:04 +01:00
Nate Smith
24d863eccc
Merge pull request #2316 from cli/colors-1624 
migrate off of utils color functions
 2020-11-03 12:49:02 -06:00
Sam
d79eb494d9
Merge pull request #2279 from malaDev/1818-pr-checks-empty 
add message on `pr checks` returns no CI with non-empty PR
 2020-11-03 10:14:31 +03:00
Sam Coe
9acbf8aae4
Refactor regexp writer 2020-11-03 09:59:40 +03:00
Sam Coe
bf46b870cb
Add multiple writes test 2020-11-03 09:59:39 +03:00