STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
4648 commits 87 branches 0 tags 160 MiB
Commit graph

293 commits

Author SHA1 Message Date
Gabriel Ramírez
409cd9c388
Fixing Has() issue due to go version 2021-10-05 18:49:41 +00:00
Gabriel Ramírez
777978644c
Adding pagination to list codespaces 2021-10-05 16:49:40 +00:00
Jose Garcia
3652307cf3
Merge pull request #4429 from cli/jg/start-codespace-public 
codespace create: update `API.StartCodespace` to use new API endpoint
 2021-10-05 09:20:33 -04:00
Jose Garcia
a3efb53c44 Update API.StartCodespace to use new API endpoint 
- Switch to using name instead of GUID
- Remove GUID from the code since it is not used anywhere else
- Add docs to the api client methods
- Re-gen mocked client
 2021-10-04 08:32:02 -04:00
Jose Garcia
61af29bb96 Update telemetry path 2021-10-01 13:02:29 -04:00
Jose Garcia
6b1876161d Update DeleteCodespaces to new API endpoint 
- Drop the need for the user argument
- Update mocks
- Remove no longer applicable TODO comment
- Show message for successful deletion (this regressed)
 2021-10-01 12:53:35 -04:00
Jose Garcia
86a4706ed2 Update startCreate to use new API endpoint 
- Updates the signature of startCreate
- Can't update API.CreateCodespace just yet until we support expanded
  access on the GET codespace endpoint which is used for polling
 2021-10-01 11:29:16 -04:00
Jose Garcia
05297b8c8d Update ListCodespaces to use new API endpoint 
- Removes the need for a User to list codespaces which should result in
  a slight speed improvement.
 2021-10-01 10:37:15 -04:00
Jose Garcia
94953ed3fc Merge branch 'trunk' of github.com:cli/cli into jg/move-codespace-api 2021-09-30 11:52:22 -04:00
Jose Garcia
b5bbb442fd Move internal/api to internal/codespaces/api 2021-09-30 11:06:43 -04:00
Jose Garcia
f4a5f82312 Move internal/liveshare to pkg/liveshare 2021-09-30 10:34:27 -04:00
Jose Garcia
2ce14f603f Update tests with mock public key and test case 2021-09-30 08:40:18 -04:00
Jose Garcia
5b5c3da393 Validate host public keys 2021-09-30 08:16:28 -04:00
Jose Garcia
a0f11b6664 Handle concurrency in tests and logger 
- Live Share tests
- Logger implementation for ghcs
 2021-09-29 16:40:40 +02:00
Jose Garcia
0e98b30651 Remove internal crypto pkg in favor of fork 2021-09-29 16:40:31 +02:00
Mislav Marohnić
f749590e87 Replace old "github/ghcs" import statements 2021-09-28 16:57:56 +02:00
Mislav Marohnić
e64607d07b Merge remote-tracking branch 'ghcs/main' into import-codespaces 
Co-authored-by: Jose Garcia <josebalius@github.com>
 2021-09-28 16:46:27 +02:00
Mislav Marohnić
0483765da5 Merge pull request #190 from github/app-struct 
Introduce an App struct that executes core business logic
 2021-09-28 15:46:57 +02:00
Alan Donovan
57d9b1a9e1 create: decode JSON error heuristically 2021-09-27 14:51:52 -04:00
Mislav Marohnić
dc8f6ef183 No longer accept a logger in CreateCodespace 
The API layer shouldn't concern itself with logging progress to stderr.
Instead, we will subsequently add progress indicators in the caller
around CreateCodespace and other potentially slow commands as needed.
 2021-09-24 17:30:31 +02:00
Mislav Marohnić
ca0f89d3bc Introduce an App struct that executes core business logic 
The Cobra commands are now a light wrapper around the App struct.

Co-authored-by: Jose Garcia <josebalius@github.com>
 2021-09-24 17:20:34 +02:00
Mislav Marohnić
92d0abd6ab Merge pull request #79 from github/raffo/delete-codespaces 
Add code and command to delete unused codespaces
 2021-09-24 16:02:05 +02:00
Jose Garcia
5d6ea5029e Linter fixes 2021-09-23 13:36:04 -04:00
Jose Garcia
65dcb0f428 Linter fixes 2021-09-23 13:22:20 -04:00
Jose Garcia
08bc181d79 Linter fixes 2021-09-23 13:16:20 -04:00
Jose Garcia
b8f35f950c Linter fixes 2021-09-23 13:14:35 -04:00
Jose Garcia
c4114cc972 Linter fixes 2021-09-23 11:58:55 -04:00
Jose Garcia
fb53ccb06a Linter fixes 2021-09-23 11:56:41 -04:00
Jose Garcia
958990cef8 More linter fixes 2021-09-23 11:47:52 -04:00
Jose Garcia
d0c65e5490 Linter fixes 2021-09-23 11:36:27 -04:00
Jose Garcia
f4396e8f1a Inline go-liveshare with history 2021-09-23 11:28:04 -04:00
Mislav Marohnić
1232dba684 Merge remote-tracking branch 'origin' into raffo/delete-codespaces 2021-09-23 16:43:22 +02:00
Jose Garcia
3e26a15342 Merge pull request #188 from github/jg/update-liveshare 
Update to go-liveshare v0.20.0
 2021-09-23 10:22:09 -04:00
Jose Garcia
f1c35ba9da Update docs 2021-09-23 10:21:01 -04:00
Jose Garcia
9654dc4bd3 Update to go-liveshare v0.20.0 2021-09-23 10:07:14 -04:00
Jose Garcia
186b90b12e Rename request type 2021-09-23 08:29:24 -04:00
Jose Garcia
13d7804a35 Remove API test, inline poller 2021-09-23 08:26:23 -04:00
Jose Garcia
9a558bc58c Early return if polling is not required 
- Add context to errors in poller
 2021-09-22 15:03:12 -04:00
Jose Garcia
208f1721b5 Rename ProvisionCodespaceParams 2021-09-22 13:21:02 -04:00
Jose Garcia
70a2ea2e6a PR Feedback 
- Rename ProvisionCodespace -> CreateCodespace
- Rename createCodespace -> startCreate
- Additional docs/comments
- Simplify ProvisionCodespaceParams
 2021-09-22 13:19:26 -04:00
Jose Garcia
d2d21996bc Move ProvisionCodespace to API client 
- Make CreateCodespace private along with its errors
 2021-09-22 11:49:41 -04:00
Jose Garcia
8c5330d9e9 Rename error 2021-09-22 10:04:18 -04:00
Jose Garcia
2a0ea1617b Handle specific error for GetCodespaceToken 2021-09-22 09:40:45 -04:00
Jose Garcia
86717f14a1 Implement codespaces.Provision 
- Move polling logic into the Provision function
- Document the behavior expected of callers when an ErrCreateAsyncRetry
  is returned
 2021-09-22 09:09:09 -04:00
Mislav Marohnić
678da44c28 Simplify delete further 2021-09-21 21:09:26 +02:00
Mislav Marohnić
ab86739b6b Merge remote-tracking branch 'origin' into mislav/delete-codespaces 2021-09-21 20:35:58 +02:00
Jose Garcia
d5b03df406 Merge branch 'main' of github.com:github/ghcs into jg/poll-on-async-creation 2021-09-21 14:01:37 -04:00
Jose Garcia
8a53c4369e Merge pull request #179 from github/jg/close-session 
liveshare: close sessions
 2021-09-21 10:14:22 -04:00
Jose Garcia
e8e914c220 PR Feedback 
- Upgrade to go-liveshare v0.19.0
- Remove export helper method
- Use local implementation
 2021-09-21 10:05:48 -04:00
Alan Donovan
0f88081bfa Merge pull request #178 from github/check-authorized-keys 
ghcs ssh: check user has authorised SSH keys
 2021-09-21 10:03:45 -04:00