Kynan Ware
3b93e28910
Fix error mishandling in local ext install
2024-12-12 06:40:37 -07:00
Kynan Ware
ec4b2dfe1b
Assert on err msg directly in ext install tests
2024-12-12 06:38:04 -07:00
Kynan Ware
b9b60637b9
Clarify hosts in ext install help text
2024-12-12 06:35:13 -07:00
Phill MV
19bc3cd886
Removed now redundant file
2024-12-11 17:07:56 -05:00
Phill MV
82a849742e
minor tweak to language
2024-12-11 16:58:37 -05:00
Phill MV
7bd59e091f
Deleted no-longer-used code.
2024-12-11 16:51:23 -05:00
Phill MV
ac93417c29
Merge branch 'trunk' into phillmv/improve-gh-at-inspect
2024-12-11 16:50:01 -05:00
Phill MV
465b6ff889
deleted now-invalid tests, added a tiny patina of new testing.
2024-12-11 16:48:29 -05:00
Phill MV
bc236db9e5
Tightened up docs, deleted dead code, improved printing
2024-12-11 16:26:08 -05:00
Meredith Lancaster
6574327d79
Merge branch 'trunk' into gh-attestation-download-windows-bug
2024-12-11 09:20:35 -07:00
Meredith Lancaster
2418eda1cb
fix file name creation on windows
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-11 08:55:11 -07:00
Meredith Lancaster
d42b076a48
wording
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-11 08:13:40 -07:00
Meredith Lancaster
35b5606937
fix download test
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-11 08:04:02 -07:00
Meredith Lancaster
91edde1acb
simplify var creation
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-11 07:42:18 -07:00
Kynan Ware
e8e30dab6a
Merge branch 'trunk' into issue-10038
2024-12-10 14:17:11 -07:00
Kynan Ware
9d53b86436
Merge pull request #10044 from cli/kw/cli-10034-repo-rename-docs-and-prompt-updates
...
`gh repo rename` help text clarifies new repo name should not include owner
2024-12-10 14:07:08 -07:00
Uday R
40beb82e0c
fix: list branches in square brackets in gh codespace
2024-12-10 15:19:30 -05:00
Meredith Lancaster
9ff3370ff7
use replaceAll
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-10 09:52:56 -07:00
Meredith Lancaster
98a81ffe0f
update expected file path on windows
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-10 09:47:15 -07:00
Meredith Lancaster
fb7f2bfea2
Merge branch 'trunk' into gh-attestation-download-windows-bug
2024-12-10 08:25:31 -07:00
Meredith Lancaster
23a3c18d56
Merge pull request #10020 from malancas/attestation-fetch-integration-tests
2024-12-10 07:56:57 -07:00
Meredith Lancaster
e97d01f265
use different file name for attestation files on windows
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-09 17:32:55 -07:00
Uday R
8afb434e59
test(gh run): assert branch names are enclosed in square brackets
2024-12-09 12:45:36 -05:00
Kynan Ware
167e868fe2
docs: enhance help text and prompt for rename command
2024-12-09 10:16:38 -07:00
William Martin
54a7f4de70
Revert "Confirm auto-detected base branch"
...
This reverts commit e021a07285 .
2024-12-09 13:01:00 +01:00
Nilln
26798213f0
Merge branch 'trunk' into nil/fix-2329
2024-12-09 21:59:25 +11:00
nilvng
5109336963
issue #2329 : include PR status in the prompt's options
2024-12-09 21:22:00 +11:00
nilvng
4bc90101cd
issue #2329 : fix prompt header getting duplicated
...
following the approach in gh run view seems to fix this issue
2024-12-09 21:20:07 +11:00
Heath Stewart
e021a07285
Confirm auto-detected base branch
...
If interactive, confirm the automatically configured gh-merge-branch or, if not configured, the default branch.
Based on PR feedback.
2024-12-08 22:27:00 -08:00
Heath Stewart
5da86e07e7
Merge changes from #10004
...
Merges changes from @williammartin including acceptance tests and word changes.
Co-authored-by: William Martin <williammartin@github.com>
2024-12-08 20:34:21 -08:00
Heath Stewart
88b96f411c
Set gh-merge-base from issue develop
2024-12-08 17:40:03 -08:00
Heath Stewart
3d139019f8
Open PR against gh-merge-base
...
Partly resolves issue #8979 by checking for a `gh-merge-base` branch tag and using that as though it were passed to `gh pr create --base`.
2024-12-08 17:40:00 -08:00
Kynan Ware
b2ab7b84f8
Refactor extension executable error handling
2024-12-08 15:55:09 -07:00
Uday R
463105d648
fix: list branches in square brackets in gh run view ( #10038 )
2024-12-08 12:33:08 -05:00
ANKDDEV
3e0703571e
Merge branch 'cli:trunk' into better-document-auth-scopes
2024-12-07 09:54:58 +03:00
ANKDDEV
a4923de755
docs: update description of command
...
Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
2024-12-06 20:43:54 +03:00
ANKDDEV
0653a5a09c
style: reformat files
2024-12-06 20:04:15 +03:00
ANKDDEV
0e5f26449d
docs: update sentence case
...
Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
2024-12-06 19:38:26 +03:00
Meredith Lancaster
67798b06c0
use github owned oci image
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-06 08:32:16 -07:00
ANKDDEV
24db9f64c7
docs: add mention of scopes help topic in auth refresh command help
2024-12-06 17:06:19 +03:00
ANKDDEV
53ee6ae56f
docs: add mention of scopes help topic in auth login command help
2024-12-06 17:04:59 +03:00
ANKDDEV
419a01271a
docs: add help topic for auth scopes
2024-12-06 17:03:31 +03:00
ANKDDEV
694e209142
docs: improve help for browse command
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2024-12-06 16:33:57 +03:00
ANKDDEV
3e647385f7
docs: improve docs for browse command as of #5352
2024-12-06 13:45:22 +03:00
nilvng
409e3ca08c
issue #2329 : simplify the UI of the prompt
...
This commit reverts the previous color changes in the prompt UI. While color highlighting could potentially improve the visual appealing of the prompt
using the existing color library (mguz/ansi) with the prompt library (AlecAivazis/survey) caused unintended side effects.
It reset the bold text style for the selected option. We decide to that
bold text style would have a higher priority than the color text ,for
three reasons:
1. To maintain consistency with other prompts in the UI and prioritize accessibility
2. While color can enhance the user experience, according to Primer Design Guidelines, color should not be relied upon to convey essential information.
3. visual indicator of the selected option, especially crucial when dealing with long PR titles or branch names.
As a future improvement, we may consider a separate issue or PR to address the color library issue and explore controlled color usage in prompts. This could potentially allow for more nuanced visual differentiation while avoiding unintended style resets.
Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
2024-12-06 19:59:46 +11:00
nilvng
eced54c904
issue #2329 : update the prompt's format
...
Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
2024-12-06 18:49:43 +11:00
nilvng
12479e3072
issue #2329 : fix unit tests
2024-12-06 18:19:07 +11:00
Andy Feller
d60e5ffba3
Merge pull request #10016 from cli/andyfeller/cli-cli-10013-pr-checks-json-watch-mutex
...
Error for mutually exclusive json and watch flags
2024-12-05 12:22:24 -05:00
Meredith Lancaster
2b7c6f6a16
add integration test for bundle-from-oci option
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-05 09:58:27 -07:00
Andy Feller
acfdae466e
Merge pull request #10009 from cli/wm/safepaths
...
Use safepaths for run download
2024-12-05 11:43:10 -05:00