STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
7230 commits 87 branches 0 tags 160 MiB
Commit graph

7230 commits

This branch
This branch
All branches
Author SHA1 Message Date
Mislav Marohnić
3b7e5fc246 Store Executable() information on codespaces App 
This is to avoid having to explicitly pass it to each subcommand that
needs it. Each codespaces command runs in the context of App, so that's
a point of shared context that we can store state in.
 2021-12-21 14:03:10 +01:00
Mislav Marohnić
3cce16e72d Refactor factory.Executable() to be a method rather than a func 
This way, factory can satisfy an interface that requires `Executable()`.
 2021-12-21 13:50:55 +01:00
Mislav Marohnić
8272035aac
Merge pull request #4534 from lpessoa/lp-secret-load-env 
Adding set secrets from env files

Closes #3610
 2021-12-20 23:43:48 +01:00
Mislav Marohnić
95a71f75c5 Improve setting multiple secrets 
- Store multiple secrets in parallel
- Perform repo ID resolution in parallel with looking up the encryption key
- Avoid resolving repo IDs more than once
- Allow passing `--env-file=-` to read from stdin
- Fix storing user secrets from file
 2021-12-20 23:35:31 +01:00
lpessoa
5589583e4d Adding set secrets from env files 
Allows to set multiple secrets from an env file.

    gh secret set -f secrets.env

The env file follows a simple format as defined in https://github.com/joho/godotenv

    SPAM=eggs
    FOO="bar"
 2021-12-20 23:33:54 +01:00
Jason Lunz
38eb894d73
prevent leaking any blocked goroutines on error 2021-12-20 13:57:53 -07:00
Jason Lunz
932c9da473
clean up inadvertently truncated help message 2021-12-20 13:57:53 -07:00
Jason Lunz
7bd6fe9af8
maximize the time checkAuthorizedKeys has to run concurrently 
Also, other than that, restore the original ordering of this function
 2021-12-20 13:57:53 -07:00
Jason Lunz
a864985f0a
use WaitGroup for a more idiomatic concurrency pattern 2021-12-20 13:57:53 -07:00
Jason Lunz
81b34d272c
inline openSSHSession 2021-12-20 13:57:53 -07:00
Jason Lunz
28dd73ffdf
always pass a non-nil logger to openSSHSession 2021-12-20 13:57:53 -07:00
Jason Lunz
37f8039f76
merge ensureAuthorizedKeys into checkAuthorizedKeys 2021-12-20 13:57:52 -07:00
Jason Lunz
ae3aacb964
fix errcheck linter warning 2021-12-20 13:57:52 -07:00
Jason Lunz
6b34fa2a27
oh look, struct definitions can be scoped! 2021-12-20 13:57:52 -07:00
Jason Lunz
f22be4a03d
use a more robust method to get the executable path 
cmdutil.Factory.Executable() accounts for things like package managers
and symlinks to the actual executable.

An alternative to passing the *cmdutil.Factory down the stack would be
stashing the executable string in the codespace.App, which works (and
the diff is smaller), but it produced some odd non-local test failures.
This way seems less mysterious and more like other uses of Factory in
the codebase.
 2021-12-20 13:57:52 -07:00
Ayush Rawal
ca25026613
Avoid showing non-open PRs on the default branch (#4285) 
Co-authored-by: Andrew Hsu <xuzuan@gmail.com>
Co-authored-by: Mislav Marohnić <mislav@github.com>
 2021-12-20 18:46:12 +00:00
Cristian Dominguez
f2d23d8c88
Allow editing commit subject when squash-merging a PR (#3344) 
Co-authored-by: Mislav Marohnić <mislav@github.com>
 2021-12-20 18:25:17 +00:00
Mislav Marohnić
9f2639e8cd
Merge pull request #4939 from cli/man-refresh 
Refresh man pages
 2021-12-20 18:29:34 +01:00
Mislav Marohnić
31c7181297 Refresh man pages 
- Fix name of man pages for all but the toplevel command
- Set title of all man pages to "GitHub CLI manual"
- Include gh version information in man pages
- Clean up rendering of flags section
- List subcommands for every command
 2021-12-20 18:11:31 +01:00
Mislav Marohnić
17291d1d5f
Merge pull request #4936 from cli/bump-cobra 
Bump Cobra to 1.3.0
 2021-12-20 17:41:07 +01:00
Mislav Marohnić
dac771e088
Merge branch 'trunk' into bump-cobra 2021-12-20 16:35:44 +01:00
Mislav Marohnić
58864f4cff
Merge pull request #4937 from cli/bump-spinner 
Bump spinner to 1.18.0
 2021-12-20 16:34:41 +01:00
Mislav Marohnić
9605f9f4f2
Unconditionally resolve "ssh.github.com" to "github.com" (#4938) 2021-12-20 16:34:19 +01:00
Mislav Marohnić
c240ab9137 Unconditionally resolve "ssh.github.com" to "github.com" 
Previously, only "github.com" mapped to "ssh.github.com" via ssh config
was treated as "github.com". Now, any "ssh.github.com" host is treated
as "github.com", even if it was initially aliased as something else in
the user's ssh hostname mappings.
 2021-12-20 16:09:46 +01:00
Mislav Marohnić
69eec45fe2 Bump spinner to 1.18.0 2021-12-20 16:00:42 +01:00
Mislav Marohnić
344f758406 Bump Cobra to 1.3.0 2021-12-20 12:40:45 +01:00
Benny Siegert
0aaa334edf
Add installation instructions for NetBSD/pkgsrc (#4931) 
Co-authored-by: Mislav Marohnić <mislav@github.com>
 2021-12-20 10:00:57 +00:00
Jason Lunz
7b432de5c2
use heredoc helper for config template 2021-12-17 17:09:06 -07:00
Jason Lunz
b2598d64f9
start codespace to fetch config if it's explicitly requested 
When running `gh cs ssh config` without a `-c` option, we skip
codespaces that aren't available. This change suppresses that behavior
when a single codespace is explicitly requested, starting the codespace
if it's not running.
 2021-12-17 17:08:58 -07:00
Jason Lunz
61823997c2
always verify authorized keys in parallel with other work, and at most once 2021-12-17 16:46:53 -07:00
Jason Lunz
0af268da4e
properly indent ssh config example 2021-12-17 16:11:55 -07:00
Jason Lunz
06eb5ad47f
fetch remote ssh usernames in parallel 2021-12-17 16:10:44 -07:00
Jason Lunz
2ee88da647
close session on error 2021-12-17 14:42:54 -07:00
Jason Lunz
a05541f4ed
drop redundant API call 2021-12-17 11:39:14 -07:00
Jason Lunz
0670a7758b
use generic io interfaces 2021-12-17 11:18:59 -07:00
Jason Lunz
811d6505d2
tighten up ssh config help wording 2021-12-17 11:03:11 -07:00
Jason Lunz
206b6379c3
return non-zero if ssh config skips any codespaces 2021-12-17 10:47:22 -07:00
Cristian Dominguez
ddaef8baa4
Add --json export flag for workflow runs (#3869) 
Co-authored-by: Mislav Marohnić <mislav@github.com>
 2021-12-17 15:55:45 +00:00
Mislav Marohnić
0607ce56c5
Merge pull request #4920 from simi/patch-1 
Update StateDir comment to mention XDG_STATE_HOME.
 2021-12-17 14:10:30 +01:00
Jason Lunz
a9d02a746b
push fetching codespace details into openSSHSession callers 2021-12-16 17:19:34 -07:00
Jason Lunz
ac685611b1
openssh -> OpenSSH 2021-12-16 17:00:40 -07:00
Jason Lunz
71c9fa11f0
add more ssh config --help documentation 2021-12-16 17:00:40 -07:00
Jason Lunz
369ea534b6
explain why failure to connect to a codespace doesn't fail the entire command 2021-12-16 17:00:39 -07:00
Jason Lunz
4a6887f99e
add a comment explaining why we build an sshUsers map 2021-12-16 17:00:38 -07:00
Jason Lunz
6f8635a17e
listOpensshConfig -> printOpenSSHConfig 2021-12-16 17:00:37 -07:00
Jason Lunz
b7cd2bbc72
no need to separately declare vars here 2021-12-16 17:00:37 -07:00
Jason Lunz
3cb3cf7ca5
make ListOpensshConfig private 2021-12-16 17:00:36 -07:00
Jason Lunz
96a2e125e6
document the codespaceSSHConfig struct 2021-12-16 17:00:36 -07:00
Jason Lunz
ca3b59dd35
use struct embedding to express this less verbosely 2021-12-16 16:09:33 -07:00
Jason Lunz
ac3b0c50e3
Ssh -> SSH 2021-12-16 16:09:32 -07:00