STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
8947 commits 87 branches 0 tags 160 MiB
Commit graph

37 commits

Author SHA1 Message Date
William Martin
0ead3398a7 Bump golang ci lint to work with go 1.24 2025-01-21 17:55:39 +01:00
Zach Steindler
658f125ab3
Update sigstore-go in gh CLI to v0.5.1 (#9366) 
Signed-off-by: Zach Steindler <steiza@github.com>
 2024-07-25 20:59:39 +02:00
Matthew Hughes
0d6bd6d53c Fix cache contention in Go CI jobs 
Fix the `Set up go` and `Restore Go modules cache` steps both trying to
read/write the same contents. Since the `setup-go` step runs first this
results in the "restore cache" step trying to write the same contents
under `~/go/pkg/mod` which results in errors like (e.g. random
example[1]):

    /usr/bin/tar -xf /home/runner/work/_temp/6d12957f-f226-455e-b99c-fa7ee8c962cb/cache.tzst -P -C /home/runner/work/cli/cli --use-compress-program unzstd
    /usr/bin/tar: ../../../go/pkg/mod/golang.org/x/net@v0.21.0/go.sum: Cannot open: File exists
    Error: /usr/bin/tar: ../../../go/pkg/mod/golang.org/x/net@v0.21.0/proxy/proxy.go: Cannot open: File exists
    Error: /usr/bin/tar: ../../../go/pkg/mod/golang.org/x/net@v0.21.0/proxy/socks5.go: Cannot open: File exists
    Error: /usr/bin/tar: ../../../go/pkg/mod/golang.org/x/net@v0.21.0/proxy/dial_test.go: Cannot open: File exists

Since restoring fails, the cache job thinks no cache hit was made and
proceeds to try and save, but since it may well have fetched a valid
cache this can also error (again, see[1]):

    Post job cleanup.
    /usr/bin/tar --posix -cf cache.tzst --exclude cache.tzst -P -C /home/runner/work/cli/cli --files-from manifest.txt --use-compress-program zstdmt
    Failed to save: Unable to reserve cache with key go-Linux-1b4ae53bfd76c3b70f62d419e17f36544d0a1331f04b13d2a942e7752e3789c3, another job may be creating this cache. More details: Cache already exists. Scope: refs/heads/trunk, Key: go-Linux-1b4ae53bfd76c3b70f62d419e17f36544d0a1331f04b13d2a942e7752e3789c3, Version: 2a8d0f2be1a88abb057cd9fcea9832bd16e7ab71798dbf93cd890eb9add83cf6

To avoid this, just rely on the caching functionality of the `seutp-go`
action.

For some context, It appears this cache behaviour was added with
cb7315c85d when these workflows were still
run with `setup-go@v2`:

    $ git show cb7315c85d3c0e010ba117ca7e692ed6f18f16c5:{.github/workflows/go.yml,.github/workflows/lint.yml} | grep 'actions/setup-go'
            uses: actions/setup-go@v2
            uses: actions/setup-go@v2

which is before caching behaviour was added (with `v3.2.0`[2]).

[1] https://github.com/cli/cli/actions/runs/8654869114/job/23732868571
[2] https://github.com/actions/setup-go/releases/tag/v3.2.0
 2024-04-12 17:36:45 +01:00
William Martin
200c95e5b2
Rely on go.mod go version in all workflows (#8911) 2024-04-02 13:22:31 +00:00
Naoya Yasuda
5d79a95a32
Upgrade to Go 1.22 (#8836) 2024-04-02 14:34:59 +02:00
dependabot[bot]
32ab65fd77
build(deps): bump actions/cache from 3 to 4 (#8594) 
Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](https://github.com/actions/cache/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-01-18 07:37:49 -08:00
dependabot[bot]
5d780dabf1
build(deps): bump actions/setup-go from 4 to 5 
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](https://github.com/actions/setup-go/compare/v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-12-07 14:29:50 +00:00
dependabot[bot]
f9df89da0f
build(deps): bump actions/checkout from 3 to 4 (#7937) 
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2023-09-05 04:06:24 +02:00
Sam Coe
4a57a812f5
Upgrade to Go 1.21 (#7843) 2023-08-16 10:37:58 -07:00
dependabot[bot]
d905165875
Bump actions/setup-go from 3 to 4 (#7177) 
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 3 to 4.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](https://github.com/actions/setup-go/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2023-03-16 09:22:02 +11:00
Mislav Marohnić
684a4c5c8c
bump golangci-lint 2022-12-12 16:49:19 +01:00
Mislav Marohnić
ba4d50452d
Update to Go 1.19 
With this upgrade our codebase adopts the stricter handling of `os/exec` command lookup in it that it doesn't allow shelling out to a command in the current directory.
 2022-12-12 15:50:13 +01:00
Sam Coe
06fb78aa26
Re-enable linters now that golangci-lint has been updated (#5615) 2022-05-11 16:57:57 +02:00
Sam Coe
597eb16a83
Upgrade to go 1.18 (#5542) 2022-05-09 18:46:19 +02:00
dependabot[bot]
3427d17401
Bump actions/setup-go from 2 to 3 (#5425) 
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 2 to 3.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](https://github.com/actions/setup-go/compare/v2...v3)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-04-14 09:39:05 +02:00
dependabot[bot]
b090ef0578
Bump actions/cache from 2 to 3 
Bumps [actions/cache](https://github.com/actions/cache) from 2 to 3.
- [Release notes](https://github.com/actions/cache/releases)
- [Commits](https://github.com/actions/cache/compare/v2...v3)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-03-21 14:27:30 +00:00
Mislav Marohnić
d4ead71d06
Merge pull request #5298 from cli/bump-golangci-lint 
Bump golangci-lint version
 2022-03-14 15:27:37 +01:00
neilnaveen
07e0e52edd
Fixed permission for workflow (#5279) 
https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions

Co-authored-by: Mislav Marohnić <mislav@github.com>
 2022-03-14 14:18:21 +01:00
Mislav Marohnić
9278f51aa8 Bump golangci-lint version 2022-03-11 14:58:15 +01:00
Mislav Marohnić
cb7315c85d Re-initialize modules cache in CI 2022-03-10 18:29:42 +01:00
dependabot[bot]
0cce0e1543
Bump actions/checkout from 2 to 3 
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v2...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-03-02 14:29:49 +00:00
Mislav Marohnić
eb78ac0dcb Require Go 1.16+ 2021-08-23 18:08:09 +02:00
Mislav Marohnić
f18929cf3d Increase linter timeout from 1min to 3min 
Hopefully avoids CI failures like https://github.com/cli/cli/runs/2379956774
 2021-04-19 12:53:52 +02:00
Mislav Marohnić
19ee0eff08 Simplify linter output setup 
`golangci-lint` now supports an output formatter for GitHub Actions, so
we don't need to manually reformat the failure output anymore.
 2021-01-07 16:16:44 +01:00
Shoma Okamoto
06b579c976 update go version 2020-08-13 22:22:27 +09:00
Mislav Marohnić
41f7b054e6 Bump golangci-lint to v1.29.0 
Trying to address https://github.com/cli/cli/pull/1406/checks?check_run_id=896316941
which I cannot reproduce locally on macOS
 2020-07-22 14:18:18 +02:00
Mislav Marohnić
9c7d52f9f6 Bump golangci-lint 2020-07-02 17:02:38 +02:00
Davor Kapsa
26185467a8
update lint.yml 2020-06-09 14:34:41 +02:00
Mislav Marohnić
cd163f020c Fix linter in CI 
It turns out that YAML anchors are not supported
https://github.com/cli/cli/actions/runs/115915028
 2020-05-26 18:28:19 +02:00
Mislav Marohnić
54e68ae5b2 Enable linting for pull requests 2020-05-22 19:40:00 +02:00
Mislav Marohnić
1fb27af96b Bump golangci-lint 2020-05-07 21:04:44 +02:00
Mislav Marohnić
0eb471899a Upgrade to Go 1.14 in CI 2020-05-07 21:03:42 +02:00
Mislav Marohnić
26ee7baf67 💅 indent 2020-04-13 17:16:47 +02:00
Mislav Marohnić
4e393fdab4 Avoid intermittent CI failures while setting up Go 
Switch to `actions/setup-go@v2-beta` which advertises better retries
around downloading the Go version
 2020-04-13 17:15:59 +02:00
Mislav Marohnić
ee2456f3c0 Don't build during linting 
Building is already covered in CI workflows that run tests
 2020-04-03 16:51:47 +02:00
Mislav Marohnić
7ba9773e68 Make golangci-lint failures fatal ☠️ 2020-04-03 16:51:43 +02:00
Mislav Marohnić
876e825e64 Check code with golangci-lint on push 
Right now linting failures don't fail the CI job, but they might in the
future.
 2020-04-02 14:55:13 +02:00