Andy Feller
4f8d2f71e4
Moving options to metadata
2023-12-08 17:33:52 -05:00
Andy Feller
4054968fc3
Fix Dlib DLL path
...
Mixed up Unix and Windows path separators
2023-12-08 17:30:28 -05:00
Andy Feller
0af95d9314
Remove previous hsm test workflow
2023-12-08 17:29:19 -05:00
Andy Feller
5e8e645a7f
Update HSM test using Desktop approach
...
This update leverages GitHub Desktop approach of downloading Azure Code Signing DLL and wiring it up as part of the existing signing process used by Windows builds.
2023-12-08 17:27:22 -05:00
Andy Feller
dea2cd5fe1
Create HSM testing workflow
...
This commit is an initial prototype based on the deployment workflow, using the
Azure Code Signing service to sign Windows .exe and .msi files.
These changes have been isolated as much as possible to not affect existing
deployment workflows while also working around design issues with how GitHub
CLI workflow works with GoReleaser and now with ACS support. The biggest smell
was over whether to break from using GoReleaser or have GoReleaser control as
much about the release process as it has been versus opening / signing /
archiving the resulting GoReleaser artifacts; needless to say, the latter was
chosen for expedience as well as leaning into officially supported solutions.
2023-12-05 15:24:50 -05:00
nelsonchen304
3bb62d4724
Actions: filter to workflow runs for a specific commit ( #8350 )
2023-11-29 09:29:26 +00:00
Mika
2f31607096
Add timeout error in gh auth status ( #8337 )
2023-11-29 08:54:55 +00:00
David Gardiner
36bbcdd663
Merge pull request #8361 from mateusmarquezini/fix/issue_8356
...
Added a new error handling when the display name flag exceeds 48 characters
2023-11-28 12:03:32 -08:00
Mateus Marquezini
1d13d1fbed
Merge branch 'trunk' into fix/issue_8356
2023-11-28 16:29:24 -03:00
Mateus Marquezini
7a32b8b5f3
some code improvements after code review
2023-11-27 17:17:24 -03:00
Andy Feller
6309446162
Merge pull request #8384 from cli/wm/fix-project-unmarshaling
...
Fix project status unmarshaling
2023-11-27 12:50:31 -05:00
William Martin
e775bc64b8
Fix PR and Issue list
...
Separate the GQL and JSON decoded types that we use for queries.
2023-11-27 17:00:10 +01:00
William Martin
7aeccdb7a0
Update pkg/cmd/pr/shared/finder_test.go
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2023-11-27 15:18:13 +01:00
Sam Coe
e843349a13
Extract Project Status into fragment to fix unmarshal error
2023-11-27 15:01:22 +01:00
William Martin
65d63e1bc9
Add test for ProjectV2Item query Status column
2023-11-27 10:53:19 +01:00
William Martin
b96a8e3c01
Add PR Finder test to cover projectItems
2023-11-27 10:40:09 +01:00
Mateus Marquezini
7af33d090a
added a new error handling when the display name flag exceeds 48 characters #8356
2023-11-20 18:45:12 -03:00
Sam Coe
06e438b4b4
Update to latest go-gh ( #8359 )
2023-11-20 16:11:36 +00:00
EBIBO
14a8e03bc3
gh repo sync should be able to sync a local branch with an upstream remote (#8229 )
2023-11-20 10:37:59 +00:00
dependabot[bot]
a74a71e048
build(deps): bump github.com/creack/pty from 1.1.20 to 1.1.21 ( #8345 )
...
Bumps [github.com/creack/pty](https://github.com/creack/pty ) from 1.1.20 to 1.1.21.
- [Release notes](https://github.com/creack/pty/releases )
- [Commits](https://github.com/creack/pty/compare/v1.1.20...v1.1.21 )
---
updated-dependencies:
- dependency-name: github.com/creack/pty
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-11-17 16:04:42 +01:00
Sam Coe
3f37d7e372
Fix query for project item status field ( #8332 )
2023-11-14 17:27:50 +01:00
Qiming Xu
5e14987d65
Fix determining executable location in PATH ( #8238 )
2023-11-14 08:26:19 +00:00
Sam Coe
ebcf3a1022
Set default Accept header for api command when one is not specified ( #8303 )
2023-11-06 15:22:32 +01:00
William Martin
515b85480f
Merge pull request #8301 from cli/wm/minor-annotation-fetch-error-simplification
...
Simplify run view annotation fetch error handling
2023-11-06 13:46:19 +01:00
William Martin
8364301017
Simplify run view annotation fetch error handling
2023-11-06 12:40:13 +01:00
Yukai Chou
ccf45cc7c6
Improve gh release download doc ( #8294 )
...
* Improve `gh release download` doc
When downloading latest release assets,
`gh release download --archive=(zip|tar.gz)` works too.
Sync doc with no-arguments warning.
* Apply suggestion from code review
Co-authored-by: Sam Coe <samcoe@users.noreply.github.com>
---------
Co-authored-by: Sam Coe <samcoe@users.noreply.github.com>
2023-11-06 07:59:03 +00:00
William Martin
f41f402a20
Merge pull request #8286 from cli/dependabot/go_modules/github.com/henvic/httpretty-0.1.3
...
build(deps): bump github.com/henvic/httpretty from 0.1.2 to 0.1.3
2023-11-03 15:41:48 +01:00
David Gardiner
ecdb557156
Merge pull request #8275 from dmgardiner25/fix-cs-conn-race
...
Resolve race condition in codespaces connection
2023-11-02 09:52:03 -07:00
dependabot[bot]
b0252989eb
build(deps): bump github.com/henvic/httpretty from 0.1.2 to 0.1.3
...
Bumps [github.com/henvic/httpretty](https://github.com/henvic/httpretty ) from 0.1.2 to 0.1.3.
- [Commits](https://github.com/henvic/httpretty/compare/v0.1.2...v0.1.3 )
---
updated-dependencies:
- dependency-name: github.com/henvic/httpretty
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-11-02 14:18:44 +00:00
William Martin
28d3628c5b
Merge pull request #8202 from mattruggio/mattruggio/add-status-column-value-to-project-items
...
Include Project Item Status for Issues and Pull Requests
2023-11-01 17:57:19 +01:00
William Martin
8a9eb7bfc2
Add tests for issue and PR project items query building
2023-11-01 17:40:29 +01:00
Arun Sathiya
5eff7a529a
fix(release create): Handle latest flag value when updating the release after assets are uploaded ( #8207 )
...
Signed-off-by: Arun <arun@arun.blog>
Co-authored-by: William Martin <williammartin@github.com>
2023-11-01 15:17:05 +01:00
dependabot[bot]
534f6d7978
build(deps): bump github.com/creack/pty from 1.1.18 to 1.1.20 ( #8265 )
...
Bumps [github.com/creack/pty](https://github.com/creack/pty ) from 1.1.18 to 1.1.20.
- [Release notes](https://github.com/creack/pty/releases )
- [Commits](https://github.com/creack/pty/compare/v1.1.18...v1.1.20 )
---
updated-dependencies:
- dependency-name: github.com/creack/pty
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: William Martin <williammartin@github.com>
2023-11-01 10:34:47 +01:00
David Gardiner
d22c6f33e9
Update comment
2023-10-31 13:12:25 -07:00
David Gardiner
d04a9d941f
Lock the Close func
2023-10-31 13:11:28 -07:00
David Gardiner
1bcf92438a
Defer the mutex unlock
2023-10-31 13:08:34 -07:00
David Gardiner
b566ea670c
Add mutex for connect
2023-10-31 13:01:24 -07:00
David Gardiner
581b6652e2
Resolve race condition in codespaces connection
2023-10-31 12:19:14 -07:00
Adarsh Jha
351c5f1cd5
feat: modified choice input to take option list opposed to blank text ( #8180 )
2023-10-31 17:48:49 +01:00
William Martin
ede1705bf2
Ensure good link in triage discussion
2023-10-31 10:02:42 +01:00
William Martin
b2c445f4b9
Ensure variables get passed in discussion triage
2023-10-31 09:58:30 +01:00
William Martin
6782120254
Update discussion triage types to ID
2023-10-31 09:55:29 +01:00
William Martin
4213e3e2b4
Update secret name to not be prefixed with GITHUB
...
Apparently this isn't allowed
2023-10-31 09:49:46 +01:00
William Martin
09b81ff545
Create private discussion for issues labelled discuss ( #8264 )
2023-10-31 09:44:31 +01:00
David Gardiner
500f359592
Don't poll for addition codespace permissions if user chooses to create without them ( #8267 )
2023-10-30 13:22:38 -05:00
Sam Coe
7924878315
Fix git protocol and refactor Config interface ( #8246 )
2023-10-27 15:42:05 +02:00
dependabot[bot]
ce7d89de0c
build(deps): bump google.golang.org/grpc from 1.53.0 to 1.56.3 ( #8251 )
...
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go ) from 1.53.0 to 1.56.3.
- [Release notes](https://github.com/grpc/grpc-go/releases )
- [Commits](https://github.com/grpc/grpc-go/compare/v1.53.0...v1.56.3 )
---
updated-dependencies:
- dependency-name: google.golang.org/grpc
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-26 08:44:31 +02:00
Sam Coe
20baccfa85
Add default configuration back from go-gh ( #8244 )
2023-10-24 13:23:31 +02:00
William Martin
08bc4cbb5e
Merge pull request #8235 from ffalor/issue_8218
...
clearer error message
2023-10-23 19:12:32 +02:00
ffalor
f4535004c2
clearer error message
2023-10-23 00:39:25 -05:00