Mislav Marohnić
512208ca96
repo fork: tweak docs
2022-02-18 18:38:34 +01:00
Nate Smith
e17964cf03
Merge pull request #5092 from cli/repo-fork-proto
...
prefer configured git protocol when forking
2022-01-26 11:33:47 -06:00
nate smith
667671f048
fix race condition, increase clarity
2022-01-25 15:36:41 -06:00
nate smith
bd6e50a08a
Merge remote-tracking branch 'origin/trunk' into feature/target-repo-fork-name
2022-01-25 14:08:27 -06:00
nate smith
0d214864d9
linter appeasement
2022-01-24 17:01:19 -06:00
nate smith
170a50fcc8
prefer configured git protocol when forking
2022-01-24 16:54:01 -06:00
Mislav Marohnić
44775f87c8
Add nolint directives to allow-list current lint violations
2022-01-14 19:52:52 +01:00
Gowtham Munukutla
3fb4c481dc
modify tests
2021-12-11 10:17:04 +05:30
Mislav Marohnić
11fbb60ae7
Rename the module to "github.com/cli/cli/v2"
2021-08-25 12:41:30 +02:00
camille folch
54b86c7093
repo fork: check that --org is not the empty string
...
As it is already being done for --remote-name, except in this case
the default is the empty string.
2021-06-11 23:28:41 -03:00
Nate Smith
b0998772ae
more cleanup
2021-06-10 21:46:02 +00:00
Nate Smith
f31a31e2ed
stop stubbing out a Since function
2021-06-10 21:46:02 +00:00
vilmibm
4a7ec7f4f6
cleaning up fork tests
2021-06-10 21:45:54 +00:00
Mislav Marohnić
3cbd5b4934
Add repo fork --org functionality ( #3611 )
...
Co-authored-by: Gowtham Munukutla <gowtham.m81197@gmail.com>
2021-05-10 17:09:03 +02:00
Gowtham Munukutla
5caf01c564
add test for non tty fork
2021-04-01 10:49:12 +05:30
Nate Smith
e91b97b4c5
fully restore fork remote renaming behavior ( #2982 )
...
* fully restore fork remote renaming behavior
* catch blank remote name and error + arg tests
* hard wrap fork usage
* do not rename if remote-name supplied
* tweak error text
2021-02-17 12:33:22 -06:00
vilmibm
d051f0634f
update tests
2021-01-22 16:13:39 -08:00
Mislav Marohnić
06cf2c9f81
Merge remote-tracking branch 'origin' into cmd-stub-new
2021-01-22 16:31:29 +01:00
vilmibm
48c89076f6
add positive case test
2021-01-21 12:04:19 -08:00
vilmibm
a27a94f8b5
Merge remote-tracking branch 'origin/trunk' into repo-fork-gitflags
2021-01-21 11:58:20 -08:00
Mislav Marohnić
4158209d50
Merge pull request #2811 from cli/utils-spinner-buh-bye
...
Retire utils.Spinner in favor of IOStreams.StartProgressIndicator
2021-01-21 17:34:39 +01:00
vilmibm
509e5dd0c9
fix tests
2021-01-20 16:10:56 -08:00
Mislav Marohnić
aa0de5f636
Stop using utils.Spinner in repo fork
2021-01-20 14:46:45 +01:00
Mislav Marohnić
fc77cbc964
Deprecate test.ExpectLines
...
For asserting command output, exact string matches are preferred in most cases. In cases when a pattern match is needed, the test can use regexp ad hoc.
2021-01-18 23:25:45 +01:00
Mislav Marohnić
5531498f27
Migrate to new cmd stubber in repo fork tests
2021-01-18 22:42:27 +01:00
Nate Smith
05a1a25271
match parent repo protocol when forking ( #2434 )
...
* match parent repo protocol when forking
* guard against nil and prefer PushURL
2020-11-20 12:00:49 -06:00
Cristian Dominguez
69b64507ea
Add support for git flags in gh repo fork
2020-10-23 19:08:55 -03:00
vilmibm
10422e87eb
just use simple bool flags
...
the original complexities here were because I thought there was a
shortcoming in cobra's bool support and I was wrong.
2020-07-27 13:04:31 -05:00
vilmibm
f3eb092d7e
isolate repo fork command and tweak usage
...
This commit is another isolation refactor, this time for repo fork.
However, I got fed up with the --remote="true|false|prompt" style of
flags and took this opportunity to switch to a set of bool flags:
--remote and --clone
--no-remote and --no-clone
the string args were really non standard and confusing; with only two
bools it was impossible to tell when to prompt.
2020-07-27 13:04:31 -05:00
