Commit graph

18 commits

Author SHA1 Message Date
Mislav Marohnić
70a9621928 💅 cleanup in gist create 2021-05-07 14:15:27 +02:00
Gowtham Munukutla
cc94dc762d shift gist validation to server rather than client 2021-05-07 14:12:00 +02:00
Mislav Marohnić
44ae7ae3cf
Merge pull request #3279 from cli/browser-refactor
Pass web browser to each individual command
2021-03-30 16:54:59 +02:00
Sam
9ec1e21d4c
Default to GHES host if only GHES is authenticated (#3286) 2021-03-30 16:51:00 +02:00
Mislav Marohnić
111e8dbcf2 Pass web browser to each individual command
This removes sensitivity to the BROWSER environment variable in tests
and makes it easier to verify the URL that the browser was invoked with
without having to stub sub-processes.
2021-03-19 21:22:37 +01:00
Mislav Marohnić
c63acf6728 Migrate to new cmd stubber in misc. tests 2021-01-18 22:42:01 +01:00
Christopher Oswald
0bb44c9ced
Support for --web when using gist create (#2263)
* Support for --web when using gist create

Proposal to close #2071

I have not worked with Go prior to this so please smite me down with the
wisdom of a million Golang gods if I'm doing something terribly wrong.

I also added a test to gist/create for the added web arg.

Pretty much referenced the implementation from pr/create.

* Fix for Tests / build (windows-latest)

I believe this fixes it as it stopped failing on a local vm. Otherwise I
will try and tackle it tomorrow.

* minor cleanup

Co-authored-by: vilmibm <vilmibm@github.com>
2020-11-16 16:01:30 -06:00
Cristian Dominguez
b71e6494ab Update gist create tests 2020-09-28 02:37:41 -03:00
vilmibm
b6502deb24 allow naming stdin gist files 2020-09-14 10:33:29 -05:00
Brandon Wilson
0d60798ca4
Gist Create - Output Filename (#1498) 2020-08-13 13:38:49 +02:00
vilmibm
05419e46f0 put gist fixture file into gist package 2020-07-22 10:36:12 -05:00
Mislav Marohnić
16739c3044 Whoops, gist create stderr is not empty 2020-07-22 14:59:35 +02:00
Mislav Marohnić
b195075644 Tweak approach to iostreams in tests
- avoid typecast to `*bytes.Buffer`
- assert that stderr is empty
2020-07-22 14:50:23 +02:00
vilmibm
496ed477c5 linter appeasement 2020-07-21 17:47:44 -05:00
vilmibm
d12ff4b9e5 oauth scope check test 2020-07-21 17:39:49 -05:00
vilmibm
ba46362a7f add createRun tests 2020-07-21 17:19:59 -05:00
vilmibm
5085a5eda2 WIP test works with mock 2020-07-21 15:17:30 -05:00
Mislav Marohnić
e373195817 WIP migrate gist create to separate package 2020-07-21 18:13:16 +02:00