Kynan Ware
7094a55eec
Remove unused ghIds function and githubv4 import
...
Deleted the unused ghIds helper function and the associated githubv4 import from edit.go to clean up the codebase.
2025-10-01 15:47:39 -06:00
Kynan Ware
87468f40db
Refactor PR reviewer editing to use REST API and optimize team fetch
...
Switches pull request reviewer add/remove operations from GraphQL to the REST API, enabling separate add and remove calls for reviewers and teams. Refactors reviewer editing logic to avoid fetching organization teams unless required for interactive editing, improving performance for non-interactive flows. Updates tests and supporting code to reflect the new reviewer management and metadata fetching behavior.
2025-09-30 10:45:44 -06:00
Babak K. Shandiz
78b09e55e5
fix(pr/shared): add rest return value to ParseURL
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-09-10 18:57:57 +01:00
Babak K. Shandiz
b7fa5ea7a9
docs: explain PR URL parsing reason
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-07-01 11:41:07 +01:00
Babak K. Shandiz
58ed691a6c
test: remove references to AssignedActorsUsed field
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-07-01 11:19:13 +01:00
Babak K. Shandiz
2c86246a1a
test: verify providing a URL arg affects the base repo
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-07-01 11:18:38 +01:00
Babak K. Shandiz
b85dc94f84
refactor: select PR fields based on detected features
...
This change is almost a revert to what had already done in #10984 .
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-07-01 11:14:50 +01:00
Kynan Ware
ed4b90104f
test(pr): Add tests for actor assignees
2025-06-03 14:30:19 +01:00
Andy Feller
a24d39ac87
Fix test, remove partial standalone test
2025-06-03 13:48:01 +01:00
Andy Feller
cde860be88
Iterate on pr edit problems with existing assignees
...
This commit is a handful of changes around `gh pr edit --add-assignee` behavior. Most notably, fixing a bug where the assigned actors weren't being dropped.
In addition to this, I was refactoring the testing setup to allow for individual test table scenarios could be contained.
2025-06-03 13:33:52 +01:00
William Martin
c13f2f1232
Merge pull request #11057 from cli/wm/fix-pr-edit
...
Fix pr edit when URL is provided
2025-06-02 17:44:30 +02:00
Tim Rogers
9a8031151c
Document support for @copilot in gh [pr|issue] edit --add-assignee and --remove-assignee ( #11056 )
...
* Document support for `@copilot` in `gh [pr|issue] edit --add-assignee` and `--remove-assignee`
Following up on #10991 , this updates the help text for
`issue edit` and `pr edit`'s `--add-assignee` and
`--remove-assignee` options to mention that you can use
`@copilot`.
This is already mentioned in the command-level help text, but
not at the argument level, whereas the `@me` macro is.
* Apply suggestion from @babakks
Co-authored-by: Babak K. Shandiz <babakks@github.com>
* Apply suggestion from @babakks
Co-authored-by: Babak K. Shandiz <babakks@github.com>
---------
Co-authored-by: Babak K. Shandiz <babakks@github.com>
2025-06-02 16:29:35 +01:00
William Martin
793a7ff459
Fix pr edit when URL is provided
2025-06-02 15:07:55 +02:00
Kynan Ware
d932934119
Merge branch 'trunk' into kw/gh-cli-epic-900-actors-are-assignable
2025-05-16 12:49:52 -06:00
Kynan Ware
3a8cdda148
Merge pull request #10991 from cli/kw/gh-cli-917-special-actor-assignee-names-noninteractive
...
`issue edit`, `pr edit`: Support special non-interactive (flags) assignee name `@copilot`
2025-05-16 12:19:43 -06:00
Kynan Ware
748afb6e85
doc(issue/pr edit): clarify @copilot usage
2025-05-16 12:18:23 -06:00
Kynan Ware
475163a126
Merge pull request #10990 from cli/kw/gh-cli-916-special-actor-assignee-names
...
`issue edit`, `pr edit`: handle display names in interactive assignee editing
2025-05-16 10:16:08 -06:00
Kynan Ware
532aa1c32a
doc(issue/pr edit): doc @copilot assignee
2025-05-16 09:55:17 -06:00
Kynan Ware
ec7c8ed844
test(pr edit): fix typo in test name
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-05-15 13:41:38 -06:00
Kynan Ware
f6bb1ca756
refactor(pr edit): move httpclient initialization
2025-05-15 13:40:23 -06:00
Kynan Ware
51b1e6cd6f
Merge branch 'kw/gh-cli-909-911-assign-actors-to-prs' into kw/gh-cli-916-special-actor-assignee-names
2025-05-15 11:27:14 -06:00
Kynan Ware
54f48cfe46
fix(pr edit): remove merge conflict artifact, extra detector
2025-05-15 09:48:44 -06:00
Kynan Ware
a03c9cec7b
Merge branch 'kw/gh-cli-epic-900-actors-are-assignable' into kw/gh-cli-909-911-assign-actors-to-prs
2025-05-15 09:42:39 -06:00
Kynan Ware
d72018d312
feat(pr edit): fetch assignable actors
2025-05-15 09:33:36 -06:00
Kynan Ware
f559068106
feat(pr edit): fetch assigned actors
2025-05-15 09:33:36 -06:00
Kynan Ware
999ffbdfe7
Merge pull request #10960 from cli/kw/gh-cli-901-910-assign-actors-to-issues
...
`gh issue edit`: actors are assignable to issues
2025-05-15 09:24:32 -06:00
Kynan Ware
eace1e889a
feat(editable): update assigned actors to use display names
...
- Refactored AssignedActors to return display names instead of logins.
- Updated related functions to ensure consistency in display names.
- Enhanced comments for clarity on display name logic and actor types.
2025-05-14 20:26:53 -06:00
Kynan Ware
d4832ba015
feat(pr edit): fetch assignable actors
2025-05-14 11:52:02 -06:00
Kynan Ware
71f22d8843
feat(pr edit): fetch assigned actors
2025-05-14 11:52:02 -06:00
Babak K. Shandiz
5dca16fd41
Update test case for removing all reviewers
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-05-13 10:13:45 +01:00
Babak K. Shandiz
ce710aa249
Add test to verify removing all reviewers
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-05-12 15:15:43 +01:00
Babak K. Shandiz
4985d0ff44
fix bug when removing all PR reviwers
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-05-12 15:06:11 +01:00
Kynan Ware
ee9d169204
feat(issue edit): fetch assignable actors
2025-05-09 15:13:11 -06:00
William Martin
55cd3c34cd
Feature detect v1 projects on pr edit
2025-05-07 16:17:15 +02:00
Tyler McGoffin
18d58b8d84
Replace --project.* flags' name with title in docs ( #9443 )
...
With the upcoming migration from v1 project to v2 projects, we'd like the
language in our documentation to align with v2 project language. In v2,
projects are referred to by `title` and not `name`, though they are
functionally equivalent under the hood for the CLI
2024-08-09 13:55:14 -07:00
Babak K. Shandiz
58e6196777
Fix missing variable
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-29 21:41:43 +01:00
Babak K. Shandiz
842562d3db
Use closure-scoped variable to catch --remove-milestone option
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-29 21:40:23 +01:00
Babak K. Shandiz
c9fb4ed099
Verify --milestone and --remove-milestone are not assignable at the same time
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-28 15:44:05 +01:00
Babak K. Shandiz
605b4b19e1
Assert correct parsing of --remove-milestone option
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-28 15:43:38 +01:00
Babak K. Shandiz
6dc8cc41d0
Verify --body and --body-file are not assignable at the same time
2024-07-28 15:41:54 +01:00
Babak K. Shandiz
1520292726
Add --remove-milestone option
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-07-28 15:40:38 +01:00
William Martin
1d38230675
Move config interfaces into gh package ( #9060 )
2024-05-10 10:39:36 +02:00
William Martin
5007c18f5f
Fix unused params across project
2024-05-07 17:50:43 +02:00
Yukai Chou
b14da6c63f
Wrap scopes
2023-11-23 07:22:57 +08:00
Yukai Chou
896101678f
Wrap cli commands in backticks uniformly
2023-11-17 01:32:00 +08:00
Nate Smith
f04e3398ed
use prompter in shared editable code
2023-08-17 11:28:01 -05:00
Sam Coe
f5d581d363
Do not make reviewer update request if there are no reviewer changes ( #7730 )
2023-07-24 10:16:45 -07:00
Benjamin Chadwick
82662685e3
Autocomplete branch flags ( #6031 )
...
Co-authored-by: Mislav Marohnić <mislav@github.com>
2023-03-29 16:09:44 +00:00
Sam Coe
08a1231178
Allow retrieving projectItems in JSON and allow adding/removing user owned projects ( #7007 )
2023-02-15 22:14:59 +00:00
Sam Coe
138da0f969
Fix adding/removing projects using flags for edit commands ( #6955 )
2023-02-06 08:28:38 +11:00