Commit graph

196 commits

Author SHA1 Message Date
Mislav Marohnić
47baf8fb10 pr create: explain how to link an issue 2021-02-03 22:17:31 +01:00
Mislav Marohnić
051fbbc1e1 Merge remote-tracking branch 'origin' into dpromanko/remove-set-cmd-prepare 2021-01-28 22:00:08 +01:00
Mislav Marohnić
88c27934a1 Update some stubs to be closer to how git behaves 2021-01-28 21:58:45 +01:00
Devon Romanko
2964895a77 fix test behavior changes from migration to run.Stub 2021-01-27 18:46:29 -05:00
Sam Coe
52bdcad8ea
Do not display minimized comments 2021-01-27 08:14:46 -08:00
Devon Romanko
cb897fd7e2 remove unused errorStub from 'pr checkout' test 2021-01-27 08:04:57 -05:00
Devon Romanko
a04e0ece71 use Stub instead of SetPrepareCmd in 'pr checkout' tests 2021-01-27 07:53:21 -05:00
Devon Romanko
45bc1d787c use Stub instead of SetPrepareCmd in 'pr view' tests 2021-01-27 07:23:49 -05:00
Devon Romanko
2eed1593ce use Stub instead of SetPrepareCmd in 'pr list' tests 2021-01-26 08:15:13 -05:00
Sam Coe
3f172ad991
Add contional and tests 2021-01-25 13:27:32 -08:00
zamasu
e4b9f7cb8c
Alert unpushed commits when merging a pull request 2021-01-25 12:04:32 -08:00
Sam
8125cd5911
Merge pull request #2117 from fsmiamoto/checkout-detached-head
Add flag for using detached HEAD to `pr checkout`
2021-01-25 11:29:36 -08:00
Sam Coe
cec3aa294e
Support detach head for pr checkout 2021-01-25 11:22:33 -08:00
Mislav Marohnić
70c4cbf240 Merge remote-tracking branch 'origin' into success-icon-consistency 2021-01-25 14:57:04 +01:00
Mislav Marohnić
f46bab256c Rename to SuccessIconWithColor 2021-01-25 14:56:39 +01:00
Mislav Marohnić
8cba14b564 💅 cleanup command stub assertions 2021-01-25 13:13:36 +01:00
Devon Romanko
e39c9d8f9f remove new uses of InitCmdStubber after rebase 2021-01-23 08:31:49 -05:00
Devon Romanko
ac5bfc09b8 remove use of deprecated InitCmdStubber 2021-01-23 08:22:11 -05:00
Mislav Marohnić
96fa6e7830 Merge remote-tracking branch 'origin' into success-icon-consistency 2021-01-22 23:56:54 +01:00
Mislav Marohnić
23d68705bc Match color of the success icon with the end state of the record 2021-01-22 23:55:33 +01:00
Nate Smith
6e2c1b33b0
Merge pull request #2224 from divbhasin/1190-limit-merge-methods
#1190 - limit merge methods
2021-01-22 14:23:23 -08:00
AliabbasMerchant
1c54db4919 fix: Project Argument working along with --web flag 2021-01-22 23:07:00 +01:00
Mislav Marohnić
874375f01e 💅 pr checkout --force 2021-01-22 22:37:20 +01:00
Neel Redkar
a89fa1ebed add ability to force checkout 2021-01-22 22:29:01 +01:00
Mislav Marohnić
e334a1f10c Add docs for using @me to reference self 2021-01-22 22:14:47 +01:00
Mislav Marohnić
73da25a96d Use concrete type instead of an interface to avoid forced casting 2021-01-22 22:05:33 +01:00
Mislav Marohnić
28c2d042e7 Extend @me replacing behavior to issue list 2021-01-22 22:05:33 +01:00
Marc Lopez
6ad0c57a31 issue/pr create: add "@me" syntax to self-assign
Signed-off-by: Marc Lopez <marc5.12@outlook.com>
2021-01-22 20:41:17 +01:00
Mislav Marohnić
06cf2c9f81 Merge remote-tracking branch 'origin' into cmd-stub-new 2021-01-22 16:31:29 +01:00
Nate Smith
4d28c79192
Merge pull request #2810 from ptxmac/ptx/pr-merge-body
Add body argument to `pr merge` command.
2021-01-21 15:25:42 -08:00
vilmibm
6decf4384f simplify slightly, add tests 2021-01-21 15:18:08 -08:00
Sam Coe
f09b8a8e78
Add mergeMethodSurvey test 2021-01-21 14:58:10 -08:00
Nate Smith
d25938e223
Merge pull request #2808 from KarelCoudijzer/fork-hang
Show progress while creating a new pull request
2021-01-21 14:54:15 -08:00
vilmibm
05d39ebd0d remove garbling spinner
one of the three new spinners produced less than ideal output when a
push happened; the other two do enhance the create experience and i
think we can get away without one for push.
2021-01-21 14:53:19 -08:00
Sam Coe
11e873c669
Cleanup impossible code path 2021-01-21 14:45:06 -08:00
Sam Coe
7cc2975a98
Fix tests 2021-01-21 14:42:42 -08:00
Sam Coe
a305ff1488
Split apart interactive merge survey function 2021-01-21 14:00:33 -08:00
Sam Coe
2d782fcb46
Retrieve repo outside of survey function 2021-01-21 13:13:58 -08:00
Sam Coe
71a66cc8d6
Fix merge 2021-01-21 12:53:04 -08:00
Sam Coe
a9123966e3
Merge branch 'trunk' into 1190-limit-merge-methods 2021-01-21 12:45:10 -08:00
Mislav Marohnić
a70b69e359
Bring the "Press Enter" UI closer to the authentication experience
- "Press Enter" is both bold
- "Enter" is capitalized
- The prompt ends with "..."
2021-01-21 09:47:38 -08:00
Sam Coe
a26fba7800
Comment on pull requests 2021-01-21 09:47:38 -08:00
Mislav Marohnić
ad62d6a471
Merge pull request #2798 from cli/pr-merge-crossrepo
Handle case when a cross-repo PR was already merged
2021-01-21 17:36:00 +01:00
Mislav Marohnić
4158209d50
Merge pull request #2811 from cli/utils-spinner-buh-bye
Retire utils.Spinner in favor of IOStreams.StartProgressIndicator
2021-01-21 17:34:39 +01:00
Björn Heinrichs
c9f79271b1
Add --maintainer-edit flag (#2250)
* Add --maintainer-edit flag

Closes #2213 while retaining backwards compatibility.

* Fix linting

* Adjust documentation and validation

* Negate logic and fix build errors

* rename to no-maintainer-edit

* test

* use a positive option instead of negative

Co-authored-by: vilmibm <vilmibm@github.com>
2021-01-20 14:51:27 -08:00
Sam Coe
b9b1079493
Display reviews when viewing pull requests 2021-01-20 12:15:25 -08:00
Mislav Marohnić
a2bee1fad3 🔥 utils.Spinner 2021-01-20 14:48:14 +01:00
Peter Kristensen
bc7f733267 Add body argument to pr merge command. 2021-01-20 13:24:27 +01:00
Karel Coudijzer
a7b9e3916c Show progress while creating pr 2021-01-19 22:19:10 +01:00
Mislav Marohnić
b5366c6ebf
Merge pull request #2794 from cristiand391/use-testify-assertion
Use Testify assertions in tests
2021-01-19 14:08:25 +01:00