STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
9395 commits 87 branches 0 tags 160 MiB
Commit graph

9395 commits

This branch
This branch
All branches
Author SHA1 Message Date
Meredith Lancaster
728aa3d83f set new options in enforcement criteria 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-24 13:20:01 -07:00
Meredith Lancaster
11dc8d48f5 reorder fields 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-24 13:19:47 -07:00
Tyler McGoffin
d684834ad9 Refactor pr status to use the ParsePRRefs helper on the Finder 
There was a lot of copy-pasta code between the finder and pr status. After
some investigation it was clear that the prSelectorForCurrentBranch code
was really just a duplicate of the finder's code without actually making
the API call for the PR. Since the ParsePRRefs helper had already
extracted much of the logic for determining a PR's head ref branch, I was
able to reuse it in gh pr status with a small refactor.
 2025-01-24 11:51:49 -08:00
Tyler McGoffin
cdead50d57 Moved remote.pushDefault out of ReadBranchConfig and into finder 2025-01-24 11:05:15 -08:00
Tyler McGoffin
e4d8ed0e60 Remove @{push} from branch config 2025-01-24 10:20:04 -08:00
Tyler McGoffin
5a8dd35ba7 Add PushDefault method to git client 2025-01-24 09:40:02 -08:00
William Martin
07ab59d2b5
Merge pull request #10306 from cli/dependabot/go_modules/google.golang.org/protobuf-1.36.4 
Bump google.golang.org/protobuf from 1.36.3 to 1.36.4
 2025-01-24 17:50:09 +01:00
Meredith Lancaster
6c0cdca554 Merge remote-tracking branch 'upstream/trunk' into attestation-verify-ref-commit-policy-opts 2025-01-24 09:32:18 -07:00
Meredith Lancaster
5df2b47d1f update tests 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-24 09:30:46 -07:00
Meredith Lancaster
2f81a33e95 add new signing options 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-24 09:28:55 -07:00
Meredith Lancaster
9e573d1e10
Merge branch 'trunk' into attestation-bundle-fetch-improvements 2025-01-24 09:26:59 -07:00
William Martin
6355ed7c08 WIP: push default defaults to simple 2025-01-24 17:25:38 +01:00
Meredith Lancaster
77cc1b17bd
Merge pull request #10102 from malancas/more-attestation-cmd-integration-tests 
Add more `gh attestation verify` integration tests
 2025-01-24 09:14:32 -07:00
William Martin
a72bef9b42 Error if push revision doesn't match a remote 2025-01-24 17:07:24 +01:00
dependabot[bot]
9f801771a8
Bump google.golang.org/protobuf from 1.36.3 to 1.36.4 
Bumps google.golang.org/protobuf from 1.36.3 to 1.36.4.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-01-24 14:49:07 +00:00
Andy Feller
c23a2834c7
Merge pull request #10297 from dennisameling/windows-arm64-msi 
Enable MSI building for Windows arm64
 2025-01-24 08:04:35 -05:00
William Martin
c33275a4dc
Merge pull request #10300 from cli/dependabot/github_actions/actions/attest-build-provenance-2.2.0 
Bump actions/attest-build-provenance from 2.1.0 to 2.2.0
 2025-01-24 11:59:00 +01:00
Tyler McGoffin
41729b004d Refactor finder.Find and replace parseCurrentBranch with parsePRRefs 
I've been struggling horribly to reason through all of this code, and
after much mental gymnastics I identified the culprit as the overloaded
"branch" string returned by parseCurrentBranch.

This value was either the name of the branch that the PR we're looking for
is associated with, or that name prepended with the owner's name and a :
if we're on a branch, so:

PR branch: featureBranch
branch == "featureBranch"

If on Fork belonging to "ForkOwner"
branch == "ForkOwner:featureBranch"

Since this extra information was bundled up into this single string, it
complicated the responsibilities of parseCurrentBranch's "branch" return
value. Thus, I've teased out "branch" into the new PRRefs struct:

type PRRefs struct{
	BranchName string
	HeadRepo ghrepo.Interface
	BaseRepo ghrepo.Interface
}

This allows the new parsePRRefs function to move all the previous
"branch" string's information into structured data, and allows for a new
method on PRRefs, GetPRLabel(), to create the string that "branch"
previously held to pass into its downstream consumer, namely
findForBranch.

This also allowed for better test coverage, directly connecting the PRRefs
fields to the values contained in the git config. Overall, I am now
confident that this is doing what its supposed to do with respect to my
understanding of the various central and triangular git workflows we are
addressing.
 2025-01-23 15:25:28 -08:00
Meredith Lancaster
840fe2198c
Merge branch 'trunk' into attestation-bundle-fetch-improvements 2025-01-23 12:46:22 -07:00
Meredith Lancaster
c0c1618e50
Merge pull request #10104 from malancas/update-attestation-verify-table-output 
Update `gh attestation verify` table output
 2025-01-23 12:38:55 -07:00
Michael Hoffman
363bfd9520
Merge branch 'trunk' into create-autolinks 2025-01-23 12:55:30 -05:00
dependabot[bot]
fe3d18c96a
Bump actions/attest-build-provenance from 2.1.0 to 2.2.0 
Bumps [actions/attest-build-provenance](https://github.com/actions/attest-build-provenance) from 2.1.0 to 2.2.0.
- [Release notes](https://github.com/actions/attest-build-provenance/releases)
- [Changelog](https://github.com/actions/attest-build-provenance/blob/main/RELEASE.md)
- [Commits](7668571508...520d128f16)

---
updated-dependencies:
- dependency-name: actions/attest-build-provenance
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-01-23 14:53:49 +00:00
Meredith Lancaster
5624ed8ebc Merge branch 'update-attestation-verify-table-output' of github.com:malancas/cli into update-attestation-verify-table-output 2025-01-23 07:47:50 -07:00
Meredith Lancaster
4134f9606e remove bolding from bullet point output 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-23 07:47:38 -07:00
William Martin
8c64de75c9
Merge pull request #10151 from ottok/fix-glamour-v0.8.0-compat 
Update test to be compatible with latest Glamour v0.8.0
 2025-01-23 10:12:00 +01:00
Otto Kekäläinen
b19e682455
Update test to be compatible with latest Glamour v0.8.0 
Latest Glamour has slightly changed logic in line length / wrapping,
resulting test failures due to string mismatch. Update tests and bump
dependency to v0.8.0, and others to the bare minimal level as generated
by `go mod tidy`.

This was detected then building the GitHub cli package `gh` in Debian
started to fail with src:golang-github-charmbracelet-glamour 0.8.0-1.

Closes: #10179
 2025-01-22 20:13:40 -08:00
William Martin
8dc1a969bb
Merge pull request #10296 from petercover/trunk 
chore: fix some comments
 2025-01-22 23:34:24 +01:00
Meredith Lancaster
6d48557f7d
Merge branch 'trunk' into update-attestation-verify-table-output 2025-01-22 13:28:45 -07:00
Meredith Lancaster
5f6e720a50 reorder policy enforcement criteria print out 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-22 13:27:56 -07:00
Meredith Lancaster
2ec70a5dc3 bold bullet point list header text 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-22 13:22:45 -07:00
Dennis Ameling
d4aebb1cbb Enable MSI building for Windows arm64 2025-01-22 18:06:40 +01:00
petercover
bad7098cfe chore: fix some comments 
Signed-off-by: petercover <raowanxiang@outlook.com>
 2025-01-23 00:47:27 +08:00
William Martin
c3342cc173
Merge pull request #10236 from AMS21/patch-1 
add install instructions for Manjaro Linux
 2025-01-22 12:59:17 +01:00
William Martin
b2e0c6a68a
Merge pull request #10257 from cli/dependabot/go_modules/github.com/google/go-containerregistry-0.20.3 
Bump github.com/google/go-containerregistry from 0.20.2 to 0.20.3
 2025-01-22 12:29:15 +01:00
William Martin
113fe646f3 Bump go module version to 1.23 2025-01-22 12:10:03 +01:00
dependabot[bot]
9eb8002764 Bump github.com/google/go-containerregistry from 0.20.2 to 0.20.3 
Bumps [github.com/google/go-containerregistry](https://github.com/google/go-containerregistry) from 0.20.2 to 0.20.3.
- [Release notes](https://github.com/google/go-containerregistry/releases)
- [Changelog](https://github.com/google/go-containerregistry/blob/main/.goreleaser.yml)
- [Commits](https://github.com/google/go-containerregistry/compare/v0.20.2...v0.20.3)

---
updated-dependencies:
- dependency-name: github.com/google/go-containerregistry
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-01-22 12:10:03 +01:00
William Martin
1bd07b9477
Merge pull request #10279 from mikelolasagasti/go-1.24-printf 
Bump golangci-linter and address failures to prepare for Go 1.24 strictness
 2025-01-22 12:08:39 +01:00
Tyler McGoffin
e0d3b9181a
Merge pull request #10227 from iamrajhans/rerun-err-msg 
show error message for rerun workflow older than a month ago
 2025-01-21 13:14:24 -08:00
William Martin
0a3706a404 Remove unncessary printf usage 2025-01-21 18:04:47 +01:00
William Martin
0ead3398a7 Bump golang ci lint to work with go 1.24 2025-01-21 17:55:39 +01:00
William Martin
ff922353bb
Merge pull request #10209 from cli/wm/add-remote-check-to-secret 
Require repo disambiguation for secret commands
 2025-01-21 15:24:49 +01:00
William Martin
53f80b2ebf
Merge pull request #10265 from robmorgan/patch-1 
Tiny typo fix
 2025-01-21 13:48:50 +01:00
Rajhans Jadhao
211aaefc39
Merge branch 'trunk' into rerun-err-msg 2025-01-21 10:38:23 +05:30
Kynan Ware
722fc67342
Merge pull request #10048 from mateusmarquezini/fix/issue_10042 
Fix: `gh gist view` and `gh gist edit` prompts with no TTY
 2025-01-20 12:12:53 -07:00
Michael Hoffman
87f414174b
Merge branch 'trunk' into create-autolinks 2025-01-20 13:56:07 -05:00
Mikel Olasagasti Uranga
4396e40a31 Fix: Ensure constant format strings in fmt and printf calls 
Go 1.24 introduces stricter checks for format string validation.
This commit fixes instances where non-constant format strings were
used in calls to functions like `fmt.Errorf`, `fmt.Printf`, and similar.

Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>
 2025-01-20 16:27:27 +01:00
Andy Feller
fe74349fe4
Merge pull request #10269 from cli/BagToad-add-affected-version-to-bug-report-form 2025-01-17 22:55:03 -05:00
Caleb Brose
0c8591064d Change back to exponential backoff 2025-01-17 14:09:33 -06:00
Caleb Brose
9b8cd7babd Linter 2025-01-17 14:09:33 -06:00
Caleb Brose
31bff5b5a8 Better handling for codespace state polling 2025-01-17 14:09:33 -06:00