bagtoad
83c5bf3589
Update error message wording
2024-11-19 16:42:15 -07:00
bagtoad
4b73e55fd2
Change: exit zero, still print warning to stderr
...
Instead of returning `ErrExtensionExecutableNotFound` error which causes `gh` to have a non-zero exit code, catch it and print the message to stderr, returning nil. Only print the warning to stderr when there is a TTY.
2024-11-19 16:42:15 -07:00
Meredith Lancaster
3e6861e7e1
clean up
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-19 16:28:36 -07:00
Meredith Lancaster
b5788f2523
wrap sigstore and cert ext verification into a single function
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-19 16:24:17 -07:00
Andy Feller
8da27d2c8a
Second attempt to address exploit
...
This builds off suggestion to reuse logic used already within `gh run download` for detecting path traversals.
This largely works but runs into an issue where detection logic doesn't handle non-separated traversal.
2024-11-19 17:55:18 -05:00
Dalius Dobravolskas
9414930b5d
Adding option to return baseRefOid in pr view
...
You need to know exact `baseRefOid` so you could show correct diff.
`baseRefName` is not enough sometimes because branch from which PR was
forked might have changes already.
Example usage:
```
gh pr view --json headRefName,headRefOid,number,baseRefName,baseRefOid,reviewDecision
```
2024-11-19 23:50:45 +02:00
Meredith Lancaster
f48e6b56e3
verify cert extensions function should return filtered result list
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-19 14:38:28 -07:00
Meredith Lancaster
08a66f5383
wording
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-19 14:26:15 -07:00
Fredrik Skogman
0cc4846239
Merge branch 'trunk' into manual-verification
2024-11-19 13:25:11 +01:00
Kynan Ware
1bc2bb8059
Improve docs on installing extensions
...
Better clarify the two extension types in the `extension install` docs.
Co-authored-by: Tyler McGoffin <jtmcg@github.com>
2024-11-18 16:45:57 -07:00
Kynan Ware
bb3b64ad06
Update language for missing extension executable
...
Co-authored-by: Tyler McGoffin <jtmcg@github.com>
2024-11-18 16:25:07 -07:00
Kynan Ware
2ec27ff9fe
Update test comments about Windows behavior
...
Co-authored-by: Tyler McGoffin <jtmcg@github.com>
2024-11-18 16:21:14 -07:00
Meredith Lancaster
a55f9a6301
Merge branch 'trunk' into print-policy-info
2024-11-18 13:57:34 -07:00
Meredith Lancaster
9177b22a21
Merge pull request #9892 from malancas/refactor-fetch-attestations
...
Refactor the `getAttestations` functions
2024-11-18 13:56:46 -07:00
Meredith Lancaster
b787a8b785
wording
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-18 13:39:06 -07:00
Meredith Lancaster
a89071c30d
wording
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-18 12:25:57 -07:00
Meredith Lancaster
cfbc1c7e10
wording
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-18 12:16:12 -07:00
Meredith Lancaster
6ca5e6f18c
add newlines for additional policy info
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-18 11:42:39 -07:00
Meredith Lancaster
63f37eb369
pr feedback
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-18 08:24:25 -07:00
Meredith Lancaster
30ae1388e4
Update pkg/cmd/attestation/download/download.go
...
Co-authored-by: Phill MV <phillmv@github.com>
2024-11-18 08:19:41 -07:00
Meredith Lancaster
762e99d151
fix function param calls
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-18 08:19:07 -07:00
Meredith Lancaster
c518a3b1f5
Update pkg/cmd/attestation/verification/extensions.go
...
Co-authored-by: Phill MV <phillmv@github.com>
2024-11-18 08:18:04 -07:00
Fredrik Skogman
075691b03e
Formatting fix
...
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
2024-11-18 15:17:34 +01:00
Fredrik Skogman
601982faf1
Updated formatting to be more clear
...
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
2024-11-18 15:16:47 +01:00
Fredrik Skogman
5098ea407a
Updated markdown syntax for a note.
...
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
2024-11-18 14:48:34 +01:00
Fredrik Skogman
9168a5d7d8
Added a section on manual verification of the relases.
...
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
2024-11-18 14:12:44 +01:00
bagtoad
c5497b4d28
Document requirements for local extensions
2024-11-17 21:01:49 -07:00
bagtoad
b575fe8ebc
Warn when installing local ext with no executable
2024-11-17 21:01:49 -07:00
Andy Feller
7b91b17395
Refactor extension command testing
...
This commit allows for stubbing/mocking the function used for checking update release info. Additionally, this does a minor refactor moving from non-blocking to blocking channel.
2024-11-17 21:59:06 -05:00
Andy Feller
0d3f7cae4e
Bring extension update check in line with gh check
...
This commit is a bit of refactoring to bring the extension update checking logic up to par with what is done with `gh` including creation of state file per extension and listening to env vars for disabling version checking.
This work is not complete as it does not address necessary test changes.
2024-11-17 16:10:58 -05:00
nilvng
36eaf14857
issue #2329 : improve UI/UX
...
Improve the interactive PR selection UI by
- prefix the PR number with hashcode #
- perserve the text formatting (bold) upon an option is hovered
- add the PR head label
Technical changes:
- Replace \033[0m with \033[39m for maintaining text formatting
2024-11-17 23:47:36 +11:00
nilvng
c6c27113fe
issue #2329 : add happy path unit test
2024-11-17 16:36:10 +11:00
nilvng
1832c1a767
issue #2329 : fix the linting issue
2024-11-17 14:58:38 +11:00
nilvng
4386fcb4e5
issue #2329 : fix the unit tests issue - ensure its backward compatible
2024-11-17 14:57:48 +11:00
Nillin
49b10b745d
Merge branch 'trunk' into nil/fix-2329
2024-11-17 13:47:29 +11:00
bagtoad
68f3ef79ca
Handle missing "workflow" scope in createRelease
2024-11-16 19:32:37 -07:00
Kynan Ware
9decf1b526
Merge pull request #9905 from cli/9904-gh-repo-create-to-work-on-bare-repos
...
Support bare repo creation
2024-11-15 12:08:26 -07:00
Kynan Ware
04e2a5dd63
Merge branch 'trunk' into 9904-gh-repo-create-to-work-on-bare-repos
2024-11-15 11:56:31 -07:00
Meredith Lancaster
a56ff4a0eb
wording
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-14 10:29:24 -07:00
Meredith Lancaster
91577594de
formatting
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-14 10:20:48 -07:00
Andy Feller
cd3f2ad064
Merge pull request #9920 from cli/andyfeller/github-cli-676-improved-visibility
...
Mention GitHub CLI team on discussion issues
2024-11-14 10:44:45 -05:00
Andy Feller
e64742cc84
Merge commit from fork
...
adding username validation to the invoker ssh server
2024-11-14 10:44:15 -05:00
Andy Feller
d4262f8183
Mention GitHub CLI team on discussion issues
2024-11-14 10:31:36 -05:00
Kynan Ware
8990b1c7df
Merge pull request #9914 from cli/andyfeller/cli-cli-8183-timeout
...
Shorten extension release checking from 3s to 1s
2024-11-13 11:33:48 -07:00
Andy Feller
b8ef951de1
Shorten extension release checking from 3s to 1s
...
Addressing feedback from extension author demonstration about a noticable pause waiting for extension execution to complete due to amount of time waiting on channel.
2024-11-13 13:04:01 -05:00
William Martin
7bcb063391
Modify push prompt on repo create when bare
2024-11-11 16:17:06 +01:00
William Martin
8e63268aba
Doc push behaviour for bare repo create
2024-11-11 16:10:32 +01:00
William Martin
e3665955a5
Push --mirror on bare repo create
2024-11-11 16:09:03 +01:00
William Martin
6a97dbfadf
Add acceptance test for bare repo create
2024-11-11 15:51:52 +01:00
William Martin
2efb9935db
Doc isLocalRepo and git.Client IsLocalRepo differences
2024-11-11 14:18:26 +01:00
