Commit graph

330 commits

Author SHA1 Message Date
Tyler McGoffin
7fcb4453ed
Merge pull request #10121 from cli/jtmcg/add-tagname-enforcement-to-deployment-workflow
Add job to deployment workflow to validate the tag name for a given release
2025-01-24 14:31:59 -08:00
Andy Feller
c23a2834c7
Merge pull request #10297 from dennisameling/windows-arm64-msi
Enable MSI building for Windows arm64
2025-01-24 08:04:35 -05:00
dependabot[bot]
fe3d18c96a
Bump actions/attest-build-provenance from 2.1.0 to 2.2.0
Bumps [actions/attest-build-provenance](https://github.com/actions/attest-build-provenance) from 2.1.0 to 2.2.0.
- [Release notes](https://github.com/actions/attest-build-provenance/releases)
- [Changelog](https://github.com/actions/attest-build-provenance/blob/main/RELEASE.md)
- [Commits](7668571508...520d128f16)

---
updated-dependencies:
- dependency-name: actions/attest-build-provenance
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-23 14:53:49 +00:00
Dennis Ameling
d4aebb1cbb Enable MSI building for Windows arm64 2025-01-22 18:06:40 +01:00
William Martin
0ead3398a7 Bump golang ci lint to work with go 1.24 2025-01-21 17:55:39 +01:00
Kynan Ware
7942be56aa
Add affected version to bug report form 2025-01-17 12:07:32 -07:00
shauryatiwari1
eed3626521 Remove release discussion posts and clean up related block in deployment yml 2024-12-27 15:15:21 +05:30
Tyler McGoffin
5fc56ded50 Escape '.' in version validation regex in deployment workflow 2024-12-26 10:50:09 -08:00
Tyler McGoffin
1386e3671f Add job to deployment workflow to validate the tag name for a given release 2024-12-20 14:55:29 -08:00
Meredith Lancaster
64bf37e31c
Merge pull request #10051 from malancas/gh-attestation-download-windows-bug
Use Windows compatible file name for downloaded attestations when running `gh attestation download`
2024-12-16 08:01:36 -07:00
Meredith Lancaster
5ebfa26487 use bash shell with integration tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-11 08:03:42 -07:00
Meredith Lancaster
2ced59fba3 update integration test scripts
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-11 07:42:05 -07:00
Meredith Lancaster
050f295b37 run all tests in a single script
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-10 11:41:15 -07:00
Meredith Lancaster
0e15557000 windows for loop syntax
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-10 10:18:15 -07:00
Meredith Lancaster
9f6d18c70e run integration tests with windows specific syntax
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-10 08:37:32 -07:00
Meredith Lancaster
351592d90f run all attestation cmd integration tests automatically
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-10 08:24:01 -07:00
dependabot[bot]
4c5a92aa11
Bump actions/attest-build-provenance from 1.4.4 to 2.1.0
Bumps [actions/attest-build-provenance](https://github.com/actions/attest-build-provenance) from 1.4.4 to 2.1.0.
- [Release notes](https://github.com/actions/attest-build-provenance/releases)
- [Changelog](https://github.com/actions/attest-build-provenance/blob/main/RELEASE.md)
- [Commits](ef244123eb...7668571508)

---
updated-dependencies:
- dependency-name: actions/attest-build-provenance
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-12-10 14:57:58 +00:00
Andy Feller
d4262f8183 Mention GitHub CLI team on discussion issues 2024-11-14 10:31:36 -05:00
dependabot[bot]
2318fde15f
Bump actions/attest-build-provenance from 1.4.3 to 1.4.4
Bumps [actions/attest-build-provenance](https://github.com/actions/attest-build-provenance) from 1.4.3 to 1.4.4.
- [Release notes](https://github.com/actions/attest-build-provenance/releases)
- [Changelog](https://github.com/actions/attest-build-provenance/blob/main/RELEASE.md)
- [Commits](1c608d11d6...ef244123eb)

---
updated-dependencies:
- dependency-name: actions/attest-build-provenance
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-11-06 14:14:48 +00:00
Yukai Chou
fdfd4b30bb Rewrite a sentence in CONTRIBUTING.md 2024-10-17 01:13:47 +08:00
Kynan Ware
dae074049a
Merge pull request #9687 from cli/kw/improve-security.md-encourage-pocs-and-investigation
Improve `SECURITY.md` with expectations for privately reported vulnerabilities
2024-10-02 12:33:43 -06:00
Kynan Ware
289b9bc712
Apply suggestions from code review
Co-authored-by: Tyler McGoffin <jtmcg@github.com>
2024-10-01 17:24:23 -06:00
Kynan Ware
023a44904a
Update SECURITY.md 2024-10-01 12:02:54 -06:00
bagtoad
efe9841caf Fix typo and wordsmithing 2024-09-30 15:14:59 -06:00
bagtoad
7b8e8be7d4 Remove trailing space from heading 2024-09-30 15:13:19 -06:00
bagtoad
aef01e22d7 Revise wording 2024-09-30 15:03:50 -06:00
bagtoad
0b29beacf4 Update docs to allow community submitted designs 2024-09-30 14:47:24 -06:00
dependabot[bot]
a21e78bf0d
build(deps): bump actions/attest-build-provenance from 1.4.2 to 1.4.3
Bumps [actions/attest-build-provenance](https://github.com/actions/attest-build-provenance) from 1.4.2 to 1.4.3.
- [Release notes](https://github.com/actions/attest-build-provenance/releases)
- [Changelog](https://github.com/actions/attest-build-provenance/blob/main/RELEASE.md)
- [Commits](6149ea5740...1c608d11d6)

---
updated-dependencies:
- dependency-name: actions/attest-build-provenance
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-09-06 14:31:25 +00:00
dependabot[bot]
b8db372d71
build(deps): bump actions/attest-build-provenance from 1.4.1 to 1.4.2 (#9518)
Bumps [actions/attest-build-provenance](https://github.com/actions/attest-build-provenance) from 1.4.1 to 1.4.2.
- [Release notes](https://github.com/actions/attest-build-provenance/releases)
- [Changelog](https://github.com/actions/attest-build-provenance/blob/main/RELEASE.md)
- [Commits](310b0a4a3b...6149ea5740)

---
updated-dependencies:
- dependency-name: actions/attest-build-provenance
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tyler McGoffin <jtmcg@github.com>
2024-08-26 10:26:42 -07:00
dependabot[bot]
da43f6e476
build(deps): bump actions/attest-build-provenance from 1.4.0 to 1.4.1
Bumps [actions/attest-build-provenance](https://github.com/actions/attest-build-provenance) from 1.4.0 to 1.4.1.
- [Release notes](https://github.com/actions/attest-build-provenance/releases)
- [Changelog](https://github.com/actions/attest-build-provenance/blob/main/RELEASE.md)
- [Commits](210c191353...310b0a4a3b)

---
updated-dependencies:
- dependency-name: actions/attest-build-provenance
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-08-12 15:00:14 +00:00
dependabot[bot]
ad96ad3580
build(deps): bump actions/attest-build-provenance from 1.3.3 to 1.4.0
Bumps [actions/attest-build-provenance](https://github.com/actions/attest-build-provenance) from 1.3.3 to 1.4.0.
- [Release notes](https://github.com/actions/attest-build-provenance/releases)
- [Changelog](https://github.com/actions/attest-build-provenance/blob/main/RELEASE.md)
- [Commits](5e9cb68e95...210c191353)

---
updated-dependencies:
- dependency-name: actions/attest-build-provenance
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-07-31 14:55:39 +00:00
Zach Steindler
658f125ab3
Update sigstore-go in gh CLI to v0.5.1 (#9366)
Signed-off-by: Zach Steindler <steiza@github.com>
2024-07-25 20:59:39 +02:00
dependabot[bot]
4511a8b4c4
build(deps): bump actions/attest-build-provenance from 1.3.2 to 1.3.3
Bumps [actions/attest-build-provenance](https://github.com/actions/attest-build-provenance) from 1.3.2 to 1.3.3.
- [Release notes](https://github.com/actions/attest-build-provenance/releases)
- [Changelog](https://github.com/actions/attest-build-provenance/blob/main/RELEASE.md)
- [Commits](bdd51370e0...5e9cb68e95)

---
updated-dependencies:
- dependency-name: actions/attest-build-provenance
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-07-10 14:21:15 +00:00
Andy Feller
70c3ca3236
Merge pull request #9167 from TWiStErRob/patch-1
Add GH_DEBUG to issue template
2024-06-25 10:46:14 -04:00
Andy Feller
85387fdc67
Update .github/ISSUE_TEMPLATE/bug_report.md
Co-authored-by: Róbert Papp <papp.robert.s@gmail.com>
2024-06-25 10:35:31 -04:00
dependabot[bot]
651d7135dc
build(deps): bump actions/attest-build-provenance from 1.2.0 to 1.3.2
Bumps [actions/attest-build-provenance](https://github.com/actions/attest-build-provenance) from 1.2.0 to 1.3.2.
- [Release notes](https://github.com/actions/attest-build-provenance/releases)
- [Changelog](https://github.com/actions/attest-build-provenance/blob/main/RELEASE.md)
- [Commits](49df96e17e...bdd51370e0)

---
updated-dependencies:
- dependency-name: actions/attest-build-provenance
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-06-18 14:40:06 +00:00
Róbert Papp
307d07ebfd
Update .github/ISSUE_TEMPLATE/bug_report.md
Co-authored-by: Andy Feller <andyfeller@github.com>
2024-06-13 19:47:30 +01:00
Andy Feller
7cd4a15e7c
Merge pull request #9175 from cli/dependabot/github_actions/goreleaser/goreleaser-action-6
build(deps): bump goreleaser/goreleaser-action from 5 to 6
2024-06-12 10:55:12 -04:00
dependabot[bot]
d666248104
build(deps): bump goreleaser/goreleaser-action from 5 to 6
Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 5 to 6.
- [Release notes](https://github.com/goreleaser/goreleaser-action/releases)
- [Commits](https://github.com/goreleaser/goreleaser-action/compare/v5...v6)

---
updated-dependencies:
- dependency-name: goreleaser/goreleaser-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-06-05 14:34:35 +00:00
dependabot[bot]
215456e8ae
build(deps): bump actions/attest-build-provenance from 1.1.2 to 1.2.0
Bumps [actions/attest-build-provenance](https://github.com/actions/attest-build-provenance) from 1.1.2 to 1.2.0.
- [Release notes](https://github.com/actions/attest-build-provenance/releases)
- [Changelog](https://github.com/actions/attest-build-provenance/blob/main/RELEASE.md)
- [Commits](173725a120...49df96e17e)

---
updated-dependencies:
- dependency-name: actions/attest-build-provenance
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-06-04 14:47:16 +00:00
Róbert Papp
3a1f3854a4
Add GH_DEBUG to issue template 2024-06-04 10:51:38 +01:00
Andy Feller
fe880a3015
Ensure signed RPMs have attestations
Thanks to @malancas for highlighting issue ordering of RPM signing and attestations!  Now, all artifacts should have attestations appropriately generated
2024-05-29 16:18:18 -04:00
Meredith Lancaster
e55093347c
Add build provenance for gh CLI releases (#9087)
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-05-28 18:10:50 +02:00
Paul
630ab13461
Merge branch 'trunk' into feature-macos-pkg-installer 2024-05-20 17:05:23 +02:00
Meredith Lancaster
6f350827d2
Run attestation command set integration tests separately (#9035)
* rename and add integration build tag

Signed-off-by: Meredith Lancaster <malancas@github.com>

* run tests that include integration build tag in workflow

Signed-off-by: Meredith Lancaster <malancas@github.com>

---------

Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-05-02 08:07:44 -06:00
Meredith Lancaster
c465d465a5
Update sigstore-go dependency to v0.3.0 (#8977)
* update sigstore-go dep to v0.3.0

Signed-off-by: Meredith Lancaster <malancas@github.com>

* add integration test to verify newer sigstore bundle versions

Signed-off-by: Meredith Lancaster <malancas@github.com>

* Fix shellcheck issues

Signed-off-by: Meredith Lancaster <malancas@github.com>

* Give the cli/package-security team ownership over gh attestation cmd integration tests

Signed-off-by: Meredith Lancaster <malancas@github.com>

* fetch attestation file

Signed-off-by: Meredith Lancaster <malancas@github.com>

* clean up new integration test

Signed-off-by: Meredith Lancaster <malancas@github.com>

* try pulling other attestation file

Signed-off-by: Meredith Lancaster <malancas@github.com>

* cleanup new attestation verify integration test

Signed-off-by: Meredith Lancaster <malancas@github.com>

* add new gh atestation integration test to workflow

Signed-off-by: Meredith Lancaster <malancas@github.com>

* mark script as executable

Signed-off-by: Meredith Lancaster <malancas@github.com>

* rename the integration test file

Signed-off-by: Meredith Lancaster <malancas@github.com>

---------

Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-04-23 07:07:23 -06:00
Matthew Hughes
0d6bd6d53c Fix cache contention in Go CI jobs
Fix the `Set up go` and `Restore Go modules cache` steps both trying to
read/write the same contents. Since the `setup-go` step runs first this
results in the "restore cache" step trying to write the same contents
under `~/go/pkg/mod` which results in errors like (e.g. random
example[1]):

    /usr/bin/tar -xf /home/runner/work/_temp/6d12957f-f226-455e-b99c-fa7ee8c962cb/cache.tzst -P -C /home/runner/work/cli/cli --use-compress-program unzstd
    /usr/bin/tar: ../../../go/pkg/mod/golang.org/x/net@v0.21.0/go.sum: Cannot open: File exists
    Error: /usr/bin/tar: ../../../go/pkg/mod/golang.org/x/net@v0.21.0/proxy/proxy.go: Cannot open: File exists
    Error: /usr/bin/tar: ../../../go/pkg/mod/golang.org/x/net@v0.21.0/proxy/socks5.go: Cannot open: File exists
    Error: /usr/bin/tar: ../../../go/pkg/mod/golang.org/x/net@v0.21.0/proxy/dial_test.go: Cannot open: File exists

Since restoring fails, the cache job thinks no cache hit was made and
proceeds to try and save, but since it may well have fetched a valid
cache this can also error (again, see[1]):

    Post job cleanup.
    /usr/bin/tar --posix -cf cache.tzst --exclude cache.tzst -P -C /home/runner/work/cli/cli --files-from manifest.txt --use-compress-program zstdmt
    Failed to save: Unable to reserve cache with key go-Linux-1b4ae53bfd76c3b70f62d419e17f36544d0a1331f04b13d2a942e7752e3789c3, another job may be creating this cache. More details: Cache already exists. Scope: refs/heads/trunk, Key: go-Linux-1b4ae53bfd76c3b70f62d419e17f36544d0a1331f04b13d2a942e7752e3789c3, Version: 2a8d0f2be1a88abb057cd9fcea9832bd16e7ab71798dbf93cd890eb9add83cf6

To avoid this, just rely on the caching functionality of the `seutp-go`
action.

For some context, It appears this cache behaviour was added with
cb7315c85d when these workflows were still
run with `setup-go@v2`:

    $ git show cb7315c85d3c0e010ba117ca7e692ed6f18f16c5:{.github/workflows/go.yml,.github/workflows/lint.yml} | grep 'actions/setup-go'
            uses: actions/setup-go@v2
            uses: actions/setup-go@v2

which is before caching behaviour was added (with `v3.2.0`[2]).

[1] https://github.com/cli/cli/actions/runs/8654869114/job/23732868571
[2] https://github.com/actions/setup-go/releases/tag/v3.2.0
2024-04-12 17:36:45 +01:00
Meredith Lancaster
2c53d7c9a8
Add codeowners entry for the GitHub TUF root included in the attestation command set (#8919)
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-04-05 09:41:34 +02:00
William Martin
200c95e5b2
Rely on go.mod go version in all workflows (#8911) 2024-04-02 13:22:31 +00:00
Naoya Yasuda
5d79a95a32
Upgrade to Go 1.22 (#8836) 2024-04-02 14:34:59 +02:00