Mislav Marohnić
70c4cbf240
Merge remote-tracking branch 'origin' into success-icon-consistency
2021-01-25 14:57:04 +01:00
Mislav Marohnić
f46bab256c
Rename to SuccessIconWithColor
2021-01-25 14:56:39 +01:00
Mislav Marohnić
d465b7f5d5
Freeze time in issue view test
2021-01-25 13:46:30 +01:00
Mislav Marohnić
96fa6e7830
Merge remote-tracking branch 'origin' into success-icon-consistency
2021-01-22 23:56:54 +01:00
Mislav Marohnić
23d68705bc
Match color of the success icon with the end state of the record
2021-01-22 23:55:33 +01:00
AliabbasMerchant
1c54db4919
fix: Project Argument working along with --web flag
2021-01-22 23:07:00 +01:00
Mislav Marohnić
e334a1f10c
Add docs for using @me to reference self
2021-01-22 22:14:47 +01:00
Mislav Marohnić
28c2d042e7
Extend @me replacing behavior to issue list
2021-01-22 22:05:33 +01:00
Marc Lopez
6ad0c57a31
issue/pr create: add "@me" syntax to self-assign
...
Signed-off-by: Marc Lopez <marc5.12@outlook.com>
2021-01-22 20:41:17 +01:00
Mislav Marohnić
06cf2c9f81
Merge remote-tracking branch 'origin' into cmd-stub-new
2021-01-22 16:31:29 +01:00
Sam Coe
a26fba7800
Comment on pull requests
2021-01-21 09:47:38 -08:00
Mislav Marohnić
4158209d50
Merge pull request #2811 from cli/utils-spinner-buh-bye
...
Retire utils.Spinner in favor of IOStreams.StartProgressIndicator
2021-01-21 17:34:39 +01:00
Sam Coe
b9b1079493
Display reviews when viewing pull requests
2021-01-20 12:15:25 -08:00
Mislav Marohnić
a2bee1fad3
🔥 utils.Spinner
2021-01-20 14:48:14 +01:00
Mislav Marohnić
75ebb863e3
Use testify assertions for error matching
2021-01-19 13:59:37 +01:00
Cristian Dominguez
45f4a1f087
Equal: flip arguments position
2021-01-18 21:00:59 -03:00
Mislav Marohnić
fc77cbc964
Deprecate test.ExpectLines
...
For asserting command output, exact string matches are preferred in most cases. In cases when a pattern match is needed, the test can use regexp ad hoc.
2021-01-18 23:25:45 +01:00
Mislav Marohnić
c308f1cd91
Prevent further use of SetPrepareCmd and InitCmdStubber
2021-01-18 22:44:53 +01:00
Mislav Marohnić
683ebee6ef
Consistently use green success icon
...
For operations such as closing an issue or merging a PR, we would
display the success icon (a checkmark) in red and magenta colors,
respectively, to reflect the latest state of the record operated on
(red: closed; magenta: merged).
This was always confusing to me, seeing it both in code and in the UI,
because I'm instinctively thinking that it's a bug and have to remind
myself that it's by design.
2021-01-18 19:57:38 +01:00
Cristian Dominguez
3afb1d0b1a
Use Testify assertions in test
2021-01-16 19:19:30 -03:00
Sam
b0ae09e627
Merge pull request #2535 from cli/create-comments
...
Create issue comments
2021-01-12 11:24:09 -08:00
Cristian Dominguez
ce151420f3
Migrate legacy tests
2021-01-11 21:07:19 -03:00
Sam Coe
723e9e31ba
Address PR comments
2021-01-11 13:56:17 -08:00
Sam Coe
155507d31d
Make comment command easier to test
2021-01-05 15:14:25 -08:00
Sam Coe
1fc8b66b26
Address PR comments
2021-01-05 10:36:03 -08:00
Sam Coe
f862123071
Modify issue commenting to adhere to designs and add tests
2021-01-05 10:35:09 -08:00
Yuki Osaki
338bf1d112
fix linter issue
2021-01-05 10:35:09 -08:00
Yuki Osaki
8ef2bb4d14
Comment on issues from editor
2021-01-05 10:35:09 -08:00
Camelid
8ff4cc40e6
view: Add missing newline
...
Add a newline at the end of the 'View this {issue, pull request} on
GitHub' message. `gh repo view` already had a newline at the end, so
this only changes `issue view` and `pr view`.
2020-12-27 11:37:59 -08:00
Mislav Marohnić
a77f3ddb49
Merge pull request #2575 from cli/pr-view-comments
...
Add ability to view comments with `pr view`
2020-12-15 16:31:03 +01:00
Sam Coe
dee7077fcf
Extract shared comment and reaction group code
2020-12-09 14:35:29 -05:00
Sam Coe
efc05dee90
Use spinner helper
2020-12-09 13:50:08 -05:00
Sam Coe
9f101ff0a2
Add comments to pr view
2020-12-08 14:18:05 -05:00
Sam Coe
b2edf782cf
Reverse order of issue lookup checks
2020-12-08 14:16:40 -05:00
Sam Coe
bec5e0cd77
Address PR comments
2020-12-08 10:24:02 -05:00
Sam Coe
bad5a59427
Update non-tty comment output
2020-12-07 14:25:05 -05:00
Sam Coe
8c5e5a3820
Appease the linter
2020-12-07 14:25:05 -05:00
Sam Coe
c843a4fa13
Add issue comment viewing
2020-12-07 14:25:04 -05:00
Mislav Marohnić
f4152454f2
Merge pull request #2472 from cristiand391/preserve-metadata-state
...
Prompt: avoid resetting PR/issue metadata
2020-12-03 18:51:29 +01:00
Mislav Marohnić
be39f4363b
Make MetadataSurvey testable by accepting an interface
2020-12-03 17:47:40 +01:00
Mislav Marohnić
df2ca9c9f9
Fix browser URL test on Windows
2020-12-01 15:55:40 +01:00
Mislav Marohnić
dc1fad9cb0
Fix respecting chosen action in interactive issue create
...
The `action` variable started being shadowed in the `if` block in
6671106448
2020-12-01 15:28:39 +01:00
vilmibm
cf37ce7463
no shorthand for --recover
2020-11-23 11:24:28 -08:00
vilmibm
d6e84a75fb
switch to recover instead of resubmit
2020-11-23 11:21:34 -08:00
vilmibm
d300526318
preserve and restore issue/pr input on failure
2020-11-23 11:21:28 -08:00
Josh Soref
ded92972cd
spelling: template
2020-11-21 21:43:51 -05:00
vilmibm
ef52376fe0
fix survey invocation
2020-11-13 10:35:32 -08:00
vilmibm
f5277e452e
get everything working
2020-11-12 12:03:32 -08:00
vilmibm
6671106448
WIP works, probably some title/body input edge cases
2020-11-12 12:03:20 -08:00
Mislav Marohnić
feec114bb6
Fix truncateLabels for empty values
2020-11-11 15:29:40 +01:00