Jose Garcia
b44474c32b
Revert rename for ports cmd
2021-10-06 13:47:20 -04:00
Jose Garcia
bdc9ad30e7
Revert other rename changes
2021-10-06 13:46:04 -04:00
Jose Garcia
771ac714ac
Update docs
2021-10-06 11:47:18 -04:00
Jose Garcia
3a28643630
Keep codespace struct in API for now
...
- Use a private codespace structure in the cmd pkg to encapsulate common
behavior
2021-10-06 11:44:26 -04:00
Jose Garcia
017632d63d
Merge branch 'trunk' of github.com:cli/cli into jg/choose-codespace-prompt
2021-10-06 09:57:39 -04:00
Jose Garcia
7c497f283b
Update test signature
2021-10-06 09:15:07 -04:00
Jose Garcia
8bb55359b1
Update mock API
2021-10-06 09:10:00 -04:00
Jose Garcia
8135fdbd99
Switch GetCodespace to new API endpoint
...
- Drop GetCodespaceToken as it is no longer necessary
- Introduces new behavior with the API to optionally include connection
details in the GET request. Ommitting to do so results in a faster
response
2021-10-06 08:50:42 -04:00
Jose Garcia
7fe8357d40
Better short name
2021-10-05 13:30:17 -04:00
Jose Garcia
1971292175
Fixes bug there are +2 codespaces with a conflict
...
- Tracks conflicting name going forward for other records
- Moves the git status dirty star into a constant so we can reference it
2021-10-05 13:24:47 -04:00
Jose Garcia
a8d1718f21
Merge branch 'trunk' of github.com:cli/cli into jg/choose-codespace-prompt
2021-10-05 12:57:11 -04:00
Jose Garcia
616d6c2db1
Merge pull request #4431 from cli/jg/get-skus-public
...
codespace machine: switch `API.GetCodespacesMachines` to use new API
2021-10-05 12:44:38 -04:00
Jose Garcia
975bd7c08a
Change choose codespace prompt
...
- Repo + branch is favored
- Codespace name is included to disambiguate between two codespaces
- Move Codespace model out of out API into its own package
- Update call sites and group behavior under codespace.Codespace
2021-10-05 11:23:12 -04:00
Jose Garcia
3652307cf3
Merge pull request #4429 from cli/jg/start-codespace-public
...
codespace create: update `API.StartCodespace` to use new API endpoint
2021-10-05 09:20:33 -04:00
Jose Garcia
a2e6df18e7
Merge pull request #4432 from cli/jg/rename-pkg
...
codespace: rename the cmd pkg to codespace
2021-10-05 08:23:36 -04:00
Jose Garcia
d02876e6ea
Rename the cmd pkg to codespace
2021-10-04 14:16:04 -04:00
Jose Garcia
e0db10e4dd
Switch API.GetCodespacesMachines to use new API
...
- The SKU terminology is also dropped in favor of "machine" which
matches the nomenclature of the rest of the product.
2021-10-04 13:40:18 -04:00
Jose Garcia
a3efb53c44
Update API.StartCodespace to use new API endpoint
...
- Switch to using name instead of GUID
- Remove GUID from the code since it is not used anywhere else
- Add docs to the api client methods
- Re-gen mocked client
2021-10-04 08:32:02 -04:00
Jose Garcia
6b1876161d
Update DeleteCodespaces to new API endpoint
...
- Drop the need for the user argument
- Update mocks
- Remove no longer applicable TODO comment
- Show message for successful deletion (this regressed)
2021-10-01 12:53:35 -04:00
Jose Garcia
05297b8c8d
Update ListCodespaces to use new API endpoint
...
- Removes the need for a User to list codespaces which should result in
a slight speed improvement.
2021-10-01 10:37:15 -04:00
Jose Garcia
0859de0124
Merge branch 'trunk' of github.com:cli/cli into jg/move-ghcs-cmd
2021-09-30 12:38:41 -04:00
Jose Garcia
9e6c11e767
Move cmd/ghcs to pkg/cmd/codespace
...
- Delete pkg/cmd/codespace/main as it is no longer needed in this
codebase
2021-09-30 11:20:13 -04:00
