Mislav Marohnić
8cba14b564
💅 cleanup command stub assertions
2021-01-25 13:13:36 +01:00
Devon Romanko
e39c9d8f9f
remove new uses of InitCmdStubber after rebase
2021-01-23 08:31:49 -05:00
Devon Romanko
ac5bfc09b8
remove use of deprecated InitCmdStubber
2021-01-23 08:22:11 -05:00
AliabbasMerchant
1c54db4919
fix: Project Argument working along with --web flag
2021-01-22 23:07:00 +01:00
Mislav Marohnić
73da25a96d
Use concrete type instead of an interface to avoid forced casting
2021-01-22 22:05:33 +01:00
Mislav Marohnić
06cf2c9f81
Merge remote-tracking branch 'origin' into cmd-stub-new
2021-01-22 16:31:29 +01:00
Björn Heinrichs
c9f79271b1
Add --maintainer-edit flag ( #2250 )
...
* Add --maintainer-edit flag
Closes #2213 while retaining backwards compatibility.
* Fix linting
* Adjust documentation and validation
* Negate logic and fix build errors
* rename to no-maintainer-edit
* test
* use a positive option instead of negative
Co-authored-by: vilmibm <vilmibm@github.com>
2021-01-20 14:51:27 -08:00
Mislav Marohnić
75ebb863e3
Use testify assertions for error matching
2021-01-19 13:59:37 +01:00
Cristian Dominguez
45f4a1f087
Equal: flip arguments position
2021-01-18 21:00:59 -03:00
Mislav Marohnić
c308f1cd91
Prevent further use of SetPrepareCmd and InitCmdStubber
2021-01-18 22:44:53 +01:00
Cristian Dominguez
3afb1d0b1a
Use Testify assertions in test
2021-01-16 19:19:30 -03:00
Cristian Dominguez
ce151420f3
Migrate legacy tests
2021-01-11 21:07:19 -03:00
Mislav Marohnić
be759785f0
Fix "Continue in browser" for pr create coming from forks
...
Ensures that the `owner:` prefix is present when referencing the head branch
2020-12-01 21:23:39 +01:00
vilmibm
cf37ce7463
no shorthand for --recover
2020-11-23 11:24:28 -08:00
vilmibm
d6e84a75fb
switch to recover instead of resubmit
2020-11-23 11:21:34 -08:00
vilmibm
d300526318
preserve and restore issue/pr input on failure
2020-11-23 11:21:28 -08:00
vilmibm
ef52376fe0
fix survey invocation
2020-11-13 10:35:32 -08:00
vilmibm
f5277e452e
get everything working
2020-11-12 12:03:32 -08:00
Mislav Marohnić
d5cb5574d0
💅 simplify generateCompareURL and test
2020-10-21 12:09:46 +00:00
Leonardo
d0bee19eaf
Query escape branch names to allow branch/#123 names
2020-10-21 12:09:46 +00:00
Mislav Marohnić
80b60fc6a9
Fix pr create for branches published under a different name
2020-09-24 11:35:02 +02:00
Mislav Marohnić
e2efc0b8a3
Fix pr create when branch was already pushed to a non-base remote
2020-09-23 19:53:27 +02:00
Mislav Marohnić
7a8db80420
Prompt for push target during pr create
...
We no longer guess the head repository using heuristics; instead, we
present the user with the choice of pushable repositories and an
additional option to create a new fork.
The new `pr create --head` flag is available for the user to specify the
head branch in `branch` or `owner:branch` format and completely skip any
forking or auto-pushing checks.
2020-09-16 14:49:36 +02:00
vilmibm
1073c97409
review feedback
2020-09-11 11:36:24 -05:00
vilmibm
c0fc31f7d5
use CanPrompt in commands
2020-09-10 12:13:48 -05:00
Daniel Leong
c7e702203b
Update template test to reflect inclusion of "default" text
...
Also, avoid excessive amounts of newlines separating the two
2020-09-08 20:25:52 -04:00
Daniel Leong
41543b564d
"Check" the error value of ioutil.WriteFile
...
We could, alternatively, use t.Fatal... this matches the MkdirAll
invocation from github_template_test, however...
2020-09-08 20:12:28 -04:00
Daniel Leong
a33124414c
Add a test to verify the behavior of prepending commit body to message
2020-09-08 20:12:28 -04:00
AliabbasMerchant
9e7279604d
Fix failing tests for Windows (due to line-ending issues)
2020-09-02 10:03:56 +05:30
AliabbasMerchant
51c5595cad
Interactive template selection test for PR create
2020-09-02 09:56:28 +05:30
Mislav Marohnić
558e3f3dea
Isolate pr create command
2020-08-04 18:29:42 +02:00
