JP Ungaretti
6a150d57e0
Adopt in delete.go
2023-02-09 23:21:41 +00:00
JP Ungaretti
a388358348
Merge branch 'trunk' into jungaretti/fix-jupyter-spinner
2023-02-09 23:18:22 +00:00
JP Ungaretti
1b88915a4d
Rename f to run
2023-02-09 23:16:12 +00:00
JP Ungaretti
a848cd1bd0
Adopt in stop.go
2023-02-09 23:13:44 +00:00
JP Ungaretti
bc789b2787
Adopt in ssh.go
2023-02-09 22:53:48 +00:00
JP Ungaretti
970088a7af
Adopt in ports.go
2023-02-09 22:52:04 +00:00
JP Ungaretti
f77eb5f932
Adopt in list.go
2023-02-09 22:48:29 +00:00
JP Ungaretti
123380ac83
Adopt in edit.go
2023-02-09 22:36:38 +00:00
JP Ungaretti
38397f11be
Adopt in delete.go
2023-02-09 22:30:57 +00:00
JP Ungaretti
d815d54bd2
Adopt in create.go
2023-02-09 22:24:09 +00:00
JP Ungaretti
43783a33a2
Move helper to iostreams
2023-02-09 22:23:58 +00:00
Robin Neatherway
78fb90956c
Teach gh cs create to use current repo as default ( #6596 )
...
Co-authored-by: Mislav Marohnić <mislav@github.com>
2023-02-07 20:05:38 +00:00
Luan Vieira
d4c9890c5a
Default to authenticated user on codespace delete ( #6944 )
...
When a username option is not provided for the `gh codespace delete`
command, we will use the authenticated user's login as the default to
avoid deleting anyone else's codespace by mistake.
Prior to this change, running `gh codespace delete --org MYORG --all`
would fetch all of the codespacese associated with the org regardless of
user and then only delete the ones associated with the authenticated
user, which would lead to 404 errors when MYORG had codespaces owned by
members other than the authenticated member.
Co-authored-by: Victoria Dye <vdye@github.com>
Co-authored-by: Lessley Dennington <ldennington@github.com>
2023-02-07 20:46:08 +01:00
Caleb Brose
90ae71b2ba
Merge pull request #6888 from cli/cmbrose/pf-half-close
...
Half close port forwarding connections to fix hangs
2023-01-23 14:26:19 -06:00
Ryan Caldwell
71ec2c4e23
Codespaces create: Fix missing billable owner notice for individuals ( #6891 )
2023-01-23 13:15:44 +01:00
Caleb Brose
2b95cbc5a6
Close port forward writer on reader
2023-01-19 20:22:24 -06:00
JP Ungaretti
5879923b4f
Use progress runner a few times
2023-01-12 22:56:33 +00:00
JP Ungaretti
216d3bf912
Add generic progress runner
2023-01-12 22:56:19 +00:00
JP Ungaretti
efe57991b0
Fix spinner on error
2023-01-12 22:36:27 +00:00
David Gardiner
ce6b7d8762
Start SSH server with gRPC
2023-01-10 11:59:56 -08:00
David Gardiner
839378d5cb
Merge pull request #6657 from dmgardiner25/codespaces-rpc-invoker
...
Create centralized Codespaces RPC invoker
2023-01-06 12:58:44 -08:00
David Gardiner
814fcf8c74
Remove unused token field
2023-01-06 09:56:16 -08:00
John Keech
791c7db632
Fix typo in has_uncommitted_changes for codespaces ( #6812 )
...
The REST API for codespaces returns the following schema:
```
"git_status": {
"ahead": 0,
"behind": 0,
"has_unpushed_changes": false,
"has_uncommitted_changes": false,
"ref": "main"
},
```
The CLI was looking for `has_uncommited_changes` in the response instead of `has_uncommitted_changes`, leading to it always reporting a `false` value which could be different than the API response.
2023-01-05 22:02:32 +00:00
David Gardiner
000a84d49b
Address comments
2023-01-04 15:33:33 -08:00
David Gardiner
731ba682f2
Create Invoker object
2023-01-04 14:41:25 -08:00
David Gardiner
1e75a74d18
Create centralized Codespaces RPC invoker
2023-01-04 14:41:25 -08:00
Des Preston
4ade907ae8
Allow setting codespace display name during create ( #6739 )
...
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-12-19 17:10:34 +01:00
Caleb Brose
56006eefa6
Flags instead of PersistentFlag
2022-12-13 01:20:49 +00:00
Caleb Brose
57c53e6268
linter
2022-12-12 21:21:23 +00:00
Caleb Brose
8e0b4ef21b
Use -R for --repo shorthand and deprecate -r
2022-12-12 19:44:59 +00:00
Mislav Marohnić
e4f5545e86
Go 1.19: fix comment formatting for moq-generated mocks
2022-12-12 16:58:25 +01:00
Sam Coe
6dbe7e6342
Linter fixes ( #6722 )
...
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-12-12 15:27:32 +00:00
Jake Shorty
1cb62b182c
Use new domain for forwarded ports
2022-12-08 18:36:26 +00:00
JP Ungaretti
925edf3892
Add long description
2022-11-01 22:35:39 +00:00
JP Ungaretti
a29820ebe3
Use incremental rebuild by default
2022-11-01 21:00:14 +00:00
Ashwin Jeyaseelan
a756ffb1e8
Fix Codespace Creation Devcontainer bug ( #6389 )
2022-10-18 11:11:28 +03:00
Mislav Marohnić
3fe5026d39
Migrate to tableprinter from go-gh ( #6346 )
2022-10-17 15:15:39 +02:00
David Gardiner
f80f566ab2
Merge pull request #6358 from dmgardiner25/dmgardiner25/grpc-client
...
Implement gRPC client and `GetRunningServer` method
2022-10-11 10:45:50 -07:00
Jose Garcia
a356a1bef0
no need to ignore cancel
2022-10-11 13:15:34 -04:00
Jose Garcia
e11b43f8f6
Fixes for handling the grpc client lifecyle
2022-10-11 08:55:14 -04:00
David Gardiner
f89b1b6a45
Create timeout context in caller
2022-10-10 14:39:12 -07:00
JP Ungaretti
982aa5ba82
Rename RPC command to RebuildContainer
2022-10-10 21:01:29 +00:00
JP Ungaretti
0e963ebd4f
Move codespace construction to its test
2022-10-09 01:11:04 +00:00
JP Ungaretti
d05cdf5ff3
Tidy up comments and errors
2022-10-08 06:30:42 +00:00
JP Ungaretti
4c49fd3e64
Add rebuild command
2022-10-08 06:12:36 +00:00
JP Ungaretti
da91216c31
Add new Rebuild function
2022-10-08 00:04:45 +00:00
David Gardiner
766e6a2314
Use existing context
2022-09-29 09:58:44 -07:00
Anthony Fok
f6d0f82701
Fix missing text in gh-codespace-ssh.1 man page
...
Rearrange the long help text so that '--config' does not appear at the
start of a line which groff interprets as an undefined macro and skips
the content of that whole line.
To reproduce:
$ go run cmd/gen-docs/main.go --man-page --doc-path /tmp/gh-manpages
$ man --warnings -E UTF-8 -l -Tutf8 -Z /tmp/gh-manpages/gh-codespace-ssh.1 >/dev/null
troff: <standard input>:26: warning: macro '--config'' not defined
Discovered by the Debian Lintian tool.
2022-09-28 14:00:37 -06:00
David Gardiner
35d2cf30d0
Send session token
2022-09-28 11:28:35 -07:00
David Gardiner
3f34d6d95e
Make suggested gRPC client changes
2022-09-28 10:39:26 -07:00