Commit graph

89 commits

Author SHA1 Message Date
Meredith Lancaster
f376ac1a2c Merge branch 'trunk' into simplify-sigstore-verify-result-handling 2024-11-06 07:59:23 -07:00
Meredith Lancaster
b9c9f0acc2 move comment
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-04 07:35:42 -07:00
Meredith Lancaster
3281bd457c simplify logic, add comments
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-04 07:32:10 -07:00
Meredith Lancaster
91967cced8
Update pkg/cmd/attestation/verify/verify.go
Co-authored-by: Phill MV <phillmv@github.com>
2024-11-01 09:51:05 -06:00
Meredith Lancaster
43810a5fc3 use predicate type stored in enforcementCriteria
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-01 09:17:47 -06:00
Meredith Lancaster
bb1584b52a comment
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-01 09:02:56 -06:00
Meredith Lancaster
a6d15b4f60 update OIDC issuer logic
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-01 09:02:23 -06:00
Meredith Lancaster
0fb82a6e7c comments
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-31 17:11:02 -06:00
Meredith Lancaster
50cda0df44 add Valid method for EnforcementCriteria
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-31 16:56:49 -06:00
Meredith Lancaster
8336f797ad use sigstore-go certificate.Summary type for criteria
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-31 16:27:21 -06:00
Meredith Lancaster
9f3d00960c keep comment
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-31 16:16:09 -06:00
Meredith Lancaster
7948ce4dc9 rename function
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-31 16:09:08 -06:00
Meredith Lancaster
6f4b5ddc40 remove artifact from EnforcementCriteria
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-31 16:07:25 -06:00
Meredith Lancaster
56731c9b70 remove unneeded result handling struct
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-31 12:26:06 -06:00
Meredith Lancaster
9cdeb31fc6 reorganize funcs
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-31 08:32:35 -06:00
Meredith Lancaster
61b60e9430 fix runner setting
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-31 08:19:33 -06:00
Meredith Lancaster
bb0dcd9db4 fix wrong field settings
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-30 17:19:15 -06:00
Meredith Lancaster
bf4f04f797 Merge branch 'trunk' into attestation-refactor-policy 2024-10-30 16:14:30 -06:00
Meredith Lancaster
8b02c43085 add tests for newEnforcementCriteria
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-30 16:05:39 -06:00
Meredith Lancaster
1652051fc2
Merge pull request #9825 from malancas/verify-provenance-predicate-by-default
`gh attestation verify` should only verify provenance attestations by default
2024-10-30 15:45:18 -06:00
Meredith Lancaster
fa2574c1a8 Merge remote-tracking branch 'upstream/trunk' into attestation-refactor-policy 2024-10-30 15:29:27 -06:00
Meredith Lancaster
93c78a2134 use sigstore specific err
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-30 15:28:34 -06:00
Meredith Lancaster
b44c9d3003 undo policy method changes
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-30 15:23:50 -06:00
Meredith Lancaster
3378b546da simplify if else logic
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-30 12:58:40 -06:00
Meredith Lancaster
41c3ba5fa7 drop sigstore instance for now
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-29 18:19:19 -06:00
Meredith Lancaster
e16b69bd08 cert extension funcs are now policy methods
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-29 17:27:47 -06:00
Meredith Lancaster
e5b2b09a6e move policy functions into methods
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-29 16:41:17 -06:00
Meredith Lancaster
704de0cf37 start building a separate policy struct
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-29 15:33:24 -06:00
Meredith Lancaster
384057c2e2 bold all flags in docs
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-29 11:54:42 -06:00
Meredith Lancaster
271450883e
Update pkg/cmd/attestation/verify/verify.go
Co-authored-by: Phill MV <phillmv@github.com>
2024-10-29 11:53:28 -06:00
Meredith Lancaster
15d7e33ddb update references
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-29 07:11:51 -06:00
Meredith Lancaster
7bfddec046 fix references
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-29 07:09:45 -06:00
Meredith Lancaster
7598c4a58f organize
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-28 15:38:06 -06:00
Meredith Lancaster
f8f3502cac doc updates
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-28 15:37:58 -06:00
Meredith Lancaster
4ec696dacd create common test fixture, organize tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-28 13:40:48 -06:00
Meredith Lancaster
f8b0f5e687 clean up test
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-28 13:02:12 -06:00
Meredith Lancaster
ce5bde4379 simplify signer workflow validation tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-28 12:59:04 -06:00
Meredith Lancaster
a820457b09 clean up skipped online tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-28 11:47:31 -06:00
Meredith Lancaster
9ddaf13ef5 add predicate type to integration tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-25 15:32:16 -06:00
Meredith Lancaster
cef335c698 update tests to include predicate type
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-25 15:26:32 -06:00
Meredith Lancaster
28fa42a324 message formatting
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-25 15:00:11 -06:00
Meredith Lancaster
fa6536493f predicate-type is no longer empty
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-25 14:54:52 -06:00
Meredith Lancaster
e8013c0778 update documentation to indclude predicate-type information
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-25 14:04:54 -06:00
Meredith Lancaster
4d57c79770 set provenance predicate type as default for predicate-type flag
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-24 11:40:55 -06:00
Tyler McGoffin
81591a09b8 Use go-gh/auth package for IsEnterprise, IsTenancy, and NormalizeHostname 2024-10-15 11:56:43 -07:00
Brian DeHamer
2e13ec5d80
Merge pull request #9616 from cli/bdehamer/custom-issuer-error
Better messaging for `attestation verify` custom issuer mismatch error
2024-09-16 12:52:12 -07:00
Brian DeHamer
8c8423aa3d
better error for att verify custom issuer mismatch
Signed-off-by: Brian DeHamer <bdehamer@github.com>
Co-authored-by: Zach Steindler <steiza@github.com>
Co-authored-by: Phill MV <phillmv@github.com>
2024-09-16 12:38:12 -07:00
William Martin
352737cb60 Use api subdomains for commands using ghinstance package 2024-09-13 15:03:36 +02:00
Brian DeHamer
f128ae8349
add att verify test for custom OIDC issuer
Signed-off-by: Brian DeHamer <bdehamer@github.com>
2024-09-11 12:49:06 -07:00
Fredrik Skogman
1b59ec8ad0
This commit introduces tenancy aware attestation policy building.
This is done by inspecting the current hostname to determine if
tenancy is enabled.

The attestation commands also accepts a --hostname parameter, that
is used to pick the current host, similar to how the GH_HOST variable
can be used.

Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
2024-09-11 10:49:17 +02:00