Commit graph

1137 commits

Author SHA1 Message Date
Nate Smith
deb7ee6aa4
Merge pull request #689 from muesli/glamour-bump
Bump glamour dependency
2020-03-20 12:26:53 -07:00
Christian Muehlhaeuser
d2fda98e16
Bump glamour dependency
This fixes #647 by not retrieving the terminal's background color on init.
2020-03-20 18:51:17 +01:00
Mislav Marohnić
488b47bded Enable tests to capture spinner output
Explicitly assign the writer stream for the progress spinner so that
tests may override it.

The default when not in testing stays the same: the output stream is the
colorable stdout.
2020-03-20 18:18:27 +01:00
Mislav Marohnić
88c060c610 Fix broken pr view test 2020-03-20 18:15:09 +01:00
Mislav Marohnić
9786498a25 Respect base repository when passing URL argument to pr checkout/view
Previously, the repository owner+name component of the URL was ignored
and only the pull request number was read. Now, the URL dictates which
base repository will be used.
2020-03-20 18:06:40 +01:00
Mislav Marohnić
e3653672a8 Simplify git.AddRemote implementation
The 2nd argument now unused since we've determined that, in practice, we
can safely fetch git objects from a freshly created fork on GitHub and
that we don't need the remote URL-swapping workaround.
2020-03-20 13:08:33 +01:00
Toshiya Doi
0ba0a0757d Merge branch 'master' into view-the-current-state 2020-03-20 18:16:47 +09:00
Toshiya Doi
1a5e9f1b61 Apply table driven testing for pr/issue preview commands 2020-03-20 16:32:52 +09:00
Amanda Pinsker
57942fcaf8 Add unicode for merge states back in 2020-03-19 13:30:35 -07:00
Amanda Pinsker
fe7def13d3 Update tests 2020-03-19 13:16:07 -07:00
Amanda Pinsker
be7ffe3099 Tweak unicode some more 2020-03-19 13:16:00 -07:00
Amanda Pinsker
ef17aa520d Add unicode to pr status 2020-03-19 10:33:34 -07:00
Mislav Marohnić
d75faab85a Creating a PR now always prioritizes an existing fork as a push target
Before: the default push target for the current branch in `pr create`
was the first repository found among git remotes that has write access.

Now: the default push target is the fork the base repo, if said fork
exists and has write access, falling back to old behavior otherwise.

This change in the default is to facilitate contributions to projects
that have a hard requirement that all pull requests (even those opened
by people with write access to that project) come from forks.
2020-03-19 16:04:23 +01:00
Nate Smith
2660561ed9
Merge pull request #673 from cli/bump-homebrew-formula
Configure bump-homebrew-formula action for homebrew-core
2020-03-18 12:34:51 -07:00
Mislav Marohnić
1179618e9a Configure bump-homebrew-formula action for homebrew-core 2020-03-18 20:30:02 +01:00
Nate Smith
c1e7588966
Merge pull request #440 from ShahzadUmair/pr-count
Added pr count with list command
2020-03-18 09:27:36 -07:00
Nate Smith
51eb2cb345
Merge branch 'master' into pr-count 2020-03-18 09:26:05 -07:00
Billy Griffin
3d6089778b
Merge pull request #666 from cli/ghes-support-detail
More detail about GHES support
2020-03-18 10:12:34 -06:00
Nate Smith
3334bdd9b7
Merge pull request #668 from cli/mislav/check-if-pr-exists
Check for existing pull request on `pr create`
2020-03-18 08:37:28 -07:00
Nate Smith
75ebf1694f
Merge pull request #670 from cli/pr-status-branch-err
Allow `pr status` in cases where there is no current git branch
2020-03-18 08:34:41 -07:00
Mislav Marohnić
206844681b
Merge pull request #669 from doi-t/add-pr-status-tests
Add unit tests for Closed and Merged states of the current branch
2020-03-18 14:21:42 +01:00
Mislav Marohnić
a40fb04fc3 Allow pr status use when on detached HEAD 2020-03-18 14:14:45 +01:00
Mislav Marohnić
bec667964c Allow pr status -R <repo> usage from outside of a git repo 2020-03-18 14:13:17 +01:00
Mislav Marohnić
e80c2f852d
Merge pull request #656 from sh7dm/fix-repo-not-found
Don't list remotes when --repo flag is set
2020-03-18 13:53:57 +01:00
Toshiya Doi
a2d3923d21 Add unit tests for Closed and Merged states of the current branch 2020-03-18 21:35:06 +09:00
Mislav Marohnić
5b76881624 Improve detecting existing PR on pr create
- Only check for existing PRs if `--web` wasn't given
- Fix detecting PRs from forks
- Improve order of error handling: local validation errors are handled
  earlier than the ones that have to consult the API
2020-03-18 13:09:02 +01:00
Mislav Marohnić
23dfeff84f Merge remote-tracking branch 'origin/master' into check-if-pr-exists 2020-03-18 12:04:08 +01:00
Mislav Marohnić
cb06812d19
Merge pull request #532 from mingrammer/consistent-printing
fix: inconsistent format between issue list and status
2020-03-18 11:59:17 +01:00
Toshiya Doi
a5bd3130c4 Cleanup 2020-03-18 10:03:04 +09:00
Toshiya Doi
327a804959 Fix tests to support the "Draft" state badge 2020-03-18 09:57:46 +09:00
Toshiya Doi
e50ba549d8 Rename OPEN state to Draft for a Draft PR 2020-03-18 09:55:47 +09:00
Toshiya Doi
cf69d7e47f Add test fixtures for viewing Draft state in CLI 2020-03-18 08:53:12 +09:00
Toshiya Doi
7ceffd0827 Merge branch 'master' into view-the-current-state 2020-03-18 08:51:04 +09:00
Toshiya Doi
762e806c9e Add tests for viewing a Draft PR in CLI 2020-03-18 08:23:29 +09:00
Billy Griffin
3e21043bc3
more specific timeframe
Co-Authored-By: Neha Batra <nerdneha@github.com>
2020-03-17 16:35:19 -06:00
Toshiya Doi
7b5a0b5694 Add a missing isDraft for querying PR by number 2020-03-18 07:32:18 +09:00
Toshiya Doi
0cfa4be86a Add tests for utilities of PR/issue state format 2020-03-18 07:30:28 +09:00
vilmibm
e4b43b08b9 update usage text 2020-03-17 17:13:48 -05:00
Billy Griffin
c869211f9e
More detail about GHES support 2020-03-17 16:12:44 -06:00
vilmibm
00de6b9c09 switch defaults for issue view 2020-03-17 17:06:42 -05:00
vilmibm
c30b482bf0 switch defaults for pr view 2020-03-17 17:06:42 -05:00
Nate Smith
74a2a24104
Merge pull request #590 from cli/pr-create-autofill
autofill title/body for PRs
2020-03-17 14:24:21 -07:00
vilmibm
0344e9543a humanize branch name for title 2020-03-17 16:18:32 -05:00
vilmibm
98a2281f45 more nuanced error handling 2020-03-17 16:09:40 -05:00
Toshiya Doi
46a632c8f6 Fix utility function scopes 2020-03-18 04:52:03 +09:00
Toshiya Doi
e85259d84f Remove labels from the issue preview header
See https://github.com/cli/cli/issues/652#issuecomment-598940740
2020-03-18 04:42:50 +09:00
Dmitry Sharshakov
d755288cdf Implement review comments 2020-03-17 20:05:53 +03:00
vilmibm
af46fcb1ff --fill for pr create 2020-03-16 15:32:47 -05:00
vilmibm
2d90c09f48 review feedback 2020-03-16 15:32:35 -05:00
Mislav Marohnić
da4bbe398e
Merge pull request #650 from cli/oauth-localhost-callback
Avoid redirecting to `localhost` during authorization flow
2020-03-16 15:08:23 +01:00