These changes are demonstrating how `gh` commands that support v1 classic projects can determine if support exists by checking the GHES server version.
https://github.com/microsoft/dev-tunnels/pull/322 introduced a few
breaking changes:
* Port Tags were renamed to Labels
* Client construction must now provide an API version (of which there is only one)
* The /api/v1 prefix was dropped from request paths
* TunnelPortListResponses may now be paginated (but we don't support that)
* Requests to create a port with a changed protocol began erroring
After discussing my previous change to the test, I'm restoring the previous keyring setup to reflect the specific situation.
I added clarifying comments to help the next reviewer.
* Improve assertion for disabled echo
Signed-off-by: Babak K. Shandiz <babakks@github.com>
* Use `expect.RegExpPattern`
Signed-off-by: Babak K. Shandiz <babakks@github.com>
---------
Signed-off-by: Babak K. Shandiz <babakks@github.com>
- added support for `accessible_colors` configuration setting in `gh config` commandset
- updated default configuration file to contain `accessible_colors: disabled`
- add `GH_ACCESSIBLE_COLORS` env var to `gh environment`
- generated mocks via `go generate ./...` including previously missed prompter changes
This test was trying to block on `expect`’ing a string at the same
time the prompt was completed.
This doesn't need to happen for this test. It should just check for
the output from the Input prompt invocation.
Apparently, `gh` might not actually have an editor at the time we're prompting
the user if they want to use it for markdown editing. In the survey package,
there is a function that will handle fallback to the default editor based on
environment variables and parse it in the case the editor contains flags and
arguments for cases like Visual Studio Code.
Additionally, there are no tests for the EditorName function and the fact it
is loaded via `init` makes this difficult to test.
Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
