Commit graph

4140 commits

Author SHA1 Message Date
danochoa
9c65a32ef8 gist delete prompt with gist description 2025-01-08 17:56:02 -06:00
Tyler McGoffin
15ac566222 Remove shadowed errors from prSelectorForCurrentBranch and cover with tests 2025-01-08 15:21:05 -08:00
Tyler McGoffin
94b2d4ec3b Added tests to cover prSelectorForCurrentBranch for confidence in refactor 2025-01-08 15:00:38 -08:00
Tyler McGoffin
ec9eaef048 Refactor prSelectorForCurrentBranch and tests
Replace the git config argument in prSelectorForCurrentBranch with
the branchConfig it was used to fetch. The tests needed to be refactored
accordingly to support this change to the prSelectorForCurrentBranch API.
In addition, I've moved the test to a table test format so I can expand
the test coverage in the next commit.
2025-01-08 14:34:49 -08:00
Meredith Lancaster
c2fdac272c update table column headers
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-08 13:27:38 -07:00
Tyler McGoffin
fea46c0011 Change ReadBranchConfig error message in gh pr create 2025-01-08 11:40:42 -08:00
Meredith Lancaster
1c16e12a66 update test fixtures to include buildConfigURI
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-08 11:16:23 -07:00
Meredith Lancaster
8ad877b188 add check for invalid attestation
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-08 08:38:43 -07:00
Mateus Marquezini
a3a283ca83 Merge branch 'trunk' into fix/issue_10042 2025-01-08 09:08:41 -03:00
danochoa
7d1d261c82 Merge branch 'trunk' into gh-gist-delete-prompt 2025-01-08 02:30:21 -06:00
danochoa
a8f0aaeb3d tentative updates for acceptance criteria
- pending confirmation re description in prompt
2025-01-08 02:22:21 -06:00
Meredith Lancaster
33d0002d21 update tests to use new function name
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-07 15:22:02 -07:00
Meredith Lancaster
8d89dd97fd
Update pkg/cmd/attestation/api/client.go
Co-authored-by: Phill MV <phillmv@github.com>
2025-01-07 15:14:53 -07:00
Meredith Lancaster
51a74aed1d
Update pkg/cmd/attestation/api/client.go
Co-authored-by: Phill MV <phillmv@github.com>
2025-01-07 15:14:23 -07:00
Tyler McGoffin
c83cf32cff Remove named return values from prSelectorForCurrentBranch 2025-01-07 13:54:43 -08:00
Tyler McGoffin
bf6fdbdfd2 Remove named returns from ReadBranchConfig and surface errors 2025-01-07 13:54:43 -08:00
Meredith Lancaster
42cb2547cd remove old comment
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-07 14:13:50 -07:00
Meredith Lancaster
1e91828cdf remove commented out code
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-07 13:36:50 -07:00
Meredith Lancaster
eb9eb261f0
Merge branch 'trunk' into update-attestation-verify-table-output 2025-01-07 12:14:01 -07:00
Meredith Lancaster
d4f3fbce9b
Merge branch 'trunk' into fetch-artifact-attestation-bundles-with-sas-url 2025-01-07 12:04:12 -07:00
Meredith Lancaster
f46cccbab4 comment
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-07 12:03:49 -07:00
Meredith Lancaster
258c69cd26 undo more name chanages
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-07 11:56:05 -07:00
Meredith Lancaster
0a602fae07 undo other name change
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-07 11:54:02 -07:00
Meredith Lancaster
37e0969f20 remove spaces
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-07 11:51:51 -07:00
Meredith Lancaster
3c0280c4d7 undo name change for now
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-07 11:51:23 -07:00
Meredith Lancaster
7838e912b6 more mock http client cleanup
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-07 11:37:02 -07:00
Meredith Lancaster
9d88ca8cf8 simplify mock http client
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-07 11:32:49 -07:00
Meredith Lancaster
ecf55c6c16 use mock to assert number of http calls
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-07 10:54:17 -07:00
Meredith Lancaster
e34e188ee2 add http client test constructors
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-07 10:43:24 -07:00
Meredith Lancaster
9ecd90c26c setup testing struct for test cases
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-07 10:24:42 -07:00
nobe4
442be87acb
Merge branch 'trunk' into fancier-extention-upgrade 2025-01-07 12:04:35 +01:00
nobe4
3b69ea6fbc
feat: make the extension upgrade fancier
This left-pad the extension names during upgrade so they all align
nicely. It makes easier to see what is happening.
2025-01-07 12:01:02 +01:00
Michael Hoffman
b3be3aa16b
Merge branch 'trunk' into create-autolinks 2025-01-06 16:09:40 -05:00
Andy Feller
40984d1eb6
Merge pull request #10186 from cli/wm/clear-up-fine-grained-pats-auth-login
Clear up --with-token fine grained PAT usage
2025-01-06 15:24:37 -05:00
Meredith Lancaster
69865117ab add mutex for test field
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-06 13:14:02 -07:00
Meredith Lancaster
fb4fc7e7c2 Merge branch 'fetch-artifact-attestation-bundles-with-sas-url' of github.com:malancas/cli into fetch-artifact-attestation-bundles-with-sas-url 2025-01-06 12:58:13 -07:00
Meredith Lancaster
0202ca8df5 add test case for bundle url fetch failure
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-06 12:58:09 -07:00
Meredith Lancaster
b1af4b0ce3
Merge branch 'trunk' into fetch-artifact-attestation-bundles-with-sas-url 2025-01-06 12:49:27 -07:00
Meredith Lancaster
e03a36ea3c add tests for bundle url fetch and fallback
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-06 12:12:26 -07:00
Tyler McGoffin
1f4e005562
Merge pull request #10158 from aryanbhosale/trunk
fix(repo fork): add non-TTY output when fork is newly created
2025-01-06 10:11:14 -08:00
Michael Hoffman
db51c36433
Merge branch 'cli:trunk' into create-autolinks 2025-01-06 12:46:04 -05:00
Meredith Lancaster
070b67e5a4 fetch bundles in parallel
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-06 10:44:55 -07:00
Meredith Lancaster
311f2b2e23 return fetch attestations err directly
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-06 10:39:40 -07:00
Tyler McGoffin
2358fcee83
Merge pull request #10177 from cli/cmbrose/pr-create-upstream-fix
Handle missing upstream configs for `gh pr create`
2025-01-06 09:32:00 -08:00
Meredith Lancaster
fc984c91d0 Merge branch 'fetch-artifact-attestation-bundles-with-sas-url' of github.com:malancas/cli into fetch-artifact-attestation-bundles-with-sas-url 2025-01-06 10:21:37 -07:00
Meredith Lancaster
9051da39fc provide additional logging and fallback
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-06 10:19:47 -07:00
Meredith Lancaster
706314b005
Merge branch 'trunk' into fetch-artifact-attestation-bundles-with-sas-url 2025-01-06 09:57:57 -07:00
William Martin
c3b41e87b8 Panic mustParseTrackingRef if format is incorrect 2025-01-06 10:33:28 -06:00
William Martin
8b5073d617 Move trackingRef into pr create package 2025-01-06 10:33:28 -06:00
William Martin
62ecb1c84d Make tryDetermineTrackingRef tests more respective of reality
Though it doesn't really matter, in practice upstream is always going to come before origin.
2025-01-06 10:33:28 -06:00